Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bdc8c280-534d-5de0-050f-2dc3db2e41d0@gmail.com>
Date:   Mon, 11 Oct 2021 22:41:12 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is
 always false
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Fabio Aiuto <fabioaiuto83@gmail.com>, saurav.girepunje@hotmail.com,
        gregkh@linuxfoundation.org, marcocesati@gmail.com,
        lee.jones@linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <YWKXKGuA/Io9sEjf@user> <YWLFf1zPvK9gz+7+@agape.jhs>
 <9dca9f7e-f987-5be5-9523-7dd08c2b364e@gmail.com>
 <20211011104141.GP2083@kadam>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
Content-Language: en-GB
In-Reply-To: <20211011104141.GP2083@kadam>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/10/21 4:11 pm, Dan Carpenter wrote:
> Yep.  And please go through the function and clean up all the references
> to max_rf_path.  Change the "max_rf_path = 0" to 1 and delete the other
> assignment.  Delete the comments about "max_rf_path == 2".
> 
> regards,
> dan carpenter
> 

Yes, Is it good if I send 2 patches one to remove "if condition which is always 
false" and another one to "clean-up all the references to max_rf_path" on a single
patch series. 

Regards,
Saurav