Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] habanalabs: select CRC32
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Oded Gabbay <ogabbay@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20211011151443.12040-1-vegard.nossum@oracle.com>
 <CAK8P3a2+dU53PMJZvkDDGUyv=EiHuc03njGf6SXTxw9A4ByeHw@mail.gmail.com>
From:   Vegard Nossum <vegard.nossum@oracle.com>
Message-ID: <47e60186-2408-19cf-3231-92bd9c30483a@oracle.com>
Date:   Mon, 11 Oct 2021 18:29:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CAK8P3a2+dU53PMJZvkDDGUyv=EiHuc03njGf6SXTxw9A4ByeHw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnZneGVZQ3VKYWtWUi8vNzZqQmRFZEo0NzJmRzZpNUZCbUsvb2xwaEpjY1Zm?=
 =?utf-8?B?d1lUczE5STg3dUtiTm9MTms4YnJiVk1QVFB6OTRzeSs3OTRXcTdrVTIwZ2Zm?=
 =?utf-8?B?c1Z1MU02dEJ5NzBDSHpmZFFWck4xZFY5bXYwem9MYzkreEh0MGsyN3RQYzNw?=
 =?utf-8?B?eWViYzE5ZTV6ZWFybVF5WjBzcUxPK3Vvbm5jZHlCNElXV1JrZ3N2cVVVb1Jn?=
 =?utf-8?B?NEYxV3ZmS3lnaVBPTGo0azUxcktLU2tVaFB6Q2xzMVI2R0lkbjVsWUtlV3JP?=
 =?utf-8?B?OVgvS0VvWUk3SGpONVR6MmpQSjg1ZjBzSWRGSHVjemZldkRicFdObXJObk96?=
 =?utf-8?B?N3FZbUREWHlUMEMzd2poMmRTNkFLK0Fpb1hmN0dhcThsTUdPaDYxaHVBR2s5?=
 =?utf-8?B?TWpZbVY4SEdmNzNIb1AydFg2L1AxT2xPV2FWeERvSG9DSUxvcms4OGZzdkVH?=
 =?utf-8?B?U2VMWE5zQ3lxOFVqdEFYQXJVaXdEaVFDMHVnNldFZmhwL2tPQUhSazBkdUJy?=
 =?utf-8?B?SjhtVXlTbERHOThZMWZpZC9NTGxDOERySCtWWEp0TERRdGNNcVFycXRMT3M0?=
 =?utf-8?B?b2V0TnI0MFMyUStFaXRWcEVSUG5jVnNhSGZNQzRKSXptRDQ2ZC9FQ1llVVhP?=
 =?utf-8?B?d2RKSTNhNXcweDNOK0gvS292OGh4QWlPRXd6eTNwck5zdGFTbG14OTV0Qkh0?=
 =?utf-8?B?c3RBdjV1QlpYN1QzN0ViUG5QZWhBZlVhN3hDNHorendwemYyS215QXNkRVdP?=
 =?utf-8?B?ekYyR3p5SEtGd3RFTFFjMmFITUdrb1lWWStQR2VvNzZzdUpZZnlrdjV1RHBE?=
 =?utf-8?B?QzM1VDlvSDk3TnFtc0lKV1hVWFVSLy9XQVhLUUN6Q29iSlRBN3BpVjZySk1C?=
 =?utf-8?B?UStIRFJhQXg4VFVtMVhPZ3Q4Tlp3MXF5UWpibjZzTmpJS1BlckZNdHp6cTlr?=
 =?utf-8?B?RU9RTEdFaWVkeUo1K1ErNENBcmlxc211eW16TDVjV3d2SkgyeXVzcmlCaytW?=
 =?utf-8?B?VGtpdWlEVHZLbkovZU4zM2o0VXJqK2NOQmpibzVkWFVoU29na0MwSlpvRXVz?=
 =?utf-8?B?VWM1TVdYbTMzYWprRkYzdnZHejBLeUlCYzVjV2FEd0Rlc3htUHAyMC9rbDVo?=
 =?utf-8?B?MGt5b1o1UGlLRldOcExaZXBKRXFyUmlzaG9MQ3M3KzFLcTNQOFUvTDloSDFJ?=
 =?utf-8?B?L0M5TTQ2aUV2UFJyRmZKVktka1ZNOHY2UEVmU3NIWHNnZGRqdHFOUzNmOUJ5?=
 =?utf-8?B?SVh3REJjQWc2NWhqRG85Yk5BN3poWERVY0Urb3hiRC9PYWZFNEdNRnYxTnJv?=
 =?utf-8?B?MlNHaFFIRTZvNnpqT1dkRXhGRjEzSmhYcHkwMXB5YkxBdG1kcXZwZkZKMWRp?=
 =?utf-8?B?cXZMTitLWkRPVVFxaElWM3MzUnFHazhzdjRVVWx5b2Z3TWFmK3lpOXBpQ0xC?=
 =?utf-8?B?N0dKeFBJUERZR1ozQlJEdFdCSUh2b2lyNzZYVGhSL2llSStXUVdac0NQTXBT?=
 =?utf-8?B?RDJ1aUxXdnA0TWxBM1Z6VklIYk5ZcjU5cFdJVXF1MWdDZUk2ZkozQVVhaFZK?=
 =?utf-8?B?MmIyYnJMeGx1aVpLOGYyc0RRdDBmcUNxRUJNbmNEMjFyMVNFTlZ0WXgwbEo4?=
 =?utf-8?B?RDJ6YjU2WE90cjlZV3JpRG9UOW8vbDlnNGV5ajA1dERLTmJSMDNkYjF1N2Yz?=
 =?utf-8?B?M0o4ZUxGN08rTGx2dTNjbFJPciszVmRiTks4QkhSYm13a1VmL1NHbVRGRU1B?=
 =?utf-8?Q?j5AyWF48Em/dVbsZvrCKiQeZIXHN4YtkR2Swg9X?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d92da99e-2c8c-4f27-8ab2-08d98cd44029
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 16:29:08.9056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Df5CHGDF6t/3oNPU01E8MZK/mNLLtOE+FwNsjD0czRjiOcTuNXDnOzRaLH7Z+clxj1PPxtfw17Dn8bYAALlMm3AoOp9aXND6oli7a1geSmc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4552
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110096
X-Proofpoint-ORIG-GUID: GXZJpH77_sWZHIEqryoH6KVHI91ckPb1
X-Proofpoint-GUID: GXZJpH77_sWZHIEqryoH6KVHI91ckPb1
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/21 5:33 PM, Arnd Bergmann wrote:
> On Mon, Oct 11, 2021 at 5:14 PM Vegard Nossum <vegard.nossum@oracle.com> wrote:
>>
>> Fix the following build/link error by adding a dependency on the CRC32
>> routines:
>>
>>   ld: drivers/misc/habanalabs/common/firmware_if.o: in function `hl_fw_dynamic_request_descriptor':
>>   firmware_if.c:(.text.unlikely+0xc89): undefined reference to `crc32_le'
>>
>> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> 
> Patch looks good to me, I wonder how I never caught that with my own randconfig
> build testing. May I ask how you found it?
> 
> Fixes: 8a43c83fec12 ("habanalabs: load boot fit to device")
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 

Thanks.

I'm working on a couple of new make targets, satconfig and
satrandconfig, which can generate .configs that respect a set of choices
specified in a .satconfig file (and, of course, the Kconfig files).

In this case, I was just doing satrandconfig builds and noticed that the
crc32_le ones popped up quite often so I just added CONFIG_CRC32=n to my
.satconfig, which means that satrandconfig will generate only configs
that have CRC32=n.

I also suspect that satrandconfig samples the configuration space MUCH
more uniformly than randconfig, in the sense that "make randconfig" will
tend to have CRC32 enabled just because there are so many drivers that
_do_ select it. (Think of it this way, every prompt for an option that
has "select CRC32" in it will be another 50% probability of actually
enabling the option.)

I just tried doing 'make randconfig' 100 times and the result was
CRC32=y every single time.

If I do the same for 'make satrandconfig', I get the following
distribution of values:

48 CRC32=y
10 CRC32=m
42 CRC32=n

That's probably still not really uniform, but quite a bit better, and as
I said I can still put CONFIG_CRC32=n in my .satconfig and get _only_
configs that respect this choice.

The really cool thing about sat{,rand}config IMHO is that you can fairly
easily generate random configs that you know will be bootable (because
you've forced it to only output configs that respect options that you
need to boot on your particular setup).

This project itself is about 11 years old, but I made a breakthrough
recently and I'm polishing the patches for submission now. I thought I
would try to fix the breakage that I could find first so it doesn't
appear as if the tool itself is broken... (that's not to say it doesn't
have any bugs, however!)


Vegard