Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 18:49:52 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc:     alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
        Sunil-kumar.Dommati@amd.com, David.Rhodes@cirrus.com,
        wtli@nuvoton.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ASoc: amd: create platform device for VG machine
 driver
Message-ID: <YWR5QH1lYqiT1cX+@sirena.org.uk>
References: <20211011184715.61573-1-Vijendar.Mukunda@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ZJ2pBbMc2TIawQ/G"
Content-Disposition: inline
In-Reply-To: <20211011184715.61573-1-Vijendar.Mukunda@amd.com>
Precedence: bulk


--ZJ2pBbMc2TIawQ/G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 12, 2021 at 12:17:01AM +0530, Vijendar Mukunda wrote:

>  		pdevinfo[2].res =3D &adata->res[2];
> =20
> +		pdevinfo[3].name =3D "acp5x_nu8821_cs35l41_mach";
> +		pdevinfo[3].id =3D 0;
> +		pdevinfo[3].parent =3D &pci->dev;

This appears to unconditionally assume that any machine with this
hardware is going to have exactly the same CODEC/amp combination - that
seems like it's going to go badly at some point.  Shouldn't there be
some other check that we're instantiating the right machine driver?

BTW your clock appears to be set quite a way into the future (possibly
about 24 hours?) which is confusing things.

--ZJ2pBbMc2TIawQ/G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFkeT8ACgkQJNaLcl1U
h9Djhwf/ZavfF+JGMWA/XWM0KiIkQXHWhRAw0Ql/y3suDpNI1W2VtO+lYx5JJTmf
HMLPXKxLQomTujyTppWnz6abtrROefKDPzWNPRTVBA7CsQNpu5+a27qGdSXgJzZ2
Z531dwpZz+w2ITM4nrrlr+0UmGJJVNSfVWO1IVTSPYIIKA1rK6xtl/qWA7C6hU1x
XDXt7Inokj6u7e/mEU1nypwYp7cESxC0aTyHZ/RRVZV0xjAUqshu3l9mU0nEdgd7
NGfXMISM6zLURSZqfimjFpiomqU7SNv8HbQbpnD52r0v+Ls/4q7WAYpop+wMNQLz
eSybP0NJpYLXH1QyhNL0Q3jYCn3qyw==
=+nOi
-----END PGP SIGNATURE-----

--ZJ2pBbMc2TIawQ/G--