Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/3] ASoc: amd: create platform device for VG machine
 driver
To:     Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
        Sunil-kumar.Dommati@amd.com, David.Rhodes@cirrus.com,
        wtli@nuvoton.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211011184715.61573-1-Vijendar.Mukunda@amd.com>
 <YWR5QH1lYqiT1cX+@sirena.org.uk>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <57f313fe-fb8e-8b4b-8839-d9d8653880d1@amd.com>
Date:   Mon, 11 Oct 2021 11:48:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YWR5QH1lYqiT1cX+@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?efShogG5EfdN5uFoOsHAQxXdAHw58+qrfQhfxirvyQ6vU/GE4HUwEUdt?=
 =?Windows-1252?Q?s3LRVR8SlZ76kYbyAGmKhGnGfcbda8WC/PUlW9mCpPJ9YGLFPUJQ4bO7?=
 =?Windows-1252?Q?XmfoXW9JV1lKNTyMKXJcqQK150Sjm8/EDOI0cbTXgMm4knAx6Xy5JJ59?=
 =?Windows-1252?Q?EPFnFOg0qg3ZxGICTYj4NGpRe2VYL/2VfGz7ciPUrkRL+m5emn88JUcH?=
 =?Windows-1252?Q?8JRV2SoahJcv+54eU8tcJwGu510ohfrMsoVUqxueDg0H0WzBIytAGDyB?=
 =?Windows-1252?Q?/bEbfhejVNeaFlOwPLHg23NdBMdnzEjH6WlAac3zIkeuSZ/yy/lF6Fj/?=
 =?Windows-1252?Q?xziffQbao1zOR/eM1IcAOAY10v3hSTPGP4Dyu4iAMBecKIhbaXzWGrsE?=
 =?Windows-1252?Q?1yrW+vWSSsww04p7V5uYwSTEkbfNjNTzvfjCvfzD83bvQ6JaP3fdoARq?=
 =?Windows-1252?Q?AM8ZfjJRpKHOq2sHYFjsoqd1KS1AvX1uBjj+1dgOhvpf4YGXiy/J0w2t?=
 =?Windows-1252?Q?ODwULHXCQtdQIM9ZVmmRHF2BnZuAgWXPl1BDZ3mk0cG7ZBy/okk5Y7MV?=
 =?Windows-1252?Q?WMV7NE8PHlugMj6u2PyNHmzzhuKgvcCU2tXV1ftqzIpxKIGMBS0VqbAf?=
 =?Windows-1252?Q?oWaghXIyBb4SIqgou9clLaCg67p4bTW93X55Olo//OM9tRWmqRNYGeDI?=
 =?Windows-1252?Q?n+UTCvphMhVPECLK9hL/nWjhrLBIVk8waDOnxrku0Saagn8TMycAAFIO?=
 =?Windows-1252?Q?/P30hSB3EhJGfFGic0LWRaMjYVgEJYo9lmEUqSwBAT6r5q+4eOzlF0yy?=
 =?Windows-1252?Q?MpV5BYhU2ep7APngno2+5q+EY7OLPBHZcWfBK8cmigE1SLhHkDCoEKBD?=
 =?Windows-1252?Q?9sBLR/aT4lv/5inBtsQZ4tE2AYhiLSIV+uvQaH7jwjNkUKnxjP16nFv3?=
 =?Windows-1252?Q?o5oq0LMDE0dPlSYxBK4ZQ2x/XlVRxN0KjKkwVI/S0PUw8gK5z/ZWwqGi?=
 =?Windows-1252?Q?rq9w/IqBgvTvwHGW8bWRUUcPbXp9bEJ+MtYrrCRBg04H8W3Vim/HwT3x?=
 =?Windows-1252?Q?Vpi14vth1q2e+/T4e7vKdq+C3JWQMhoktZNsVDMtOZs3t6fhI3+Fx6n7?=
 =?Windows-1252?Q?e4guhnMAC9biNEQhM1AEBrS8kB8/RDWDq4FGbUtlgz1TFaEupGUQGETg?=
 =?Windows-1252?Q?wTb9F0bsMeA+LL/lZ4pvwWs39FaMyaLwA2hc7HWKXWXLzaWz3e48ioew?=
 =?Windows-1252?Q?Fq2/U+2eV88IN5QzyN5xC79lOKyKAeWF6SAhiXzAczh3mWKEmUG+3p4o?=
 =?Windows-1252?Q?nY6IxZuJHyUPWPD7I4TLYoz/TW27FZpTQP/2WEciOFeTDpOtzanvGOGc?=
 =?Windows-1252?Q?cUOwRtAHyrDXgeaTdUdeOKuvio8QZBL+QarIixzqOMH5XoT7YQFuAViB?=
 =?Windows-1252?Q?nJlLpF8Lk6IN7ltn600IDQ=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09e21f74-4d74-42b7-43d5-08d98ce385fb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 18:18:28.4878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tnlImqZjGZV1rK06iCsi4dY2ZCH0HCaIT6X87uVdz9bsEtPZ+MKd7YuPBMHUc3UJIwxyAvEpkP6rjWiKiMW0Sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0252
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/21 11:19 PM, Mark Brown wrote:
> On Tue, Oct 12, 2021 at 12:17:01AM +0530, Vijendar Mukunda wrote:
> 
>>  		pdevinfo[2].res = &adata->res[2];
>>  
>> +		pdevinfo[3].name = "acp5x_nu8821_cs35l41_mach";
>> +		pdevinfo[3].id = 0;
>> +		pdevinfo[3].parent = &pci->dev;
> 
> This appears to unconditionally assume that any machine with this
> hardware is going to have exactly the same CODEC/amp combination - that
> seems like it's going to go badly at some point.  Shouldn't there be
> some other check that we're instantiating the right machine driver?
> 

we will make the platform device as generic one something like "acp5x_mach".

Currently we have only one target platform with above codec combinations
for this APU series.

When we get new codecs combinations to support, we will address it in
machine driver by adding DMI checks for distinguishing codec combinations.


> BTW your clock appears to be set quite a way into the future (possibly
> about 24 hours?) which is confusing things.
> 

Will fix the system time settings.