Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/3] ASoc: amd: create platform device for VG machine
 driver
To:     Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
        Sunil-kumar.Dommati@amd.com, David.Rhodes@cirrus.com,
        wtli@nuvoton.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211011184715.61573-1-Vijendar.Mukunda@amd.com>
 <YWR5QH1lYqiT1cX+@sirena.org.uk>
 <57f313fe-fb8e-8b4b-8839-d9d8653880d1@amd.com>
 <YWSCg2Nzi8lRDiIE@sirena.org.uk>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <4ded51b9-efcf-8acb-f399-e169a34badba@amd.com>
Date:   Mon, 11 Oct 2021 12:13:59 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YWSCg2Nzi8lRDiIE@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?/KO9dPQwIHSflZOkwnpWZrdZDx8pvLeS07d/HueOSs0cI21iSUxOpeAC?=
 =?Windows-1252?Q?vBbuNK7sb6vhNG52M0VDjrBFJVz3xNiViY/jx0aFKl5tdvHQVUkZhMGD?=
 =?Windows-1252?Q?MaYiMdfs7Chiy8S03tUMKCiynahOnY/0vy+X/oKeRgls4z21/wHegzWy?=
 =?Windows-1252?Q?ABh/O9SYSk5BClUHyAWKk2UIO6HlTDDvYbsSgBKKqcPaEuHnKeN+dZR+?=
 =?Windows-1252?Q?KANm9Vv+5mq0mBj5jn3KArDJOK7Xgi4RklRH5WZJECji4OITMqnvt+6T?=
 =?Windows-1252?Q?K18cQd1tkmr2uDN0oIIElAeAVHwUvdhkAhru9qaG70w9sg5mX1vOykYh?=
 =?Windows-1252?Q?wZ50YygF4I+0EZfibh3XWgDZHlFWoEJcY6ECpJlr2+uGpWrrdE40eoHn?=
 =?Windows-1252?Q?P4JiVf4S7NiJDLg6W71+qYbPPF8UrYGV0/yftdLB5IHfgPfzXuwKiQZ6?=
 =?Windows-1252?Q?99i7Rmw5c8soLjJ8nIcELpqOCjc1BsDcAi0AC0Kh+sS8Q95IASu6tDlz?=
 =?Windows-1252?Q?5aB7lmzsER4ZFU+YtnUCjNYk631YrUrene5wYaIewrg2yAfNZ8j6DLQ6?=
 =?Windows-1252?Q?y+4vuamJNl7AAr8UH1AZy9KTDj7+7HbuFe+zWWJmOCMxtJCabZ/qCVye?=
 =?Windows-1252?Q?GegplzLGEniMXlDkFUombNwgg2e5r5mAT78FXVFTcAzOvQQ6BvRQ1Ghc?=
 =?Windows-1252?Q?PKSZCRT0Xxx/wgnfvlDASf4VvVkaBB2f1nDp61HWp9A+X8HRipDvB9Jw?=
 =?Windows-1252?Q?Dbs1guR4WHDCKknaRpPWM1MuQOQ/uoqbS8RrKzJuWSqO6GqlQ7vsblpk?=
 =?Windows-1252?Q?Qm1Slj0lnnHP0XD9PEmAQnXv2ABYm4fRuQuisc1a2HlISj5TAZhdtWgm?=
 =?Windows-1252?Q?FMvAsZl+EBn2qXfkPW5jB+1JXNlJTSQx7jD5ff4mxv6rSQH1gdDDJ8zY?=
 =?Windows-1252?Q?msMVbiU8mi5Xp4NjPkpiJR9HbLZdqXJ1jIka6TSYwzI568kbHNnNHGlj?=
 =?Windows-1252?Q?/mHTI+cIC7ua11bnJ36M8mYdkFmLaTHGLl7Zz1NVo1ZNGzRQAj1je1/R?=
 =?Windows-1252?Q?IWzBkUa8w4e3arZsTRcaZOMK2SBoddeSGTLSPyVGWP8iWFvPJf4A7d1b?=
 =?Windows-1252?Q?VgJckemcj6uXgU0kUHtVO2fx6TNCty03Esi+Ytt31HZA2sqsR4fYjRxg?=
 =?Windows-1252?Q?DNOTjqYWjg1u8CugKQCMYAeHkjeB/xQPqI0n3ntwIWFyFkj+1KAEHGHM?=
 =?Windows-1252?Q?0pHkg19dg3JFIiyQjZz0kCiz4Pjd01JWlxHvg2XVjhf72HbjVY6u3Tob?=
 =?Windows-1252?Q?k+Jb74Kbf+mXmwCBswu2V1XGTeeKZKuIMizf/I7qPu4JJ06Hx5Ll4oYW?=
 =?Windows-1252?Q?bd9yrdrn5RAQZKPdN9PyN+CLeG/G93aeE/Y+wGRcTTFvrCBor7NkHrFD?=
 =?Windows-1252?Q?tF9SUXcbHyCZJa+jKBKNNA=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 180e15e8-2b57-4aee-738e-08d98ce71026
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 18:43:48.7498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0JST7Ef+blQtpqr9mI2HB8RcaiN8KWhLynKdXUJE/X0xNHS7fG8eV22njHbA2X3hAo5ULNUqlMJuV32o3giNew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2684
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/21 11:59 PM, Mark Brown wrote:
> On Mon, Oct 11, 2021 at 11:48:40AM +0530, Mukunda,Vijendar wrote:
>> On 10/11/21 11:19 PM, Mark Brown wrote:
> 
>>>> +		pdevinfo[3].name = "acp5x_nu8821_cs35l41_mach";
> 
>>> This appears to unconditionally assume that any machine with this
>>> hardware is going to have exactly the same CODEC/amp combination - that
>>> seems like it's going to go badly at some point.  Shouldn't there be
>>> some other check that we're instantiating the right machine driver?
> 
>> we will make the platform device as generic one something like "acp5x_mach".
> 
>> Currently we have only one target platform with above codec combinations
>> for this APU series.
> 
>> When we get new codecs combinations to support, we will address it in
>> machine driver by adding DMI checks for distinguishing codec combinations.
> 
> If that's the case then this machine driver that's being instantiated is
> poorly named, and I expect you're going to get issues with assuming a
> default here and trying to instantiate this machine on unsuitable
> hardware.  It'd be better to at least put a bit of the framework in now
> and positively indentify systems that can run this machine driver.

Will address it by adding DMI checks in machine driver code.
> 
> It really would be good if ACPI system vendors were to adopt a more
> standards based approach to platform enumeration, this really isn't
> good.  Something more standards based like DT has would be much more
> scalable.
>