Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211009104309.45117-1-david@ixit.cz> <1633894316.403809.3158663.nullmailer@robh.at.kernel.org>
 <W97S0R.8W2XT6A4XCW4@ixit.cz>
In-Reply-To: <W97S0R.8W2XT6A4XCW4@ixit.cz>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 11 Oct 2021 13:45:40 -0500
Message-ID: <CAL_JsqJeHYA4Bpb-4FRojV0TWr9z8tbpCshG=t_an7eMnSiQYQ@mail.gmail.com>
Subject: Re: [PATCH] WIP: dt-bindings: arm: hwmon: gpio-fan: Convert txt
 bindings to yaml
To:     David Heidelberg <david@ixit.cz>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>,
        ~okias/devicetree@lists.sr.ht, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux HWMON List <linux-hwmon@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Oct 10, 2021 at 4:50 PM David Heidelberg <david@ixit.cz> wrote:
>
>
>
>
> On Sun, Oct 10 2021 at 14:31:56 -0500, Rob Herring <robh@kernel.org>
> wrote:
> > On Sat, 09 Oct 2021 12:43:09 +0200, David Heidelberg wrote:
> >>  Convert fan devices connected to GPIOs to the YAML syntax.
> >>
> >>  Signed-off-by: David Heidelberg <david@ixit.cz>
> >>  ---
> >>   .../devicetree/bindings/hwmon/gpio-fan.txt    | 41 -----------
> >>   .../devicetree/bindings/hwmon/gpio-fan.yaml   | 69
> >> +++++++++++++++++++
> >>   2 files changed, 69 insertions(+), 41 deletions(-)
> >>   delete mode 100644
> >> Documentation/devicetree/bindings/hwmon/gpio-fan.txt
> >>   create mode 100644
> >> Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for
> > dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1538743
> >
> >
> > fan: 'gpio-fan,speed-map' is a required property
> >       arch/arm/boot/dts/kirkwood-nas2big.dt.yaml
> >       arch/arm/boot/dts/kirkwood-net2big.dt.yaml
> This sounds correct.
>
> >
> > gpio-fan: gpio-fan,speed-map: 'anyOf' conditional failed, one must be
> > fixed:
> >       arch/arm/boot/dts/gemini-dlink-dir-685.dt.yaml
> >       arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml
> >
> Look like two arrays instead one expected.
>
> > gpio_fan: gpio-fan,speed-map: 'anyOf' conditional failed, one must be
> > fixed:
> >       arch/arm/boot/dts/am57xx-beagle-x15.dt.yaml
> >       arch/arm/boot/dts/am57xx-beagle-x15-revb1.dt.yaml
> >       arch/arm/boot/dts/am57xx-beagle-x15-revc.dt.yaml
> Look like two arrays instead one expected.
>
> >
> > gpio-fan: gpio-fan,speed-map: 'oneOf' conditional failed, one must be
> > fixed:
> >       arch/arm/boot/dts/gemini-dlink-dir-685.dt.yaml
> >       arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml
> >
> Look like three arrays instead one expected.
>
> > gpio_fan: gpio-fan,speed-map: 'oneOf' conditional failed, one must be
> > fixed:
> >       arch/arm/boot/dts/am57xx-beagle-x15.dt.yaml
> >       arch/arm/boot/dts/am57xx-beagle-x15-revb1.dt.yaml
> >       arch/arm/boot/dts/am57xx-beagle-x15-revc.dt.yaml
> >
> Look like two arrays instead one expected.
>
> I can send patches to solve these warnings.

Certainly not required, but would be nice. I sent it more for whether
anything in the schema should change.

Rob