Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1857480pxb; Mon, 11 Oct 2021 14:52:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfwOhR2wXn062hTF6hGZTtjvaLqctF0xhPv04+xuN0JqHIKy53URlfPO8jhGucIMRwA+sq X-Received: by 2002:a50:cf0d:: with SMTP id c13mr44344551edk.269.1633989165805; Mon, 11 Oct 2021 14:52:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633989165; cv=none; d=google.com; s=arc-20160816; b=YT9RSeJ/cnoDE88QorCEyI1rkI9vGzgbbc+UxldpEDAAr5/z1TGS0vPalX//aK1TVy 3uzPdbWvSNQMGJ4/52vUxIiLic6mWCqt/qmFweHA/2oPTrNGlTQtUBZzuIDWxiP7YPCL QLnVhxN+P1jgSTECJVersp5ccSvnIMTk+EztO7bY9THq79pSkrHpsjWPbEpEk/jZUKcG 1YMzA2fNzkAJiag3k04hZOP7S14+J61cgXcmH11/15CXb625jZzqOnZq8qZaUccBawGl 1K6grSHceS8Ci6F+RC+88ZRi0L/96WXLDhEPsp/bKkHR/uooMnAu/7FB7MnMgrM0Fc8U wN2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DbnJkfP68nHZ3a2B4RSKKTibPUZ/ageATGkXYfFBQeA=; b=ZI+JjvA/xhCLVJfEfjNcqjWJ1QED9f2rFcc1I501Z39a5XWd41tNbUY/QX/xLSwR03 JfllgD/hkbJpQ8tygFf51Cr+HGVKnum4gNO8gXRJqikmQbmd29EInnOE7gUZXmUzHRyF 110OLLZgDBjIgyYDghzOIJwrKmxyNm4WJPkP7QXZmrQJhsT5jcsgcGxSa6I9m3sLr4G1 n3opKJzC+e7qGEhdHQ/9kdTe/D6tHR/V4MW3y6nE1+TFEiiCmcpFXH2hNgqFOdCWF2jD l4DQIF6+GwnI1glUzbVKTdSd3YxWoeiFFSWbnMC2UKCGos/uPDmQkUv8Gf1zR5ytYtba YQyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=wLrEp738; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q23si14596739eju.400.2021.10.11.14.52.22; Mon, 11 Oct 2021 14:52:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=wLrEp738; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235301AbhJKVwd (ORCPT + 99 others); Mon, 11 Oct 2021 17:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbhJKVwc (ORCPT ); Mon, 11 Oct 2021 17:52:32 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21637C061570 for ; Mon, 11 Oct 2021 14:50:32 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id t16so51131069eds.9 for ; Mon, 11 Oct 2021 14:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DbnJkfP68nHZ3a2B4RSKKTibPUZ/ageATGkXYfFBQeA=; b=wLrEp738E2QE/+wYqTY3hjxN9yRwjnhaIUGqGzkwx7F+3V1gNbPuwK8cuMGZkf6qlj Qx4o8N/faB6TKanGlV8f7QH16fFV2n0T3iAmvme93mc1BM+iINuyk+lvkN70GAEcoDC3 XscO2Rsp2ntS04xhHMBK8qKuenxdc30kre8sW6ZALbK8je+1QC1k4rHrX2XT4zqrUQi5 4/Znh46HtG0vckXvm3/mIpxle1pr06T6/l4o0NCbo3t9fSRr7ZE/bLeJsqvSXPHCBWPP bAk98y4L8ojIhG4q0ZiM2unngfKLO+qMl3qQ83XzOGYzfEqrNRdDqGMuB1UBgXLjdRDx hW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DbnJkfP68nHZ3a2B4RSKKTibPUZ/ageATGkXYfFBQeA=; b=utomrbzF1BPepywWOubqQAFHr27OVjLwps2PFR8DwubYlp2bOnLTduqV3pp7o2G+z3 Kz/a6E6L788VbwspyfROoDOxmVUMYmLBNmnwDq6OZL1EynTdVnO5rz1JxWZTty/kCKxF VeDBJHwj13jWpW4RtKu2inZEv3BWVBK6UxnLvlbYF4EPOGRF7ihIppXSIplfOoRQzB+S F6eHSeGa38wsNd4UKxfHmeyzZRBa3SB9o7ujKu5B+37pI046QqMFmB+mnuaP+ddvyFXa 5A8YMclGmrlH16jOoZlugA11snTgMex6q0CnCp0s55hQaaYupx3ghNnzI0e34WI5tZ6U wQXg== X-Gm-Message-State: AOAM532THXcxsRkALV06Bst3X74IQkBY0/zInM2Pm7sM9XcLuJ6BPmTp WX+gwwdoI5NJw2Raag9BQ4hsEuFicKBF7R8tTJHB X-Received: by 2002:a17:906:2f16:: with SMTP id v22mr27622527eji.126.1633989030703; Mon, 11 Oct 2021 14:50:30 -0700 (PDT) MIME-Version: 1.0 References: <20211011202229.28289-1-fw@strlen.de> In-Reply-To: <20211011202229.28289-1-fw@strlen.de> From: Paul Moore Date: Mon, 11 Oct 2021 17:50:19 -0400 Message-ID: Subject: Re: [PATCH selinux v3] selinux: remove unneeded ipv6 hook wrappers To: Florian Westphal Cc: selinux@vger.kernel.org, Stephen Smalley , Eric Paris , linux-kernel@vger.kernel.org, Ondrej Mosnacek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 11, 2021 at 4:22 PM Florian Westphal wrote: > > Netfilter places the protocol number the hook function is getting called > from in state->pf, so we can use that instead of an extra wrapper. > > While at it, remove one-line wrappers too and make > selinux_ip_{out,forward,postroute} useable as hook function. > > Signed-off-by: Florian Westphal > --- > v3: also remove the one-line wrappers, just adjust function signature > of the actual functions (Ondrej Mosnacek) > > security/selinux/hooks.c | 80 +++++++++------------------------------- > 1 file changed, 18 insertions(+), 62 deletions(-) Merged into selinux/next, thanks Florian! -- paul moore www.paul-moore.com