Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423107AbWLVPGD (ORCPT ); Fri, 22 Dec 2006 10:06:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423156AbWLVPGC (ORCPT ); Fri, 22 Dec 2006 10:06:02 -0500 Received: from relais.videotron.ca ([24.201.245.36]:41588 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423107AbWLVPGA (ORCPT ); Fri, 22 Dec 2006 10:06:00 -0500 Date: Fri, 22 Dec 2006 10:05:59 -0500 (EST) From: Nicolas Pitre Subject: Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers In-reply-to: <74d0deb30612212316i12090ca0hfe8524a80f63475a@mail.gmail.com> X-X-Sender: nico@xanadu.home To: pHilipp Zabel Cc: Andrew Morton , David Brownell , Linux Kernel list , Andrew Victor , Bill Gatliff , Haavard Skinnemoen , jamey.hicks@hp.com, Kevin Hilman , Russell King , Tony Lindgren Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Content-transfer-encoding: 7BIT References: <200611111541.34699.david-b@pacbell.net> <200612201304.03912.david-b@pacbell.net> <200612201313.22572.david-b@pacbell.net> <20061220221328.ee3bfc5d.akpm@osdl.org> <74d0deb30612212316i12090ca0hfe8524a80f63475a@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 31 On Fri, 22 Dec 2006, pHilipp Zabel wrote: > On 12/21/06, Andrew Morton wrote: > > On Wed, 20 Dec 2006 13:13:21 -0800 > > David Brownell wrote: > > > > > +#define gpio_get_value(gpio) \ > > > + (GPLR & GPIO_GPIO(gpio)) > > > + > > > +#define gpio_set_value(gpio,value) \ > > > + ((value) ? (GPSR = GPIO_GPIO(gpio)) : (GPCR(gpio) = > > > GPIO_GPIO(gpio))) > > > > likewise. > > I have done the same to the SA1100 wrappers as to the PXA wrappers now. > Maybe the non-inline functions in generic.c are overkill for those much > simpler > macros on SA... I think the SA1x00 has no advantage of having out of line versions. The function call will cost more than the inline version even if gpio is not constant. Nicolas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/