Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 24a/DSCUGD5XnCRdR0pimfBvXfIkMeFYbWPoDzFxZqo0h/x9nJ92Vwzq3Ft3KWIa7PjVCOP1Kj
 TzKzu3fFPncNTg+n2Gg63cWIKysqlHgB7Lejyjk7ch8mFUptAbrybYnFBbLKT2kWPbsl68CPDI
 cpsC3KqseIlmpokTMJzBYI9a4Rd4uxGb/bdrBqPmQiCLI25l76umKaphi54edw43bkH4ha/puD
 62+aPNiatQL487+R6vc8VWwOEl2dehDPZCwACiqF9GR/iO9qpSU8aCcmFdmEy+RsgTuwmRcoCx
 FQ6v8VP0aOYxn7pjnMdyylCE
IronPort-SDR: DekfnG3dP8Jy36M6eUhwT7cR1qRubdV6yjEPwXaNhh+SHDWMKqI0uwkOFO0xSZGAxMxEVbfRS1
 LPSDrCoZ+UYgqubJ97kPA0Q+iud70N/7KQ9Ot5VvyWadn5fLdSfK7E8ghLO056RF129UdXtSDb
 sOzxh8TRqSGv3NF2NSW52DGkNNLIictDbmV6vkQ+bOvqN0p6Ca4knamDcJypk1oXxWodX8Y2di
 bsG/whJ/zUqkle7I0V/rIHAWSz60AVf6aOq6HDYAa8vTHkwQu6U6CZCMMe2EiYekVoLR/AxXsb
 UGA=
WDCIronportException: Internal
Message-ID: <974dfba6-915e-c3d6-53f6-473be18faf80@opensource.wdc.com>
Date:   Tue, 12 Oct 2021 10:06:02 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH v2] ata: atp867x: Cleanup pointer value print
Content-Language: en-US
To:     Guo Zhi <qtxuning1999@sjtu.edu.cn>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sergey Shtylyov <s.shtylyov@omp.ru>
References: <20210930030533.1216577-1-qtxuning1999@sjtu.edu.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20210930030533.1216577-1-qtxuning1999@sjtu.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/30/21 12:05, Guo Zhi wrote:
> Pointers should be printed with %p or %px rather than cast to
> 'unsigned long' and printed with %lx
> Change %lx to %p to print the secured pointer.
> 
> Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
> ---
>  drivers/ata/pata_atp867x.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ata/pata_atp867x.c b/drivers/ata/pata_atp867x.c
> index 2bc5fc81efe3..c32b95f48e50 100644
> --- a/drivers/ata/pata_atp867x.c
> +++ b/drivers/ata/pata_atp867x.c
> @@ -447,11 +447,11 @@ static int atp867x_ata_pci_sff_init_host(struct ata_host *host)
>  #ifdef	ATP867X_DEBUG
>  		atp867x_check_ports(ap, i);
>  #endif
> -		ata_port_desc(ap, "cmd 0x%lx ctl 0x%lx",
> -			(unsigned long)ioaddr->cmd_addr,
> -			(unsigned long)ioaddr->ctl_addr);
> -		ata_port_desc(ap, "bmdma 0x%lx",
> -			(unsigned long)ioaddr->bmdma_addr);
> +		ata_port_desc(ap, "cmd 0x%p ctl 0x%p",
> +			ioaddr->cmd_addr,
> +			ioaddr->ctl_addr);
> +		ata_port_desc(ap, "bmdma 0x%p",
> +			ioaddr->bmdma_addr);
>  
>  		mask |= 1 << i;
>  	}
> 

I lost track of this one. Any v3 to be expected to address Sergey comment ?

-- 
Damien Le Moal
Western Digital Research