Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Oct 2021 02:50:39 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Rongwei Wang <rongwei.wang@linux.alibaba.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
        song@kernel.org, william.kucharski@oracle.com, hughd@google.com,
        shy828301@gmail.com, linmiaohe@huawei.com, peterx@redhat.com
Subject: Re: [PATCH 0/3] mm, thp: introduce a new sysfs interface to
 facilitate file THP for .text
Message-ID: <YWTp7yjaN8W//Zrf@casper.infradead.org>
References: <20211009092658.59665-1-rongwei.wang@linux.alibaba.com>
 <YWPwjTEfeFFrJttQ@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWPwjTEfeFFrJttQ@infradead.org>
Precedence: bulk

On Mon, Oct 11, 2021 at 09:06:37AM +0100, Christoph Hellwig wrote:
> Can we please just get proper pagecache THP (through folios) merged
> instead of piling hacks over hacks here?  The whole readonly THP already
> was more than painful enough due to all the hacks involved.

This was my initial reaction too.

But read the patches.  They're nothing to do with the implementation of
THP / folios in the page cache.  They're all to make sure that mappings
are PMD aligned.

I think there's a lot to criticise in the patches (eg, a system-wide
setting is probably a bad idea.  and a lot of this stuff seems to
be fixing userspace bugs in the kernel).  But let's criticise what's
actually in the patches, because these are problems that exist regardless
of RO_THP vs folios.