Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2118754pxb; Mon, 11 Oct 2021 22:41:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWGCg8/Db3Nq9trPlhLArbVpp8xRGtfDVYs1z10XUebBDeq0+GirGJQQDCImsSe4sU4EzR X-Received: by 2002:a05:6402:2807:: with SMTP id h7mr44499897ede.58.1634017304084; Mon, 11 Oct 2021 22:41:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634017304; cv=none; d=google.com; s=arc-20160816; b=p1bqTQEwuhpO6NFHaqMEUNi+ebS5eiR6jsZ6JXzKzBjEON5Js0i0vttnwQ5nUbH/bc f6fjdj4W+HWWVJ6XRegZQgDinNpdblWDzJDieeWClmif6DPwcswarsis5S4YXGPboSxW Ek2bIpImDTNe5qGOsSmbqsXGfRFRofcZlKwOeapHUplvPn8Gwt+wZIaUyV+T+lDx8rmT QYU2ziKfoIL3J6b0Mt/FrvQZzpIdjVmBwqR0oJzDNSqhjxEzdXKhMLia0BJkawPZEz7m ujotWh2EGOMCQB93+5y3rIeyoO6RZ00EZ6wvad3FadtEp8cKXPgXFzawhfAvPUcGZZZd 55gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:user-agent:date:message-id:subject:to:from; bh=mSKIr+YtIsbZ21TLhUybXvXB1iYpg98qBjCIIGPI8Ks=; b=AG8kkKCSwl6VCQKKDwnkV1cR/uZ3tI5u/SkVmQHBXIcsZNp5s7L/M/7ZnEIospSWyC u05oRpKGd1Aly1u0v5a7w8ZDev9OSmbzUe9YKI0A4QZoBVSk54ANnznzyQGyI+zsYgvj l50Dz/XTR6XeLxo9AvIoDA9+e4SAWPT18V0JoHRJexRTIgofnInuwoPTmifV4HO133fn W4iJP+foEKOHt98e0QsS5+Ev139+GmckXBYzMtulAhfg/5UaOoIU1xUWnPq3+FnXu9gu DwIteqnwO20jRQk0y/BJBp4U1Magql9IJ5ZPMBI7bcrhtX2AQSO55L7fNx4VlPDFmVuI iNoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c25si13622122edn.606.2021.10.11.22.41.16; Mon, 11 Oct 2021 22:41:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232434AbhJLFlZ (ORCPT + 99 others); Tue, 12 Oct 2021 01:41:25 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:33227 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhJLFlY (ORCPT ); Tue, 12 Oct 2021 01:41:24 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R861e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=yun.wang@linux.alibaba.com;NM=1;PH=DS;RN=31;SR=0;TI=SMTPD_---0UrXmxxi_1634017156; Received: from testdeMacBook-Pro.local(mailfrom:yun.wang@linux.alibaba.com fp:SMTPD_---0UrXmxxi_1634017156) by smtp.aliyun-inc.com(127.0.0.1); Tue, 12 Oct 2021 13:39:18 +0800 From: =?UTF-8?B?546L6LSH?= To: Guo Ren , Steven Rostedt , Ingo Molnar , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Colin Ian King , Masami Hiramatsu , "Peter Zijlstra (Intel)" , Nicholas Piggin , Jisheng Zhang , linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, live-patching@vger.kernel.org Subject: [PATCH 0/2] ftrace: make sure preemption disabled on recursion testing Message-ID: <8c7de46d-9869-aa5e-2bb9-5dbc2eda395e@linux.alibaba.com> Date: Tue, 12 Oct 2021 13:39:16 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The testing show that perf_ftrace_function_call() are using smp_processor_id() with preemption enabled, all the checking on CPU could be wrong after preemption, PATCH 1/2 will fix that. Besides, as Peter point out, the testing of recursion within the section between ftrace_test_recursion_trylock()/_unlock() pair also need the preemption disabled as the documentation explained, PATCH 2/2 will make sure on that. Michael Wang (2): ftrace: disable preemption on the testing of recursion ftrace: prevent preemption in perf_ftrace_function_call() arch/csky/kernel/probes/ftrace.c | 2 -- arch/parisc/kernel/ftrace.c | 2 -- arch/powerpc/kernel/kprobes-ftrace.c | 2 -- arch/riscv/kernel/probes/ftrace.c | 2 -- arch/x86/kernel/kprobes/ftrace.c | 2 -- include/linux/trace_recursion.h | 10 +++++++++- kernel/livepatch/patch.c | 6 ------ kernel/trace/trace_event_perf.c | 17 +++++++++++++---- kernel/trace/trace_functions.c | 5 ----- 9 files changed, 22 insertions(+), 26 deletions(-) -- 1.8.3.1