Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] habanalabs: select CRC32
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Oded Gabbay <ogabbay@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20211011151443.12040-1-vegard.nossum@oracle.com>
 <CAK8P3a2+dU53PMJZvkDDGUyv=EiHuc03njGf6SXTxw9A4ByeHw@mail.gmail.com>
 <47e60186-2408-19cf-3231-92bd9c30483a@oracle.com>
 <CAK8P3a2nai8xGQPPMH89rO83252trdRFM67s-mmivAXeDE0zfA@mail.gmail.com>
From:   Vegard Nossum <vegard.nossum@oracle.com>
Message-ID: <8b209292-5b94-5a14-dee0-2c152ac02a5d@oracle.com>
Date:   Tue, 12 Oct 2021 07:54:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CAK8P3a2nai8xGQPPMH89rO83252trdRFM67s-mmivAXeDE0zfA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d01wNmtrQVhjM3pob0c3djAvdEhSeWlaWUJZaW0zSjJpTkdoUXlSdHE5RzdZ?=
 =?utf-8?B?aHdjYzI3VlhaZ2FIbDE4V2liWVd3WjM5V1RFSTBZQVZXY1ZvL0JiZ2VBaWpB?=
 =?utf-8?B?czZIYzhlVjVyanlQS2hBZURGZlhSVGlabmx6dzRIUDlvYjFwcG9Ed2pWL3U5?=
 =?utf-8?B?dy9zMFkxN3QvVWtnc25ia09ZcTIzdklHT2J1Wkw2WDhJcTVIWk5mR3haN3BD?=
 =?utf-8?B?Z3p2bXExQ2tZSXhFa25CM2NpVGtYN08xNDB1VTVFT2p0T2lHYm5ERFg0dXNr?=
 =?utf-8?B?b294Rm1CT2tkZVgzaDBJVDBleS96ZjdYcVI5VGlmY1VBejdLc293NEgrZmQ5?=
 =?utf-8?B?b2FJc25TYUw1bXhaZTQ4SlhWSnpVYTVhTTNUZ090YTNzVEFvRlhYN3dvVitS?=
 =?utf-8?B?eHFScU1QVFRyc29JQVM3RmlrUlhtNHhYME9TekxCSnJIZ0JDS3JmZTdSUkFh?=
 =?utf-8?B?V1M1bVZZbDBOTzZiY09kaCs3dXNJUmF5R2QyVC9yaUxFRTRFY0NkVWNMRWF4?=
 =?utf-8?B?NHRtN09xT2lKNVVHTmgxUGxjTFdSOFFWaDlxN2U3MU0rZU9wSy92YnN6d2RB?=
 =?utf-8?B?QVM3MVErYW9EL0RVZk9QQVl0T2MvRWRYT3l5aDcxMUc3VDBEZ2RXNCtZY1h4?=
 =?utf-8?B?K2dDZTVGQStPZ2hROGVCSmhzTWt1aFJKNDVwODhNdk0xbm9wdElTUXJIVGhl?=
 =?utf-8?B?YkhRYUF3QVplVkg5NFd2TDh6MGZCbFFVUUFNZ2hZWDFCQmN3WVQ3WVlMSkZu?=
 =?utf-8?B?NUlhTmVVa1J4OGNvcEoyN1VMUFZheWdldktqQXNKYmFFT2FaZVRSbm5ianl4?=
 =?utf-8?B?M3RhTHFxZTRZVVVHbXFyQm02Wm9iZ0lZU2ZnM1g0WDRYSFpWampOcjY2Ykxz?=
 =?utf-8?B?Z1JRVEZpSmd4dFhySEV6eFc3c1dsK3VlYVFnU2hsK2lneGUxT1c2S0VFUWpk?=
 =?utf-8?B?UTBQSnBOL2FTTFNVdHEza2ZGVHBKci9OTlhXbmIvUU5wRS9jTHV4bDVkTTBU?=
 =?utf-8?B?SzVSU2NFOUZ4V245OXl1Rmo3Qmo0Szg2NFN0c0hSQ2RLMndRaE1sMmRvU0s4?=
 =?utf-8?B?L25VS1FEdnJHUzEwVDUwVTR2Q3hGUElCOXVSNVIvMk5NRElpY1dUZk9vOFlK?=
 =?utf-8?B?YWRJY3hQemRmN01vVkhpb1d0aVYxNi9yTFluQjkrai9qcUp4Z2l5Ukp2Nk5S?=
 =?utf-8?B?M01velJpRzhnSlNaWk43VHlQbncrVDVDa09vVGJiZGJ3UE12ci80czE4aExM?=
 =?utf-8?B?UzRSN0NPUkUxeVZZY3dqcEhXTkRxZi90a0RLNjNkSU1mbWtCa0VmTTdsNlg1?=
 =?utf-8?B?ZlVDYkp0TWl5anR6cEtqbXV1ZXFGMTBEdTFuVEZRdnU5QUVYTlQ5ZmFsNS9x?=
 =?utf-8?B?Z1ZpSDhKbXh3aDdQdHpRSFpXWUZLL1E4QkZmMlJLOGJpa09WS0lRdzErUFk4?=
 =?utf-8?B?aUM1TTBFek5jVHQ0bmxvVno1blZURllxRXdLaWNONHBQMTU2RWMzU3ZYUU0r?=
 =?utf-8?B?NStoQm9OMWxOZmd5dWlEck1lYklMYmUzcWllVTFMOTI0YUJUQ3loMmkvejdq?=
 =?utf-8?B?d3dVUmg1TVIwUnFiNEk5Tnk1NEk2MzJzcjRkd2pzeTRRWFkwSWpIZU8rNXAw?=
 =?utf-8?B?Sk5VenFoMGE0WWpobms2YWZYUDVnN2JBQ09DRTg1ZkRzN1QxM1FObDhmSkw2?=
 =?utf-8?B?N0FTQW85T0ZKQ0NPd0V2eTRQVEkxUjZrM3U1THVTemxjaGQ1L2lLN05QS1NH?=
 =?utf-8?Q?e+mzQhU+gN/yjjTstubtHsw6Ju8N+AKPjMFcPcB?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 245b4e87-8c26-402d-c476-08d98d44bc90
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 05:54:21.3280
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gGqjptZ0M1u8tU5Y+d1gCDA3+ivpbew/dvmmHO78/QaUbjwmHM882JV38A0rZMbRcov9G7aUnAhf5i5iIS71Pb8Cw/vxX0iiWJ0ilwJpALA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4632
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110120032
X-Proofpoint-GUID: eo0RC4BNN5YtqbAsqJMPZcn_Ddky18eZ
X-Proofpoint-ORIG-GUID: eo0RC4BNN5YtqbAsqJMPZcn_Ddky18eZ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/11/21 9:37 PM, Arnd Bergmann wrote:
> On Mon, Oct 11, 2021 at 6:29 PM Vegard Nossum <vegard.nossum@oracle.com> wrote:
>> I also suspect that satrandconfig samples the configuration space MUCH
>> more uniformly than randconfig, in the sense that "make randconfig" will
>> tend to have CRC32 enabled just because there are so many drivers that
>> _do_ select it. (Think of it this way, every prompt for an option that
>> has "select CRC32" in it will be another 50% probability of actually
>> enabling the option.)
> 
> Yes, of course. I've seen other problems like this often happen with
> 
> CONFIG_I2C=m
> CONFIG_LEDS_CLASS=m
> CONFIG_IPV6=m
> CONFIG_CRYPTO=m
> CONFIG_PM_SLEEP=n
> 
> Not sure if you're already hitting those or if you need to add something
> to your setup to make those more easy to find.

The CRYPTO one I've definitely hit a few times (usually combined with
CRYPTO_HASH) and a failure to link crypto_ahash_* functions.

Otherwise it's mostly CRC32 and a couple of odd ones like this that I've
seen so far:

ERROR: modpost: "dell_privacy_has_mic_mute"
[drivers/platform/x86/dell/dell-laptop.ko] undefined!

  CC      drivers/scsi/aic7xxx/aic79xx_reg_print.o
gcc: error: drivers/scsi/aic7xxx/aic79xx_reg_print.c: No such file or
directory
gcc: fatal error: no input files
compilation terminated.
make[3]: *** [scripts/Makefile.build:271:
drivers/scsi/aic7xxx/aic79xx_reg_print.o] Error 1

I'll give your suggestions a try, I have about 9 patches queued up so
far so I think there are definitely more problems lurking around.

Thanks,


Vegard