Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <48159eb1-61f7-09df-9bea-5933a283f972@linux.alibaba.com>
Date:   Tue, 12 Oct 2021 15:04:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:93.0)
 Gecko/20100101 Thunderbird/93.0
Subject: Re: [PATCH 0/3] mm, thp: introduce a new sysfs interface to
 facilitate file THP for .text
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>,
        Christoph Hellwig <hch@infradead.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
        viro@zeniv.linux.org.uk, song@kernel.org,
        william.kucharski@oracle.com, hughd@google.com,
        shy828301@gmail.com, linmiaohe@huawei.com, peterx@redhat.com
References: <20211009092658.59665-1-rongwei.wang@linux.alibaba.com>
 <YWPwjTEfeFFrJttQ@infradead.org> <YWTp7yjaN8W//Zrf@casper.infradead.org>
From:   Rongwei Wang <rongwei.wang@linux.alibaba.com>
In-Reply-To: <YWTp7yjaN8W//Zrf@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/12/21 9:50 AM, Matthew Wilcox wrote:
> On Mon, Oct 11, 2021 at 09:06:37AM +0100, Christoph Hellwig wrote:
>> Can we please just get proper pagecache THP (through folios) merged
>> instead of piling hacks over hacks here?  The whole readonly THP already
>> was more than painful enough due to all the hacks involved.
> 
> This was my initial reaction too.
> 
> But read the patches.  They're nothing to do with the implementation of
> THP / folios in the page cache.  They're all to make sure that mappings
> are PMD aligned.
Hi, Matthew

In fact, we had thought about realizing this by handling page cache 
directly. And then, we found that we just need to align the mapping 
address and make khugepaged can scan these 'mm_struct' base on 
READ_ONLY_THP_FOR_FS.

> 
> I think there's a lot to criticise in the patches (eg, a system-wide
> setting is probably a bad idea.  and a lot of this stuff seems to
At the beginning, we don't introduce the new sysfs interface, just 
re-use 'transparent_hugepage/enabled'. But In some production system, they
disable the THP directly, especially those applications that are 
sensitive to THP. So, Considering these scenarios, we had to design a 
new sysfs interface ('transparent_hugepage/hugetext_enabled').

And if you have other idea, we are willing to take to improve these patches.

Thanks!

> be fixing userspace bugs in the kernel).  But let's criticise what's
> actually in the patches, because these are problems that exist regardless
> of RO_THP vs folios.
>