Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbWLVRnc (ORCPT ); Fri, 22 Dec 2006 12:43:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751623AbWLVRnc (ORCPT ); Fri, 22 Dec 2006 12:43:32 -0500 Received: from nic.NetDirect.CA ([216.16.235.2]:51591 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbWLVRnb (ORCPT ); Fri, 22 Dec 2006 12:43:31 -0500 X-Originating-Ip: 24.163.66.209 Date: Fri, 22 Dec 2006 12:36:41 -0500 (EST) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Randy Dunlap cc: Linux kernel mailing list Subject: Re: [PATCH] Rename FIELD_SIZEOF to MEMBER_SIZE and use in source tree. In-Reply-To: <20061222092752.76af799b.rdunlap@xenotime.net> Message-ID: References: <20061222092752.76af799b.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-12.808, required 5, ALL_TRUSTED -1.80, BAYES_00 -15.00, RCVD_IN_NJABL_DUL 1.95, RCVD_IN_SORBS_DUL 2.05) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 26 On Fri, 22 Dec 2006, Randy Dunlap wrote: > On Fri, 22 Dec 2006 10:34:09 -0500 (EST) Robert P. J. Day wrote: > > > > > Rename the macro FIELD_SIZEOF() in include/linux/kernel.h to > > MEMBER_SIZE(), and make a number of replacements in the source tree > > where that macro simplified the code. > > Hi, > > Your CodingStyle ch. 17 additions also need to be updated > if/when they are merged (since they refer to FIELD_SIZEOF()). > Did Andrew add that to -mm? I don't recall. yes, that went in already. re-reading christopher's recent posting, he seems fairly convinced that that macro should be called either SIZEOF_FIELD or FIELD_SIZE. i'm happy with either choice, so someone else can make the decision and i'll go with it. rday - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/