Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Bhaskara Budiredla <bbudiredla@marvell.com>
To:     Bharat Bhushan <bbhushan2@marvell.com>,
        "will@kernel.org" <will@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 2/4] perf/marvell: CN10k DDR performance monitor
 support
Thread-Topic: [PATCH v4 2/4] perf/marvell: CN10k DDR performance monitor
 support
Thread-Index: AQHXrd2Tdoh8fcjm302tQkFioaOIjKvPIvVwgAAQglA=
Date:   Tue, 12 Oct 2021 09:16:13 +0000
Message-ID: <CY4PR1801MB2070C952470F81D26C1BB43ADEB69@CY4PR1801MB2070.namprd18.prod.outlook.com>
References: <20210920050823.10853-1-bbhushan2@marvell.com>
 <20210920050823.10853-3-bbhushan2@marvell.com>
 <CO6PR18MB4465FC607A2836EE98807965E3B69@CO6PR18MB4465.namprd18.prod.outlook.com>
In-Reply-To: <CO6PR18MB4465FC607A2836EE98807965E3B69@CO6PR18MB4465.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rJl9SNPEWmkk1Fs6hBNZ2baV02KCw6gyF94JPSHYxA35x+2deZjf01np2VNV?=
 =?us-ascii?Q?ssnsVi1+aTS0EMQGAOYV/A8J3dil7yWnvnqubywe5xWeFxEuHCJcomo1FCl6?=
 =?us-ascii?Q?X11oC7Q981v3fdMoeL/uWgtrk+htDJeW5NlM2R7uJu3MEmw7e/e71yxISFVh?=
 =?us-ascii?Q?EIGTEd4HKWiOw1o5Rp2SAbgM9zYSKUYRMDb3hn9cebies3HjYKr2rPNvA0zB?=
 =?us-ascii?Q?phbKZZpMEax/fpN5Ze60woOngNbDOQP1qQzH9EqETXtTCtSIo/IzWnApwsCZ?=
 =?us-ascii?Q?rUjL+J916hAgO/amU90/t+79tFc2m70sa1JEwLTLOPpX5RvgDA/c9xAFRwad?=
 =?us-ascii?Q?TY3iqf493BlILPj6IYvwJnMZQ/54mhD/yctHurPhK1pE3c//E8ewBmHG0wIG?=
 =?us-ascii?Q?EZ41qsBjrMN/teDlfG2D7M5PAkdjgEWmgEyoMcpDVnxnnIC+aCKDgdbv/JV1?=
 =?us-ascii?Q?u4PfpB3v89Z9VlsG5mNZz5bAg+evIh64DJue4zFEtEvp+KN7MohSOTOWQV3d?=
 =?us-ascii?Q?lODtuOLKNUkuDpNelX4NTdqZyTAmLD9ivnM7r0RIeAyPr0J9dWrmEXUjV3AP?=
 =?us-ascii?Q?vIvRDZ2o0hJl+UqMqJ+U/PdXv9gxU54jL5JB6HtnOgH0cBLGD9UV5/9TzKly?=
 =?us-ascii?Q?nP6KKQaXmIvfmsDEi+q8MjkOZCoEppNKzMHJzUaQbDR00jNyMOS83/+JLnq9?=
 =?us-ascii?Q?oTFBYYjK6UAbL0Kftjw0avpnIWyoxPNKQge5RIJaBYXIVdcFZvQLaN6O1In5?=
 =?us-ascii?Q?axp73ZCtBwOjVelj8n+Jj2tIkh94bFqQ657COtawyLE3I54Aigj58Em9+NdE?=
 =?us-ascii?Q?ZnoY8IxWA3o3ljkYOsGgUBIoxDQ9TXawa89Tp3FcM1JvIbBTjMordPFiZzqX?=
 =?us-ascii?Q?nija+5BzHGEGVQcrvYNcOYAesAJ7Z/bg5QDjQJiAhqQXdQhcccswJa7U7bTP?=
 =?us-ascii?Q?6u0BngKosRgBVJ8bmo5078Q0PUGVpka2JSroUQbCfOb+NG54Pw6gwHlvfs/M?=
 =?us-ascii?Q?xioZKJdv3xYJJdTl9aSpnlB0K7c3PQNc9xXgN8D/5mlLWwTivrYnZOZ3zi/p?=
 =?us-ascii?Q?lcJFVHxAeqDT7CMDj7oH9xlgUj3bOrAxj0Amdz4IqX9oAspKjcVXM6Z0hlWH?=
 =?us-ascii?Q?eAdXRn3muocRPhLXYT2YzlVtKIa3xLO/+aUjkWcK3P6qcbYmEglGTgsbH0In?=
 =?us-ascii?Q?LDQJcEKWUmGvg724QATvxJvfynvx9x12Eex8jq4p5zRTBUzcJzyN3qMLmIlo?=
 =?us-ascii?Q?bKB48oZ8025H60/qrIp34RQy1mu4ypPHb6egBTHjiDt2scT0NMiCt9D0ig/1?=
 =?us-ascii?Q?WJp6pRj5leV8nAEkAPYBvSTB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB2070.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f621555-bfb4-4389-600c-08d98d60f062
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 09:16:13.8102
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6+pCpqprvChowyK1XwFil9qqKfqcH8G97jR6nD3VKWp8zVa3yeSy9sPIZRy8cJZTj5+WsBIED1kHWaI17ycOlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1304
X-Proofpoint-ORIG-GUID: vn0FyavbfbDPFmCD2BON2jkpeSlBupIF
X-Proofpoint-GUID: vn0FyavbfbDPFmCD2BON2jkpeSlBupIF
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-12_02,2021-10-11_01,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


[...]

>>
>> v2->v3:
>>  - Add COMPILE_TEST as a dependency

This is missing.

>>  - Switch to sysfs_emit()
>>  - Error propagation when invalif event requested
>>  - Switch to devm_platform_get_and_ioremap_resource()
>>  - Other review comments on v2.
>>
>> v1->v2:
>>   - writeq/readq changed to respective relaxed version
>>   - Using PMU_EVENT_ATTR_ID
>>
>>  drivers/perf/Kconfig                 |   7 +
>>  drivers/perf/Makefile                |   1 +
>>  drivers/perf/marvell_cn10k_ddr_pmu.c | 599
>> +++++++++++++++++++++++++++
>>  3 files changed, 607 insertions(+)
>>  create mode 100644 drivers/perf/marvell_cn10k_ddr_pmu.c
>>
>> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig index
>> 77522e5efe11..41a80a4b8d29 100644
>> --- a/drivers/perf/Kconfig
>> +++ b/drivers/perf/Kconfig
>> @@ -139,4 +139,11 @@ config ARM_DMC620_PMU
>>
>>  source "drivers/perf/hisilicon/Kconfig"
>>
>> +config MARVELL_CN10K_DDR_PMU
>> +	tristate "Enable MARVELL CN10K DRAM Subsystem(DSS) PMU
>Support"
>> +	depends on ARM64
>> +	help
>> +	  Enable perf support for Marvell DDR Performance monitoring
>> +	  event on CN10K platform.
>> +
>>  endmenu