Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Oct 2021 12:33:46 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Lucas Stach <l.stach@pengutronix.de>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Peng Fan <peng.fan@nxp.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: off by one in
 imx8m_blk_ctrl_xlate()
Message-ID: <20211012093346.GR2083@kadam>
References: <20211011123638.GB15188@kili>
 <c71c6680e0930fd84f10e4fa13bd59e1f30c2db6.camel@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c71c6680e0930fd84f10e4fa13bd59e1f30c2db6.camel@pengutronix.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fpvaRUR6Gac3O+8/TtUOljGElCeskr4f2+15J5vSok1KATgaiFy7x8YZEBxG?=
 =?us-ascii?Q?QXqXxn6fn82Hnj1eEJ74JVy1ZALp5pG0TmqDlQsKKHOGlljzFrKgWKMlsdXC?=
 =?us-ascii?Q?PUXCwGdbaJqdxhKTwdb55Xma1GMr+zdJ4AzJNJbRZigLtnvU4COPtCTmUUrw?=
 =?us-ascii?Q?U0y6z1f/D5imDVZCIYUZ7A/tKw9RPMwQeKi3zVjzOpBWyubHWcfAHaxYdAHR?=
 =?us-ascii?Q?dKFKMMMVZskGACeuyTh5sazKyKdBoRPn+fD6EdKLOj1WbLNePqOaAOuilEAc?=
 =?us-ascii?Q?yaN+t1Btyxk3irrzMEaDVROB/1sgIoHOOwNDUCLz2c5Jkf3A319BW4PLOEWh?=
 =?us-ascii?Q?sjiyM6hAHpFVNvfGomqxY+xbfGMVGw6J/FilUowIr1kAeAEl1qbrJobfRPqy?=
 =?us-ascii?Q?dJai6crJAWyke9HSBg2D1IQhmkRHSVIsveSRdyVlgIm8vNhOBbwyFg30t4+n?=
 =?us-ascii?Q?eJI0+4BnjQfSbgNCYRY1tPv7mE1u05/5jA/bWwGWEFkYWa0fXmz0u9Q001k2?=
 =?us-ascii?Q?3trnFZSu7RoFouyPo6GAFA1+BAdyQ1GK8h6nQcj0OgIbwQ1n9a6GuirVsfky?=
 =?us-ascii?Q?y9DBC+YU27GvpoCO19yfGjOoX1ysbtXzowxjoITiLJOVRfGbWb7mBzWilIgU?=
 =?us-ascii?Q?gPw1bLuZU9ub22DXWVRofKgpRZVN36nx8qHgnrVj9ZH4wUTr/pF8cfuzp7FM?=
 =?us-ascii?Q?o/tq8LKz0cSy+sWlEOmGkB9B/HWcTgDvUuRSMpGZZ2K7FrOxUdxs6RUBw0Gd?=
 =?us-ascii?Q?2KHrIuhPmKfgQvRN+5BP8rFpmwUF2MXwydwhwpUA7iB8I2jn6SrcDsxFp5u4?=
 =?us-ascii?Q?dzRpEzsS6ndximbefxm9/nxGXSu8aFONd4iORZ5NnX2lg98Z+9Jhgf5iZ+LC?=
 =?us-ascii?Q?qPpZai437TJiBPwWHoqbJIJb6DRbrjWxrLSdHUJ7NYYn/t1Fl5o2zdp+ggm2?=
 =?us-ascii?Q?6Qp3mHyRVMK1CA66YV9FFsoaB1/IoF64YNFwGqNX6oUHGALzg8r7qxHfIoA2?=
 =?us-ascii?Q?28mqWdRAKmKUoeGih9KbYKllZWF7Fes6rUCgvtP4gg7X6vumiA2XMDcH6jP8?=
 =?us-ascii?Q?42WqoS6y8fUug2SON1+lSBzflHOvmlHxR6mKhHE8Dpm8c+Pz7PUrwczYDPmW?=
 =?us-ascii?Q?+AMZuCGYlAj55GPUhle2hPteHbS3R1MB2J7oJcVth3QiQGd1eV7gigOtpBAI?=
 =?us-ascii?Q?KiSXhgfe+OaB/hp+u+YpFeWo8+nLUEfmOpgtetcSG9v/tEgnA/yxp7dXnHUP?=
 =?us-ascii?Q?jAmGef5W6w7iTQ0TUqZf8YgOLtImsMpQvpemQrTpdPD5RFON9wvFwUHv1uLw?=
 =?us-ascii?Q?o/fBBZO7W73MYlPbp1kAOqGI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f793f97d-7b69-4ae5-93be-08d98d636f70
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:34:06.6230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ASsVYhXr03DvmwczCPU0wJNblHAb/zGdsYQK2OJRNqxAaz8xGvbXQ8fZfEDwoAm2PlCvKlVtC40jazydNvI/k/VAiRDU/ev9+d4D6qgh6PY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1424
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=933
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110120053
X-Proofpoint-ORIG-GUID: s3eCgU67oX8AfVn4ytXdruhuct_pXUG6
X-Proofpoint-GUID: s3eCgU67oX8AfVn4ytXdruhuct_pXUG6
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 12, 2021 at 10:29:27AM +0200, Lucas Stach wrote:
> Hi Dan,
> 
> Am Montag, dem 11.10.2021 um 15:36 +0300 schrieb Dan Carpenter:
> > The > comparison should be >= to prevent reading one element beyond the
> > end of the array.  The onecell_data->domains[] array is allocated in
> > imx8m_blk_ctrl_probe() and it has "onecell_data->num_domains" elements.
> 
> Thanks for the patch! I guess this was found via smatch? I should
> really make it a habit to use smatch on my submissions...

Yeah, but not a from a published check.  I have a private check for
off by one errors that warns about any > vs >= comparisons that cannot
be proved as correct.

regards,
dan carpenter