Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2331179pxb; Tue, 12 Oct 2021 04:28:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0s3JFaJQLuuBfvt9xYkeENXn/VBwxIL8sjOsrdytvU88zGVIQPMOkiq9j9KjwCkHuqmun X-Received: by 2002:a17:906:1299:: with SMTP id k25mr32387428ejb.139.1634038137267; Tue, 12 Oct 2021 04:28:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634038137; cv=none; d=google.com; s=arc-20160816; b=YngQznsw2j1fsG82upczbCAVIODkcTKJF4zgqOBYeZ9nCvMJJoHn4B5LB43bV8fo+2 pC8r0JpfDDjgJ4Ssfo6CqxXDA0SvN7R5CWyHiNtQjghmkH9kTQOzhKvMzhH74y/y05fC SBHYuCdVaCd22X3iLTfdN8zUA+g5MYyjFtyOPV2Po6GaV5rmLvLHkdd5ANkrreC62nKu ieQunizkivUC5xsKrrvJ0T8X0/lbVOpBTo5U9J3cosN9fSc4fgdYsg4t/APatOEUGnKR DOPiaqGAOH0VQ9Ud2zze1Wjfu7v5cUPrRA/wanxGv2fONWmbn0Bf1HahT8b8cw6lgTjO qrwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qnqPDkW3PEuRHrH7fEFlwj1INa9JZghbCmyes7XDZtc=; b=QMoiv5bSkj0MKklFK5neZFZIW7Qj1qDMNphTIeFDymOCIcPYtT8Q8uqXvh1wc17bT/ GCYNfzcOCboTgLSMKXNsYMp5QXLeKK07a3rUHrxj11wLR8GNlmFt0go/xqLfouec/8HQ hlQ+UDYdQr3bf0+xj5bKZQ2XDldb/jer+9TVUZHcdX0oTqcSvxEBxlFiS/pehguCU2QH YR6Rl9OadXqGXg/++dvysGVenVNfnBkzW3xb/PBJKJaERjTDzO99RsnMaku2FH+O9Rhi vAG1I/CfyGOR7sFoIRMqYVr97a4uKCSzkS885+ZmjM16RfaEVjCWwvV8wPNCKDR1vzaZ uN2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zra4gQuG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gh16si13589795ejb.666.2021.10.12.04.28.31; Tue, 12 Oct 2021 04:28:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zra4gQuG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236190AbhJLL1M (ORCPT + 99 others); Tue, 12 Oct 2021 07:27:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:41928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236129AbhJLL1L (ORCPT ); Tue, 12 Oct 2021 07:27:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B978C60F11; Tue, 12 Oct 2021 11:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634037910; bh=qnqPDkW3PEuRHrH7fEFlwj1INa9JZghbCmyes7XDZtc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zra4gQuG/UTWpwnl9rH1pLCnKl+1SHvoyjxNBszC96etvTcWQIgWJRIhV/y/P9uaS ndGwytiCrrBgq4S05SPN8ZM7EXc7cjzrsevWXuH/pLatNUmbEtwE+uq2R/bDpD7RnL beDQ698aGTzyvSFnE4MpbDRxnlLhfgbAudAzd6Cfhb3UltUHd2DMwrpIygoGavKCIj s4ESe4MP1ZP1G95uWg5ozLHN9TwgPHT9aCcvubtqsUy2EfrjZdAPU/330vuVbiahqA o8o+NKSFip7d6PvNALTSrPifquECuuBuk3ycixg/KpkkpcqoOmkf1EmL+MJS/YZPOr bR7kVXA5Qy75Q== Date: Tue, 12 Oct 2021 12:25:07 +0100 From: Mark Brown To: Shengjiu Wang Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] ASoC: wm8960: Fix clock configuration on slave mode Message-ID: References: <1634036070-2671-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xmS7fg8H5aUGfp6g" Content-Disposition: inline In-Reply-To: <1634036070-2671-1-git-send-email-shengjiu.wang@nxp.com> X-Cookie: Swim at your own risk. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xmS7fg8H5aUGfp6g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 12, 2021 at 06:54:30PM +0800, Shengjiu Wang wrote: > There is a noise issue for 8kHz sample rate on slave mode. > Compared with master mode, the difference is the DACDIV > setting, after correcting the DACDIV, the noise is gone. Charles suggested some updates to the patch to improve the error reporting here which you don't seem to have addressed. --xmS7fg8H5aUGfp6g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFlcJIACgkQJNaLcl1U h9Bj7Af6AoUC0r7+IN4MGFP2D+GI8ETZVSb6+NtZHAxw+TaFmQLwIhjzcEcDRtjf hwLaEhsJNeks7PautGeGBzCpzO87FXDMcTh98x53l0nZDPX+OOYqPgicrRsPgPZ1 g1SdtDg4dlJCyj0Iymr0l8Famw7s2HlnLhufqrGigzdAT/ZDTL/tIc+G0YJR+p1q Bmn2P1TVWvtIBBwVoVczqD9foLpX79Bz9l9PjFCQ3CG9HcAeceXI2mxc/xBaP00B Eh7CU+QDvDe73E66/+9dTnZpoffnxK7bu5TwnXvLJ2RlDlwBAnF/f0G/1A82VVnB 2fuvTTKz2aFZG9lBtIvl0O3PhPI1MQ== =F7Y8 -----END PGP SIGNATURE----- --xmS7fg8H5aUGfp6g--