Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Sam Ravnborg <sam@ravnborg.org>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
References: <20211012115242.10325-1-vegard.nossum@oracle.com>
From:   Vegard Nossum <vegard.nossum@oracle.com>
Message-ID: <f12a25ab-cd9c-2831-323a-328b49352349@oracle.com>
Date:   Tue, 12 Oct 2021 14:04:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211012115242.10325-1-vegard.nossum@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTAvSGVlQmxrOGQyT0Uva1dCWG1Sa3h1eFNBT2oyaDByYTBGVnFyN1JqQ0ZK?=
 =?utf-8?B?UXI1cDVyYUtuRmUzWmdnUk1sdWd5akdwcVZJYUI3VjkrZjBSeTJPUDlnLzJN?=
 =?utf-8?B?VDM4akExbkZ3OHdJR2doSzZoMm5QbGhKRjdKR3JHYWU4ekhuUE5ydHVlTHZK?=
 =?utf-8?B?dFpSc0lqaGd0WTNMV0oxNkkreTVYUXRnSXVmaU5jYUxKMjNJdjF6VXlybFVD?=
 =?utf-8?B?TzgrNVJLV0VVemtlSndaZVJEd2MxcUFxNHMrT1pBZGVLZUc3azR0QzZrYjVi?=
 =?utf-8?B?cVF5ai8vNVpLVjdJeG5QOG8zRnpERFZlVm90RkIxZ0NiMUh5SzZyMCtpaE1i?=
 =?utf-8?B?SkhiemY4UjRIRVRPWWtPbmdYbjVrOE1rSytxN3IvWDd5a0xDKzBBZzh2eFA5?=
 =?utf-8?B?amlDQ2tuNGxFUENBeFNsSDhSTDIwZlRJMHVrc1RGbWxpakY5cE5pbkUxYlpp?=
 =?utf-8?B?Z3RmemJlR1JFSU9rTmtGNjB5azhWaTg4ZWR0YmZVckl4bW04eGM0enhrVGdJ?=
 =?utf-8?B?TTJCSTRaRUp5RE4vZ2E3dmRLb2JnTzFONkMzbXVDem13L1pjK21HK24vMzdO?=
 =?utf-8?B?cUNvOTRmWFRVL0JGQmh1NkZiUFU3c2xXNDR4azVzYUdOb3RFVFo3d29HSEFz?=
 =?utf-8?B?VmVreEJDdDNRZlRQUWFaa1I4OERpWXluZExqR3FtZDkrUjVzMGJjK2IrY1dr?=
 =?utf-8?B?WmVxTE5ZbUgrdWN2N3pENWppeXoyUUZmMlJRaXh1c2pOZTlNUSs0ZFFaeWw1?=
 =?utf-8?B?K0ZrcXNneGRCTldJamxmMXFrQUxheHJFRGx3QW5DS0I2V0Z4VzdhMDg2Qlh4?=
 =?utf-8?B?V1J4SU9oUEdhOG4vME5nK0I0dTRwVUExeFFob3FTbG4yOW1oaFpNZTdOeXVV?=
 =?utf-8?B?eVBDOHRRbW8rVFN1T1JDOXN2QStOYVFKK0lxVFNKQm9xb0ZZUVlTc01YbVdF?=
 =?utf-8?B?Q2FsYk5VNXBSMzREOHE2QjNwQW5yN3g1QWI5aStJNWY5VS9HTHY2STRjbXUx?=
 =?utf-8?B?NFZYUytXejhtbHNab08xNFdXbE1VOVp3NTBRVUJCeXFjVTRGQzZZWEk1L2I5?=
 =?utf-8?B?NDdoWGdVUThNUVcwcHJLQTNydyt4eE1XR3dTT1JncVZwZEYrekxDRWw4V01q?=
 =?utf-8?B?YWVaRmY4dEl3RjVQeXdSam9PNFlNZFQrWHFHakl3TGNtazFkRnJXcy85anlJ?=
 =?utf-8?B?djVBZXIvczE3U3FKc0swZWNoTDFrY0FONm9HVGlkdVNBNlBSdEJ4NkdXVCsv?=
 =?utf-8?B?MkRaQ0VOV0tTQmUxc1VHTk16Vk93S1BxT1I4eXNHcFU2ek8xd1QxZ000WExK?=
 =?utf-8?B?QmxnRjljMU9nOVQwNTZlbjBOdXM1N0pveVZWSnBFOWIvN1pkblNqeHM2bVdZ?=
 =?utf-8?B?RXFpczFKMUdjSnJJNVlYM0pXVUlOcXBoUVU1TDRTeVFGK2cxMm9UMUZuKzBv?=
 =?utf-8?B?eVJsaEtocjg3Yk5SakNIWXNJQWd4M0RLRXZwYmQ2aE4yN0I3U09BMTNHVlpJ?=
 =?utf-8?B?b2tReGhodHZPTDFmWVRWMWN3a3JJUFRJUFpxMmE1d01pMkx2a3lidFdVVElC?=
 =?utf-8?B?Qmk1QzROSkpsSjJZU0I0ZnQvRHphL3EyZkpOdXdGdUMzOXlsOW5QMzdxMUlC?=
 =?utf-8?B?QjRRRTZqaUhWTzB6ZFVzaXNReDVlNnFDcHVYSjBWQ245VFpjemZ0MVVSRnlE?=
 =?utf-8?B?UlNZL1hpR0xFbjI5bDREQURVWkFGeXVqQWhWQ09lSktIaXE4RER0T0x0b1dZ?=
 =?utf-8?Q?Qg2XfFh+qM834KTkBYXJ4KqpfKMlJoH0D/+WN+R?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd2666e-82aa-417a-989d-08d98d7869e5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:04:16.3953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HaU5TVoRyJ1u+Q1tVNio6po4lN71bllfzwc0dPFT4Bsyee3lQRoH2xNaMnIhON9RTxqBU9y/xo1aviTru9OEZKeaQxIhKR9xzWzjwNqi6XM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5829
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120070
X-Proofpoint-ORIG-GUID: uqzR8VMdQaMH8iwCwLZ0vxk_YxjwBy6s
X-Proofpoint-GUID: uqzR8VMdQaMH8iwCwLZ0vxk_YxjwBy6s
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thierry,

I tried sending the patch below to Stefan Mavrodiev <stefan@olimex.com>
(listed in MAINTAINERS for DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS)
but it bounced with "No such user at that domain".

Will you take the patch and/or update the MAINTAINERS entry?

Thanks,


Vegard

On 10/12/21 1:52 PM, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
> 
>   ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe':
>   panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le'
> 
> Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
>  drivers/gpu/drm/panel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index beb581b96ecdc..418638e6e3b0a 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO
>  	depends on OF
>  	depends on I2C
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	select CRC32
>  	help
>  	  The panel is used with different sizes LCDs, from 480x272 to
>  	  1280x800, and 24 bit per pixel.
>