Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: d07ygs5Vjduz6DOM6xDKgqbCuKmg/1GTwqx1wU3Lgl+Ybg81S1Z+7ir49SyqHVhQKSBpWm9ubq
 9mAwirrkE/1cPlHmP+/3W89dQvP0sWNewuyDExl3g/Lb2+UaMPttsbZrb6qXTzff9ewlXZLD3Z
 ebScA9AMtMKjU2ZQg5+5dK34xFS/zyz5mo/JuVRXovvJzBBV29gbWrWoERGO8p0m7pDLy/Cc7G
 FZMaGWA0E5zihjRtVRGWpH3fU3SvWhIb1nVrTRyZXiQE/9tAEsB4XdI48jkB3sW5GFWzolElmH
 NY05ZyIzP97C4HlOZVf6Yjxg
Date:   Tue, 12 Oct 2021 16:40:52 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Philipp Zabel <p.zabel@pengutronix.de>
CC:     <robh+dt@kernel.org>, <andrew@lunn.ch>,
        <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add lan966x support
Message-ID: <20211012144052.pmn4u3s2j27itwxe@soft-dev3-1.localhost>
References: <20211012114238.2060101-1-horatiu.vultur@microchip.com>
 <20211012114238.2060101-2-horatiu.vultur@microchip.com>
 <91ae922d66b4b8c521142c8030bdd1a9f6d2fad1.camel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <91ae922d66b4b8c521142c8030bdd1a9f6d2fad1.camel@pengutronix.de>
Precedence: bulk

The 10/12/2021 15:35, Philipp Zabel wrote:

Hi Philipp,
> 
> Hi Horatiu,
> 
> On Tue, 2021-10-12 at 13:42 +0200, Horatiu Vultur wrote:
> > This adds support for lan966x.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  .../devicetree/bindings/reset/microchip,rst.yaml   | 14 +++++++++++++-
> >  1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > index 370579aeeca1..622cf3d0455d 100644
> > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > @@ -20,7 +20,11 @@ properties:
> >      pattern: "^reset-controller@[0-9a-f]+$"
> >
> >    compatible:
> > -    const: microchip,sparx5-switch-reset
> > +    oneOf:
> > +      - items:
> > +          - const: microchip,sparx5-switch-reset
> > +      - items:
> > +          - const: microchip,lan966x-switch-reset
> >
> >    reg:
> >      items:
> > @@ -37,6 +41,14 @@ properties:
> >      $ref: "/schemas/types.yaml#/definitions/phandle"
> >      description: syscon used to access CPU reset
> >
> > +  cuphy-syscon:
> > +    $ref: "/schemas/types.yaml#/definitions/phandle"
> > +    description: syscon used to access CuPHY
> > +
> > +  gpios:
> 
> From the description I'd expect this to be called phy-reset-gpios.

Yes, I can rename this.

> 
> > +    description: used for release of reset of the external PHY
> > +    maxItems: 1
> > +
> 
> Shouldn't an external PHY be described as a separate DT node, with its
> own reset gpio?

I am not sure, this is more board specific than PHY specific. On lan966x
ung8290 board, the external PHYs are kept in reset until this GPIO is toggled.

> 
> regards
> Philipp

-- 
/Horatiu