Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2489899pxb; Tue, 12 Oct 2021 07:42:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw02D/TIIafP6qtZ3BH6cRqxRvI7qzS5utsnLXQXDKbJyXNVcyVdhQaXkCz0wws94RaDaXv X-Received: by 2002:a63:f513:: with SMTP id w19mr22951215pgh.231.1634049732940; Tue, 12 Oct 2021 07:42:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634049732; cv=none; d=google.com; s=arc-20160816; b=riCI8BufgVDEp/5v4ZOICxrtdGtEHrJ5p4nAuZrajkBZxdegImyO5Dn/GC6g8JRWBz 7JqSh7RWiRLxC1hwxS89jJQxykH+rz1nn+8RDUHlEb+Pc97QnffXuJZD4RqqMJEH+1vC JAkzu+4Q2GKoDNT2PeK1EHeqaRQd/AEd+ZcJLK/xI4VaYkJIeojS0WACzNLXz7WUECmg S87vjuKqhNCZV46P93IYjOYIAjtC3ZCwbGPdObwfH3ixzEPF7YvXl5Z7AuUxSRuwTMBD gg8D6wvYlHBBZbzK3BPaNcFhPTPz0nzBHFwn9JDI6o/9ZFGq5GdolCx1ZBnoh9Dlj5eo 7X3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Pu4H1jWkOP4Bi9/uQR0OF2sdxBqhHNGsRXU9oPGHAIw=; b=yvtMCtJ1RU7gD6P0PxvoDXaJf7x8o0klowDKr1FlTK0PX0bkrhNFGgQxOfa7/iDb9c xn4XIq/BnDi3wnjBTbytwcpDlUSNQEoZsiTuGEpqHZHLtX+bDl7C5CuVb74ziD8Ry8sH +mVQbTHhfxoMhthCRoeV+tmdDGLAyGc+PAB08uV4e1An/2ECDxCixHxUKMsKFyjuc6y1 ZRbDjXWiVFxASyJdVNlbwGGW0Vh40hVW9frIS4ZSYNBGefX3KOKO3Sqf8a+1ZoulVvFU tdCXuF4XhJuE4tpIMUjXYBOZc8DOI76POlhiYvMTqOJeHsqQ1Cg+WFGYrdnjD8XrncSz llnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si18125544pgk.256.2021.10.12.07.41.59; Tue, 12 Oct 2021 07:42:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237405AbhJLOmX (ORCPT + 99 others); Tue, 12 Oct 2021 10:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237260AbhJLOmW (ORCPT ); Tue, 12 Oct 2021 10:42:22 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA1DEC061570; Tue, 12 Oct 2021 07:40:20 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1maIwx-0007iq-Fb; Tue, 12 Oct 2021 16:40:15 +0200 Date: Tue, 12 Oct 2021 16:40:15 +0200 From: Florian Westphal To: Casey Schaufler Cc: Florian Westphal , linux-security-module@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH smack] smack: remove duplicated hook function Message-ID: <20211012144015.GD2942@breakpoint.cc> References: <20211011143309.17203-1-fw@strlen.de> <700b26f3-a8ef-969b-dd3c-4ad849d8c4ab@schaufler-ca.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <700b26f3-a8ef-969b-dd3c-4ad849d8c4ab@schaufler-ca.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Casey Schaufler wrote: > > Signed-off-by: Florian Westphal > > Looks fine, with the one change I've noted below. If you're > OK with that change I can take it for smack-next. Sure, smack_ip_output() is fine.