Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <0641aafd-650d-2f9e-1645-946c347677cc@nvidia.com>
Date:   Tue, 12 Oct 2021 18:21:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH net-next] net: bridge: make use of helper
 netif_is_bridge_master()
Content-Language: en-US
To:     Kyungrok Chung <acadx0@gmail.com>, Roopa Prabhu <roopa@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>
Cc:     bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
        coreteam@netfilter.org
References: <20211012141810.30661-1-acadx0@gmail.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
In-Reply-To: <20211012141810.30661-1-acadx0@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlhTcGlTOENIeGNmSnNwMHFoellKbXYwVlpFQmhrL2hmdE1lNCszWlZOeE9o?=
 =?utf-8?B?ellhRFU0L0R5dk5TRWhCdWpBeXp5enZpV3Y0alJPMVFrTW1NMHo1dklSMDRQ?=
 =?utf-8?B?NGQrREtNYTc0K0VCb2FqdXVxMHVDK1NxYkNxS1E2eEErZ2hZV0N5RCs1YjZJ?=
 =?utf-8?B?RnlDQTJSVGhpV3FFOUltdEd6L01ZR3pxaWE2Wm5BSUhBUEJhQkRpbTdDOFdz?=
 =?utf-8?B?QnZMUHdndHM2VnZYdGFYc1k4YzlxL1ZNNm9WcTdsUGxrSVovYlc3enduOTB2?=
 =?utf-8?B?OE1FYVhTblpzcmYvRVcrYXhwNTVvYmp6ZnU3RmFWS0pxbU1VT0ZFbUYzMGY3?=
 =?utf-8?B?VXRUZlUyUERlM2RzSVoxQTQyRnBncHNFYzVIbnJxcCtmcUszQWs1MVRxTW1Q?=
 =?utf-8?B?ZEc4eWpmaEZwR3lNUW1VWlh1TU1rQzVrOEpRM2o3dkx1MEhYd3hDdG9jazRE?=
 =?utf-8?B?Q1RBVGgrdzZCNWh5bmsrVXh6VGhJQWVzcTRJV3g5NWFKcWNlV1lpNFpPREI3?=
 =?utf-8?B?eC96Y0Q2WVlUTVk0OS9UOHpQckZ4dmU5UVRhTHFIUmRxU2tMK0F5bnhBZXhQ?=
 =?utf-8?B?dVhFZ05yaGZkRzBIUTkwdGMvWWlvTFYrVDdXd0RxbklyTTRwQVdLdGNLYnRG?=
 =?utf-8?B?L2hFelhXc0FHQXZwZy9wZWZiL2dsNWZzSWxVaVpvZHFPbDQzUE8xWUVpNmxq?=
 =?utf-8?B?Rld4N0dJM3o5c1RKanhpY3V3RTZEN3BqMW1HdUhid1pEMFliZ3NnWmJvenFK?=
 =?utf-8?B?c3hDTVdDeW9leWxnVk9EQ29ER0Y0S1JZOU5MNG9YOFhCRVU0TWNlVUJ1V2pJ?=
 =?utf-8?B?Ky9vS2UrREpsSGNnQStjSmg3TVRWdVVxZFFxZHNReEZla1hRV3lmUXZyYVNI?=
 =?utf-8?B?Rlg4dEF0SXdtd1FXZSt5Tnpta04rUDZrMWxpVHR5TDJpK2dmYk9qYkVFRW5a?=
 =?utf-8?B?b0ZNVWJNZmN2NitaM05abngxcmxxREtRSlMrWnZBdnh0M2RqeldBVTVqUFNm?=
 =?utf-8?B?aHBwamtHL2dZQVRkcnZud2VyK1oycFRjUUwwS2VVQTlUWmgxbjYydGpZY01D?=
 =?utf-8?B?aW9wVmI2ZUJrTHBVbE1POHBwdjk5VHl6bVRvTE5lV01nVG1EWCtRbmNvbTdO?=
 =?utf-8?B?LzlsbzBxYUczbWZoNHcvcVV2eDd6R3hRNkVYQmdRZmpIMUJWKzV4SytjRjM1?=
 =?utf-8?B?YUtEZGJlczIrVHpjZnVuQndOYXRuVlFmQ1VqcWs3MktXTkJFUTFCZ0pmZFJV?=
 =?utf-8?B?SkY1UllpT2NrWVIwSGpOR2FwTGNhb3IwZ0h3NktzOHBMSU1zNGc5M3MxNXRs?=
 =?utf-8?B?dWVEbWE3VjByeExRMVZoUi82WUQ4OEZsUnhuY1hub1ZReXAxUDVvSUxyYzEx?=
 =?utf-8?B?a1FiWWpSbEd3Sk9RS0x1eWNVclNOVlRHelVxOEtXRzBoWmwwb0gweXE4OGFZ?=
 =?utf-8?B?WCtOQUpXbERENUxJKzV4LzErTHY5QW5UcHRDS2h2ZzFFSHpPdG1SMFVDTGtl?=
 =?utf-8?B?K2FaSjUrczBsTVkxU01ET3lJVFdKS0E3MTRJUGtySE9GMHI0aE1adjJVRlFt?=
 =?utf-8?B?aUtiQ24rY3pieGpocmo2eDNZWXJiSDBRT0t4LzUwVkdaazVPMkIyVktXNG1N?=
 =?utf-8?B?Z01tb292S0JHaW5IaEgzaEhCY21wYnM5SFBwRDJ5aFRyRmYzQUs5ZnRidkFM?=
 =?utf-8?B?UmdHQ3dmcVRraGhrWXMxWWE5cU9NL0Q2S2kwNnZEK1M2c1Q1Sm85bEdXRmtZ?=
 =?utf-8?Q?kw0uXKODHAl9Q1LLITzcSpJfrBUWpswIvKjR5tZ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bcac80-aa51-40de-601e-08d98d940ca6
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5278.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 15:22:05.9200
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SyxcKqEQwMtXDoTg9IiWdvAQUM3LfxsNyoQUgWyp0MRc/LU2Kx79ITWJIl1+GSJFIooBR7Z3q8mSC8kHf+qqgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5072
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/10/2021 17:18, Kyungrok Chung wrote:
> Make use of netdev helper functions to improve code readability.
> Replace 'dev->priv_flags & IFF_EBRIDGE' with netif_is_bridge_master(dev).
> 
> Signed-off-by: Kyungrok Chung <acadx0@gmail.com>
> ---
>  net/bridge/br.c                 | 4 ++--
>  net/bridge/br_fdb.c             | 6 +++---
>  net/bridge/br_if.c              | 2 +-
>  net/bridge/br_ioctl.c           | 2 +-
>  net/bridge/br_mdb.c             | 4 ++--
>  net/bridge/br_netfilter_hooks.c | 2 +-
>  net/bridge/br_netlink.c         | 4 ++--
>  7 files changed, 12 insertions(+), 12 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>