Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2556866pxb; Tue, 12 Oct 2021 08:57:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywhRnYs/dRW69AWyaE6/Mwfz/5NO4cXpux3nh/5xtVSsuLNM5DXsukdJdykRu6FZsc5oa3 X-Received: by 2002:a17:90b:4f88:: with SMTP id qe8mr6788727pjb.223.1634054266134; Tue, 12 Oct 2021 08:57:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634054266; cv=none; d=google.com; s=arc-20160816; b=ZHJ0AqTDXTUTKoENOz/IOzp4nEYp5iG8AzmRJc1vquw6AK7Ro6EztbCZ8esi91xaAs OkmSAtcpYsugXHlY5SifwiMq8C5LXuCrn7B2kb6QIjUfMgHxk6gPr8C8isNME6YyQbfp xWVkO1khBWY8ukzP134Hub50BPBF+6MV00DB7wI8/A4OvYEy1aXb7NdharWNIaMCBfkl +UQnXYnt/Aj7KSQegPuawsa6nFc4+W5JxHWP0w348m0oW5aKjWJCfKcM1nY7TYHCNBQd ADIRaHJLIfcUDLNI7PhluT8WAk6cSl6xgHtPuMzqFfpcQmLCggI35vNxKjaK2g4eIf3i bmDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mePc1vd/EHkCrzmAohlwat8GzWH/E7cD+W9nQvLLIu4=; b=t/ZIOzqMAkdK7kCLttLjE4Ou7FZGx16Fgj6ziy10m0wxEJEXJLqA/nFqiD8LOKUDcm bUFlK+I/X0oym3zEnYAbTdZtgMV8I4ch8s0Sq2It0chMfjnQNQvCYtyyIAvH5dVL6u4W qRaRMqeQ+Ar2Q+FBvOmx0cOyjBUw3mhQiGzSO6zWLW9SEOqqoX2hbDRB5eg/WdFR3of0 abAvSyut+IW+PM1asETP56KGZ7o9YBerxFn7nhjrqkdw0BCu0AS/FMO1cnrPH6xn2K8m rrMraH0jnvjBYzBRipDbP2xVXmcu49rsV+m2bCLdVWKHvpFkrVDzVg9feb33Vur1XsBY dPbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kVgy/+a6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d64si17139422pgc.280.2021.10.12.08.57.32; Tue, 12 Oct 2021 08:57:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kVgy/+a6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237241AbhJLP6a (ORCPT + 99 others); Tue, 12 Oct 2021 11:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237322AbhJLP63 (ORCPT ); Tue, 12 Oct 2021 11:58:29 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22645C061745 for ; Tue, 12 Oct 2021 08:56:28 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id w14so13857950pll.2 for ; Tue, 12 Oct 2021 08:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mePc1vd/EHkCrzmAohlwat8GzWH/E7cD+W9nQvLLIu4=; b=kVgy/+a6lh3I0ZXvFbqdwy4cdixEQ48qJ26ZMs6smSIwYFRMHnCYmK74ep66Sx3NOp 5DZI2jgV+ULNul+LewUNEth7jaeoPygVEtuP9gnEsicoqXqHN549VAJManTku0D5jOZh /4aNCfAUh2JFPJN3uU8zI7/CYX+exCFxt+5NJTzB18HiDlKzLS7jZYywMt1OQNIEiGxN xEEx2frxHKz7CMP4DJnzXoKGzi7Eo/4yd4/T/Ru0VxqVdIKOzVQ0f03R0stfXqKLZXFZ zjyxI4X1ikLAAOU48ftSRGNlddJUAgPYuVygYJgHeqI+QI0JbR6wKnd2eJMndpbs23QA +Tmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mePc1vd/EHkCrzmAohlwat8GzWH/E7cD+W9nQvLLIu4=; b=AP3NsStIUgC6PtvSI0edySQ7UL8f/ng6z1X4pFrIk1A7fLssGlH5boja3g6hvu9Nkp n8pdDDfmkbFti6XyeeKmsmW0WU1t+CPZQlXzKQzb1wqja79qTdWO6cG21pEVzH40jS0U YJoSJYvf+vBc1ZDQ9/bb9rR/ONdti2WfFmM0BoAGMTIOOxFs+s544BJs5Ub0bB8I2fe3 QdOFg1HTxv4raYB7Xc1EhoSEzSq9tgGv59W4CB46AoyXVbMqc7St06v3ywP/EyGD+4jl 6e9kyML142K2zieZi4nPUjQxeQlLmzK97a/a2DuLvlbyanqCVntdcbSl+pfMIetpIQx8 lRzA== X-Gm-Message-State: AOAM531N57iAvaLdKpS7Q2TIkPULITjOHq7bS+kVBMZaZ/q7fP5NkzWg qGehssrv9VaJYRVl8DVnInAc5A== X-Received: by 2002:a17:90b:388f:: with SMTP id mu15mr6915883pjb.28.1634054187510; Tue, 12 Oct 2021 08:56:27 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id jz10sm3246547pjb.39.2021.10.12.08.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 08:56:25 -0700 (PDT) Date: Tue, 12 Oct 2021 09:56:23 -0600 From: Mathieu Poirier To: Shengjiu Wang Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com Subject: Re: [PATCH v6 0/4] Add remoteproc driver for DSP on i.MX Message-ID: <20211012155623.GA4010675@p14s> References: <1633944015-789-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1633944015-789-1-git-send-email-shengjiu.wang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 11, 2021 at 05:20:11PM +0800, Shengjiu Wang wrote: > Provide a basic driver to control DSP processor found on NXP i.MX8QM, > i.MX8QXP, i.MX8MP and i.MX8ULP. > > Currently it is able to resolve addresses between DSP and main CPU, > start and stop the processor, suspend and resume. > > The communication between DSP and main CPU is based on mailbox, there > are three mailbox channels (tx, rx, rxdb). > > This driver was tested on NXP i.MX8QM, i.MX8QXP, i.MX8MP and i.MX8ULP. > > changes in v6: > - fix the apply issue for linux-next > - add if/then schema according to Rob's comments > > changes in v5: > - refine driver according to Mathieu's comments > > changes in v4: > - merge binding doc to fsl,dsp.yaml for Rob's comments > > changes in v3: > - Add this cover letter > - refine clock-names according to Rob's comments > - move common struct from imx_rproc.c to header file > - add IMX_RPROC_SCU_API enum item > - refine driver according to Mathieu's comments > > changes in v2: > - change syscon to fsl,dsp-ctrl > - add items for clock-names > > Shengjiu Wang (4): > remoteproc: imx_rproc: Move common structure to header file > remoteproc: imx_rproc: Add IMX_RPROC_SCU_API method > remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX > dt-bindings: dsp: fsl: update binding document for remote proc driver > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 123 +- > drivers/remoteproc/Kconfig | 11 + > drivers/remoteproc/Makefile | 1 + > drivers/remoteproc/imx_dsp_rproc.c | 1206 +++++++++++++++++ > drivers/remoteproc/imx_rproc.c | 28 +- > drivers/remoteproc/imx_rproc.h | 39 + > 6 files changed, 1375 insertions(+), 33 deletions(-) > create mode 100644 drivers/remoteproc/imx_dsp_rproc.c > create mode 100644 drivers/remoteproc/imx_rproc.h I have applied this set. Thanks, Mathieu > > -- > 2.17.1 >