Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Oct 2021 13:11:12 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Lijun Ou <oulijun@huawei.com>, Weihang Li <liweihang@huawei.com>,
        Doug Ledford <dledford@redhat.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/hns: Use dma_alloc_coherent() instead of
 kmalloc/dma_map_single()
Message-ID: <20211012161112.GA3375648@nvidia.com>
References: <20210926061116.282-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210926061116.282-1-caihuoqing@baidu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pRq5LC3afz2P2ERNfR3sVfaqZviAO16k2gJWQwnhTYJGoQCRk9tGohSM8hgq?=
 =?us-ascii?Q?5Py10tfKnwvAmTVSvqSIy31tPXwxyF4OFHB38SY9VSX+dNYWvEyYeRDPmbAV?=
 =?us-ascii?Q?bU+1F0YHdeMlprC6H4SFw3LSB7SFSimkVXhOuiBgvOntm0U43bUE9CY0t0qY?=
 =?us-ascii?Q?lqy+auhvYsY8hf8lHkb6obfjNoeeOB+3yPYlCeVap6NYgCccaKCOoTjNoIpv?=
 =?us-ascii?Q?Pb6ydVWFiiKQssmu87BSADSdKg1Z3w6apxgv/oB28p777BULm+akhkU7YwnM?=
 =?us-ascii?Q?rSMH3VSIEbHHR6L1F/w2h4gzwgmbpCF/Iu5HG3cIGMONJPW5JCKooaMsiVFP?=
 =?us-ascii?Q?zpCXZvtKxh9/bufvgAFhZ3/GsYHmRTTMnYbaq+3a1tUcGv7zxgXKAwwpGdQ8?=
 =?us-ascii?Q?+xZTsB6D8wqxkxp7rHBKgyhlzKQF2Hyh3KhgODJZBIaKj8tF1CU5lfOMku0Z?=
 =?us-ascii?Q?H0xns7uv//2LGEPH3OeS+19+wekvtlqcK7XQFvkgxwhLt3EhzxheKOqZNYdW?=
 =?us-ascii?Q?vW8gieqGAyxph3CsxUJ/d2u/9Tipba5lP1pCM/GNl9T0IZopg+6i9/QiMGyA?=
 =?us-ascii?Q?ROXWULorBorJqa6R9VYX2Wde66Z11kfCok1sYv3oKs3TRnHyFMtb/xBGwabS?=
 =?us-ascii?Q?byO+O+mu4l7BWDvHwZ68UBkZg/RdFJuiiclw8228l/aIKyNl4eNUsnYmX55G?=
 =?us-ascii?Q?l2eqcgBHl2il7Oc1ZtigCorK1RCMpsIpKP4U6/LnOrBKJngQYHU8n1pbqUNh?=
 =?us-ascii?Q?y03i37O0zPq192hBRceUq+Yep+c1T5GdOGm3z0Hk/J4ZVhzM8YyiZkWR6jrh?=
 =?us-ascii?Q?qhfuoXJAfQVSEANGbcPx8GaZpB0Q9CxUo0hvmy7D0eXjCiEK8FuLHya4fHc8?=
 =?us-ascii?Q?U1Sx7bCV5O+R4mJtnuHNv8MPZDNxAkoE7zKLvZVwS4addSUKjKDstGjz9mJg?=
 =?us-ascii?Q?ZIT1nBdc21R90bun9GG8xVTgAAlooUM2AryQTAJ0lHq07T3HHqvFKWLY8A2e?=
 =?us-ascii?Q?78kqFAe7Jq5S6VvkNOfvvZctJGMVnLthDM2LBIMhnbTMIxN0Uags5kgXbkiQ?=
 =?us-ascii?Q?Kp6y+InAD/UOGiWaayIs4vsI4s4dHKBCWTrLW2N/QUXg/SfZQwX7p0OW/p0L?=
 =?us-ascii?Q?A/orHRiu2xhIL2hLW4xo/FwBvaVsPBKiI61zs1o3SBZY+hJPE2GZJchEMA7n?=
 =?us-ascii?Q?aXTUAQyotkXOebsYUzliDA7j5w6T+C3ivAmuXK6es6J7cenYEJTqAJkL+rbr?=
 =?us-ascii?Q?qce43G7cCcN3c05qkP3u2e9f2huxB9jbUfxJex+mPgmK4t+ADwEqoRG0tQqf?=
 =?us-ascii?Q?66QGssRIG0nST8FH3bAChFJzjL+MAuTv20S4JlTuxmQWeQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af997a5e-6170-4333-229f-08d98d9ae983
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 16:11:13.5295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ntA9lK7hd5X52D94JmlpNH/5LFABYnGOUxD5fh8lsvxm55ySW2zO3KqEpyvGkJ/Z
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5192
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 26, 2021 at 02:11:15PM +0800, Cai Huoqing wrote:
> Replacing kmalloc/kfree/dma_map_single/dma_unmap_single()
> with dma_alloc_coherent/dma_free_coherent() helps to reduce
> code size, and simplify the code, and coherent DMA will not
> clear the cache every time.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> Reviewed-by: Wenpeng Liang <liangwenpeng@huawei.com>
> Tested-by: Wenpeng Liang <liangwenpeng@huawei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)

Applied to for-next, thanks

Jason