Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
Subject: Re: [RFC net-next PATCH 01/16] dt-bindings: net: Add pcs property
To:     Rob Herring <robh@kernel.org>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        devicetree@vger.kernel.org
References: <20211004191527.1610759-1-sean.anderson@seco.com>
 <20211004191527.1610759-2-sean.anderson@seco.com>
 <YVwdWIJiV1nkJ4A3@shell.armlinux.org.uk>
 <YWWKuhn4FfgbcqO/@robh.at.kernel.org>
Message-ID: <2e5ebf4e-bc97-1b8b-02e2-fe455aa1c100@seco.com>
Date:   Tue, 12 Oct 2021 12:18:37 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YWWKuhn4FfgbcqO/@robh.at.kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTMveWI0QklXTVJwQWxta21DQyt2ZFVQSUdoQ29zNG9NaHFHQ2dERUJMaVV0?=
 =?utf-8?B?bHFRL0JJZWh6dEJBemZTODY3R2hCQnlvZTJ2cUVkUVZpVkd3NmQrcVR0QnVJ?=
 =?utf-8?B?OVFkbFhma0ZSMDFzdGVhcFQxN0NVYmw2ME1tZGNpTHFQYllXb0dyZGFsSU9J?=
 =?utf-8?B?UWlPcEtqcXVxZUhrMkY2YUt5Skp5a3FHUXhKcTJqb0pTaVR0Y0VhY3JkR0RQ?=
 =?utf-8?B?NGFCU0JPeUJ0STFFK0c2SnpYakFZZmV1WVQzdHc5OTVNSmYrK3BpejFSZ3NH?=
 =?utf-8?B?b0t1Y29FM21iVjdEaXBDblZmV0hrdE5QeXlaSkhXK0QzWGtFVTVEb0lxOHNX?=
 =?utf-8?B?V2NYNC9vei9OdGhuNmtmTHJlQnlWQkVDak9FRVREMXVtMkpiUC9Ra2tEM3No?=
 =?utf-8?B?YnY3cytDbnJyTGhaVzBLZ0lLbTEyQ3hzWWRhU1JsdnhuWEhZWDR4NkkzN1BK?=
 =?utf-8?B?aG83bEg4WkN5Szg4ejVxL0tyNytVcFRhN204aEkzM01LL3c3d0NOQnhRS05w?=
 =?utf-8?B?R0trdzRXNG1iV0tNak0vVmVPMWVrRkhhdjMyZHczZkJHVXhFaFBTV0F4Umd5?=
 =?utf-8?B?YS9WYXF1M1FLSW9rZEh0R3RmcVRKSVdIQ1RjdWFHREEzaDZjOVFWaGdsWXor?=
 =?utf-8?B?NTRHMUppZGlOM004ZVFqMloxT0hsUjlyVzVwMzBmQmtxYzQrdkNLODUwV3Zv?=
 =?utf-8?B?NXVaSndQd1ZBcGtUaklVZnlmZEdBZG8yVEJNMFRJSk1Sai9sWTZNVDQvQU9n?=
 =?utf-8?B?N3BBOFZ3WWpoa1cxVEZrOFhpVHpjUFN1WUtMVDJnY2RjTU9nUzdpVHZKS0xW?=
 =?utf-8?B?Rit2emhmQ1JXMkpEUHpVRE5BYzZjMWxWRUV0Rmp4OWRkdkNWdEtLNGgyOFIx?=
 =?utf-8?B?d0lYYmZCMjM2UzMrV2h1Y0loRGZJQkVFcGIzcFFpTm8vaVU5OFFReWM2WVlH?=
 =?utf-8?B?bjl0SlJRTW9XK2RsRHJWN2lVbjNRQVZCRHdHK2VKMWdmaU11S3R6VjdyQlJ1?=
 =?utf-8?B?L3FtRnpKYXAwMTFWUlp5eEtlWFpoUHhPQjA0M3RueURhbS9tR210d3ZPM3U4?=
 =?utf-8?B?WG0yWE41WWptbWd4alZZUCtpbW0zL0pPRmJCTlpPZXpHdXNza09CNGtOSHJW?=
 =?utf-8?B?bkNEaEdsQXh1N3VoRy9SYjJoc2FDT3d0S1lIWDQyV1dsMll6NFdVWGRKb3oz?=
 =?utf-8?B?Z3BEQmFUUHIwaWYzc0xBcW1POXFRWHIwQVF0czVYWDZSc3h2RWtLQTVXQ0Zx?=
 =?utf-8?B?ajNzWkhVQlhoZHBjZHNpUHFUVy9Ya1FpSytjWWlvS3Zxd0p5aGsra1REYWI5?=
 =?utf-8?B?TVV5ZUszVVZYQ3pRTFhvbW51OHNRRTJUeHlEdDQ1NE5KVVJraWhTaWp4U1E0?=
 =?utf-8?B?WS9Od3hSVjdPQ0V3T3MyUXNFMGtqeHB1K3gvM1JXalJQaW9uMFNyWU5idDlC?=
 =?utf-8?B?YnR5QytwNnpsUXJKU3BGeXlwVlozZXd6amhrWjE2Skg1UlJqbjZ4Y0NHTUdX?=
 =?utf-8?B?emUwNlRtRkRIaEFuR2MzeDN6V3hSZTRpUENiOGd0ODA4YlF6TzBTRkVETjli?=
 =?utf-8?B?LzF6dmhGbW5LYXNMV2M0d1NoemxLaHdlcmZtSlowWTZMaXcxaWtEVXd6emFC?=
 =?utf-8?B?VnFkNUp2TW1hT1d2azBhMkJwbkw0OHJjY2lQS3lSSmoxQWhwKzFvWllyNnNR?=
 =?utf-8?B?TUdZVWNLQVR1RzQ0dXpOdnF4amYwaEhpa1RNYzdzM1Z4V0w2R0ZIRXUrYzNO?=
 =?utf-8?Q?LvMmnsg9HLmHV283PP4deXQl7P87n23YZmiIm6J?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cddf713-d576-4d19-583b-08d98d9bf4ef
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 16:18:42.0018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ilwFpmjRArSR2eBOD/we7ufL1TFwV+Y854dyU1Rcp8HrTRXu+aKS+upUIXANrEr0X+yKfJ+BzKTnm4oFH65aOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7243
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On 10/12/21 9:16 AM, Rob Herring wrote:
> On Tue, Oct 05, 2021 at 10:39:36AM +0100, Russell King (Oracle) wrote:
>> On Mon, Oct 04, 2021 at 03:15:12PM -0400, Sean Anderson wrote:
>> > Add a property for associating PCS devices with ethernet controllers.
>> > Because PCS has no generic analogue like PHY, I have left off the
>> > -handle suffix.
>>
>> For PHYs, we used to have phy and phy-device as property names, but the
>> modern name is "phy-handle". I think we should do the same here, so I
>> would suggest using "pcs-handle".
>
> On 1G and up ethernet, we have 2 PHYs. There's the external (typically)
> ethernet PHY which is what the above properties are for. Then there's
> the on-chip serdes PHY similar to SATA, PCIe, etc. which includes the
> PCS part. For this part, we should use the generic PHY binding. I think
> we already have bindings doing that.

In the 802.3 models, there are several components which convert between
the MII (from the MAC) and the MDI (the physical protocol on the wire).
These are the Physical Coding Sublayer (PCS), Physical Medium Attachment
(PMA) sublayer, and Physical Medium Dependent (PMD) sublayer. The PMD
converts between the physical layer signaling and the on-chip (or
on-board) signalling. The PMA performs clock recovery and converts the
serial data from the PMD into parallel data for the PCS. The PCS handles
autonegotiation, CSMA/CD, and conversion to the apripriate MII for
communicating with the MAC.

In the above model, generic serdes devices generally correspond to the
PMA/PMD sublayers. The PCS is generally a separate device, both
on the hardware and software level. It provides an ethernet-specific
layer on top of the more generic underlying encoding. For this reason,
the PCS should be modeled as its own device, which may then contain a
reference to the appropriate serdes.

The above model describes physical layers such as 1000BASE-X or
10GBASE-X where the PCS/PMA/PMD is the last layer before the physical
medium. In that case, the PCS could be modeled as a traditional PHY.
However, when using (e.g.) SGMII, it is common for the "MDI" to be
SGMII, and for another PHY to convert to 1000BASE-T. To model this
correctly, the PCS/PMA/PMD layer must be considered independently from
the PHY which will ultimately convert the MII to the MDI.

--Sean