Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Dexuan Cui <decui@microsoft.com>
Cc:     kys@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        haiyangz@microsoft.com, ming.lei@redhat.com, bvanassche@acm.org,
        john.garry@huawei.com, linux-scsi@vger.kernel.org,
        linux-hyperv@vger.kernel.org, longli@microsoft.com,
        mikelley@microsoft.com, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH v3] scsi: core: Fix shost->cmd_per_lun calculation in
 scsi_add_host_with_dma()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pmsaqjrk.fsf@ca-mkp.ca.oracle.com>
References: <20211008043546.6006-1-decui@microsoft.com>
Date:   Tue, 12 Oct 2021 12:41:48 -0400
In-Reply-To: <20211008043546.6006-1-decui@microsoft.com> (Dexuan Cui's message
        of "Thu, 7 Oct 2021 21:35:46 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6L0D6AZBOU4xx30nCpCdb+Z1Pfx2jilRcQknLpj56Dr0Evzo5eGFH6sUlQMr?=
 =?us-ascii?Q?57J3MPJMb43/L8rcEOysUnXN84/6ZEp/7/EWj5MWRD0GY3mLAxD6BZME896N?=
 =?us-ascii?Q?efxZZB+b5XrRaQ/Stg3NbDbzaF4diVo++LN5zkwHjQmHt8w+/aDuE9SnrU94?=
 =?us-ascii?Q?7Z0VGGx/J6imFmoJxViKgGWW48c97UJaA0juDvWZzw3wpW3ZDHYWUTDe+EhT?=
 =?us-ascii?Q?8sO0Q4eltjG93kPV//N92vNxIG2pdoe8uO9ErcUffZ6Vl9SD1WyQ0F7P/jCO?=
 =?us-ascii?Q?j604V0Nh68Jc/lLprtxgzRMRIsSSiUV+64TGwdsnMJwaSybbkAjyd0D5bfAe?=
 =?us-ascii?Q?pMqJC+sk4rMMzQq8U3Wa3E4eed2Wbes7KTvYkbrayGXq1/SPuYH9jTtiQhci?=
 =?us-ascii?Q?NE9g7Fw5qLNcxar9z9MxcbxtMKbsdzqXIe/gHhK9xIfESO9nFVwh3+16Cqvs?=
 =?us-ascii?Q?jMOKzfSTbc7RwCE1AqnDA/fbEvWcSsnrsam7E53OveKIK7H55wXld6YhKx75?=
 =?us-ascii?Q?QaeL9IJUIf6nFKMoht7dpSP4AM7YfjFyF6iuzJDEwXgmbGTSr7+SwVfRLZCj?=
 =?us-ascii?Q?l65j+Lj3K3pu+9nBUsT8ui+7TY80Ezh1tgR2iFNqaPBD9/TxmedwXzfeeZpJ?=
 =?us-ascii?Q?OuI1VauWZAcYyJAEu2THN9hJV805zbd0fXJXZIUJ8vY9WxEND1QFxWavms34?=
 =?us-ascii?Q?u21gOOnFDzTYlXQ5WuXUQabVKiUN4ON7TsY640HAwUhFq/Ogxmaip9bD7sxL?=
 =?us-ascii?Q?VvkdeM7pekpfS1uUR4HeNDR6/Xgr98UNJ2GqYFyz9sBaJZvTog1l0cM/hfut?=
 =?us-ascii?Q?tU0xpiO1exUMOx0TY1r8SxVxkD0LXU/C8xBFpdWbwqoDTjiOoZOwdwAUAyRd?=
 =?us-ascii?Q?rhKyS/jnwX37PcOYPh4MpzEHJ8GCRALeOsNPZb4s3Gaebwb5RM9lHgULAVBi?=
 =?us-ascii?Q?iZRY3d1xGt9HFgf/3OGTSlNn7A/wzzizkgMtrwFlmNuEBPzMdtbvl+8bp61Q?=
 =?us-ascii?Q?6JcffLja+pIsVxSJhoVqky6R7SQ0pPweG6Y2ik4dbVK/nIWj53MnaIODflU9?=
 =?us-ascii?Q?PxFDO599e/bIPdEdXm41JFeY5b7aIyLnqFoZGDe35LiyovY8C+rkoQvhl5Ue?=
 =?us-ascii?Q?T1zcy/812fVjx8KUJvBVeoVfosrS49vTGE2Uw2rlwuPiLkgmpeA9c+icM2Vl?=
 =?us-ascii?Q?dPkH2mvqqAKXQy8a/2vvyLF9ggAY+L54VKWeFT+NlMqJ6wyex4YXGZK17rC2?=
 =?us-ascii?Q?iUcEaqd7CQ7PXempnv/uQ0u8f9lGqnDne3fCOop33r71e7BfvRpuDt3jnJ6w?=
 =?us-ascii?Q?tcylX2pxIP9DK7QfI3rxlVbG?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25b22265-d10b-4583-4d5a-08d98d9f305d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 16:41:50.1279
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: clNdj6oNEyO64lQ8kERknvnBLyZ+S8knwMqH4XqlSj0LgT7lz3smPnpvBXFeKtbKRZniw/mumPeDZ3NiuiVUlv0R1Reos8EGwheS3yt0iBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4566
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120092
X-Proofpoint-ORIG-GUID: GHQwJMqfHEPdyLELBs56Gl1BGY_6ZBfY
X-Proofpoint-GUID: GHQwJMqfHEPdyLELBs56Gl1BGY_6ZBfY
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Dexuan,

> After commit ea2f0f77538c, a 416-CPU VM running on Hyper-V hangs during
> boot because the hv_storvsc driver sets scsi_driver.can_queue to an "int"
> value that exceeds SHRT_MAX, and hence scsi_add_host_with_dma() sets
> shost->cmd_per_lun to a negative "short" value.
>
> Use min_t(int, ...) to fix the issue.

I queued this up as a short term workaround. However, I am hoping that
the rework of the scaling code in storvsc lands soon.

-- 
Martin K. Petersen	Oracle Linux Engineering