Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2645927pxb; Tue, 12 Oct 2021 10:32:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsNspApKLdTfiIR67QgloFp18ehr8sPQdKW6v+onHSRXkVTPKClD2pAJPUALhoV61RS4SW X-Received: by 2002:a17:90a:e7c8:: with SMTP id kb8mr7487536pjb.95.1634059959121; Tue, 12 Oct 2021 10:32:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634059959; cv=none; d=google.com; s=arc-20160816; b=nFEHQQuH/4B4HjjLCdj0wD5Q8z4QON7CDg8nKo+BQJwDQJVplfk/EFoPGMpP92O6Ga 4lraEcaQqu1lOqNXYlMcxD6jpqVc10w9eDHYXQJ7g3lTQnohyr5wPDiPXk8ud8KVhS9k o9QmCkviZVMa31q0fnWsK58ks6iAHygUgzgJVn8sVxxDrdQ3BnDz1CaQyxNsTKNXoaF6 lO29vpt5T66nz9YVCWrR6A6cWKLjShci1A7o0CdQhHm6exGOo5hrxvOtFpmkGgMVSZg0 elXD0p/xQmTpItMlTmRqEBT/M+jGHPeu8Ytww7lz5CsE42mO2cSJIVF4zBS7LJQRIpCI E6Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=z/0YDsWVgY8iQTsDuzbYnenwugKkL3hk/JKxgPGOGcI=; b=pkuRwBBTl1kEvFCOW7bh13oWWdXsP3YJHH0k9B+BJ298crCyZJh3nW9EU7nRoZBEgP 1X1yFEyguvwuZYADrcmAl7S6qUUF76DxYwpcVSQV7SGPPi93LlUtLSnaJaOuHS2jCuIb 6UL2j3VcDFeJ05u6vA8vOeLg27QxjRfjwqAUiA+0T81MrsBMudghPtB1uInhRzamSCz5 MGhSW9+2euYgtLBXSn6f1Z/Zj3ugRAURJ97dRJDs1CCubaNg12bCYMI4E7H5EcXC0N/X RtiU58n7mmwjzwyqwIf2Oks7ZloX9JLwmHClJsZG4wYEpseIU7wuL7aQKh0vxRZgIG0J 7uxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HkxFstT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x33si16419038pgl.277.2021.10.12.10.32.26; Tue, 12 Oct 2021 10:32:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HkxFstT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232520AbhJLRcz (ORCPT + 99 others); Tue, 12 Oct 2021 13:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232509AbhJLRcy (ORCPT ); Tue, 12 Oct 2021 13:32:54 -0400 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CBD8C061745 for ; Tue, 12 Oct 2021 10:30:52 -0700 (PDT) Received: by mail-oo1-xc35.google.com with SMTP id j11-20020a4a92cb000000b002902ae8cb10so6616707ooh.7 for ; Tue, 12 Oct 2021 10:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=z/0YDsWVgY8iQTsDuzbYnenwugKkL3hk/JKxgPGOGcI=; b=HkxFstT0p4m1QLP90AGW9wtYHvxedTtvyniXxElQkMbozckVbZpY+ySg4/JdDB/trd YmtybS62NmQKyuSF2NuUNk/j75EMhjXpkPYyXZ03J2Jfu55793aAlYSZtNV7lFbJFFi6 sWDSf+PNXbeErsE4e2zK60JCUsOUnmb+5L7FY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=z/0YDsWVgY8iQTsDuzbYnenwugKkL3hk/JKxgPGOGcI=; b=Ymxs9fLlmwfo3aAZ8bABCm3OWqPXvDkcmxtCKZoXYgaR4TsvLIttsmLtdzHU2G0J4u yMjwLzg79HQeaBScXuQL/QoDRpk6qOj3PzJPo8L6Vu8GXhAdt+sqZT/jEM9DBpLoToas QBKzkM+Aevxa9jKpxNibp77y1fJB0+HIPKlnvNOvJ/CXeUTcVyV3dQVp/6BXbOHiatRD 2/IZbgup2CAqVTLWlgAgCr2GxgfeOpqb3fIh+enh5XqhYKpkPVf5jikqHo3LCIr1GlyZ Wt4LwhTKpcxRoiXv0FffXXxuYHJcXJGstfbOCN+06TcHI7tUlLpa8yHrucMhneslyzg2 sPyg== X-Gm-Message-State: AOAM533i5ZhjblgFTjxqmYobnn/qcEwdb3KCbgpHp9arugM5+qR99l67 nUKkmp5ZOIa3ctwu1FWBsgenZw28MRcGb68O2RrIzw== X-Received: by 2002:a4a:e2d3:: with SMTP id l19mr24660471oot.1.1634059851594; Tue, 12 Oct 2021 10:30:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Oct 2021 10:30:51 -0700 MIME-Version: 1.0 In-Reply-To: <20211011201642.167700-1-marijn.suijten@somainline.org> References: <20211011201642.167700-1-marijn.suijten@somainline.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 12 Oct 2021 10:30:51 -0700 Message-ID: Subject: Re: [PATCH v2] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL To: Marijn Suijten , phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , Abhinav Kumar , Jonathan Marek , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marijn Suijten (2021-10-11 13:16:40) > div_u64_rem provides the result of the division and additionally the > remainder; don't use this function to solely calculate the remainder > while calculating the division again with div_u64. > > A similar improvement was applied earlier to the 10nm pll in > 5c191fef4ce2 ("drm/msm/dsi_pll_10nm: Fix dividing the same numbers > twice"). > > Signed-off-by: Marijn Suijten > --- Reviewed-by: Stephen Boyd