Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 3/7] i2c: i2c-amd-mp2-plat: ACPI: Use ACPI_COMPANION()
 directly
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Elie Morisse <syniurge@gmail.com>,
        Nehal Shah <nehal-bakulchandra.shah@amd.com>,
        linux-i2c@vger.kernel.org
References: <4369779.LvFx2qVVIh@kreacher> <3647069.kQq0lBPeGt@kreacher>
From:   Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Message-ID: <56cc8580-f982-742c-6808-a4d66e39da8b@amd.com>
Date:   Tue, 12 Oct 2021 23:42:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <3647069.kQq0lBPeGt@kreacher>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3Zjd0s0SUhuRDFWeXJ3d1h5WE1XQkJ5N0F6c3lhNVE2VWdGeS9NY3Q1d3JO?=
 =?utf-8?B?VUFkNzhjMUpVb3ZlQUxuZS9rN1dqY3JUanpXekY1c2pkL1FRUXdqUVpkYmJ4?=
 =?utf-8?B?dlNudWpBZjV6VTNRM3FBYk9vbWFhZG1Bd1ZWT2FseitvSk0reVpVRDJzU3BM?=
 =?utf-8?B?NVRVOXRFS0VSYUVjS0ZvZjRobDVBTlA5amRGOEJYZmU2T0dmL1RUK3FCUktP?=
 =?utf-8?B?WnJYeGMybWJ4QS9OZHM2NmRsRmNZNWlWbmEyYXNha055emtwUHdVdjVZRngv?=
 =?utf-8?B?TnlkWUxMUnFyakxYTEk1VEp4WVFnZU54RkhBK1pkaThweXdNenBpNUVSQXd5?=
 =?utf-8?B?NCs5eHVTY2xxZkZXZHVneEZJOVpqS0R0VTdoajYzU0pFaUVIK0tLd29XQ3Ft?=
 =?utf-8?B?ajNjYlB2VSs1Q3V0UWRvMlMwQis0cXIyVytoV3A2ME1KUHIxRGxxNTFCQWtk?=
 =?utf-8?B?a1VxWGo2cVppZjlKOGIzVVJxRGU1V1ltSW9Qa0lUeEt6LzdsMGFybldIbFFG?=
 =?utf-8?B?UGRBK29hUWNRcmtwcnRCb09SZy9mK0k5SjNmZXpKVkREWTJxanZJVjRZWWJz?=
 =?utf-8?B?cjNFeW1KRE40bHBGaTN6V2M3V2pJdUFZbTF3cGdiZ3U5WUllR2RyNlJsdVBz?=
 =?utf-8?B?WW8wTjd2bWZybGZYSW5ybU40RTFIbFNYb2NXMDdvT0V2SHpBTTJrNE5TdEtC?=
 =?utf-8?B?WnRxWEp5aExCZzZZM0NqdXNEeEtLTjhiOW5rTUo1Qld4bkljY0tZeDBZbWFz?=
 =?utf-8?B?YmI5R2JpUDBYMGc2amZ5VlhCVmhQWnkrZWl3aWhYYnVyZ2plUFJhQml1L2Y4?=
 =?utf-8?B?Y093QmNqL2pxb0cvWTgxOU9yejdXMldYaU9oVDZhVE1hVHVpcnkxMmNBT2ZC?=
 =?utf-8?B?WVRJMG9pWjdMQW1CMEx0a1JZS05NVk8rZjQxSzZ2Wkd1WXhvVW02RVlkSXNN?=
 =?utf-8?B?V1ZqaFNUV1NYeUtYUEVRRDlHejZJS2k2eEllbmJ6MUZTMjZ3NmROWTJia05O?=
 =?utf-8?B?UlhFVFYzM2lLWVRNTXpTdUdXRHIzTlFsdFJrZ2VEWmx5R1hkNU9sN3dqKys3?=
 =?utf-8?B?emZ1RzIrM05jWllOSS9GUzFBZ1FZVFJZZklGRnMzTmU2T0lwd21KYitnNlZS?=
 =?utf-8?B?MitRSE9TNnk5M3FhQ2Z6akl5NHBCV3k2cXdaVW54MUJBdDdSZVJBMG51aWVt?=
 =?utf-8?B?S1YxWjRUU3YyM0xsR0NqZGxNeUZXeHdWSktFMVZhRDRSTHlnY2lXd1E2K0tv?=
 =?utf-8?B?cGgvYjFoUTRaNXBTbms4YlNrY2NuSG83NysyVW1EYjBDS2xQTWxTaS9Kek5w?=
 =?utf-8?B?T044L1MzVEZDYUl5V3hIZFBjU0w4Zkc0VU1VUVdMYm9SdzMvR3NPRlZmQUw3?=
 =?utf-8?B?eXpEWWo1MnVBNVhzY3pCRVo3RWp6RXpvMjhDbDZIczZMUWpuWW5JdlZwSHdR?=
 =?utf-8?B?V0hpU1luY21rT3N5aDVlUWlKV2xCcE1WM1IzRXpHY2F3VmRGNTZZVEgzckhu?=
 =?utf-8?B?MXN1TVBNQk04ajdweEpjRElKdTZzS1dWYkhYNWtGcmNPTUhmazVOMHdZOVpB?=
 =?utf-8?B?dEcyRXh2UC95dlorR1A3VXdyeHRCN0RhWFdDRmNxTlkxeXNyVStSNk5CTldM?=
 =?utf-8?B?UHBMZG0zY3JSK3FieVNwa0NMclVDbEh2VHVZOHFuemoxTkFwYVFIcDd3TU45?=
 =?utf-8?B?TjhBa291Uit3MUhTMWpDYyszVDlnTXVoOWR4RGFqSjVLTlhVY2Y1QVA0ZTRF?=
 =?utf-8?Q?vRwIbF2/yhCSaVZ1w/fFM4rGABkNp5FGZJRySLk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 301ea9af-ed02-4435-5f8e-08d98dabe05c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 18:12:39.5617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XiPsStRSCGo6AMKpNRbs9V/M3HCf6HDJ54klBZr2jNm3KWrLu+P84ijsyoE3QSWBxWv7ALah1gd1Vb2UlFOBag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5110
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/12/2021 11:14 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael@kernel.org>
> 
> The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
> macro and the ACPI handle produced by the former comes from the
> ACPI device object produced by the latter, so it is way more
> straightforward to evaluate the latter directly instead of passing
> the handle produced by the former to acpi_bus_get_device().
> 
> Modify i2c_amd_probe() accordingly (no intentional functional impact).
> 
> Signed-off-by: Rafael J. Wysocki <rafael@kernel.org>

Looks good to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

> ---
>  drivers/i2c/busses/i2c-amd-mp2-plat.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Index: linux-pm/drivers/i2c/busses/i2c-amd-mp2-plat.c
> ===================================================================
> --- linux-pm.orig/drivers/i2c/busses/i2c-amd-mp2-plat.c
> +++ linux-pm/drivers/i2c/busses/i2c-amd-mp2-plat.c
> @@ -246,12 +246,11 @@ static int i2c_amd_probe(struct platform
>  {
>  	int ret;
>  	struct amd_i2c_dev *i2c_dev;
> -	acpi_handle handle = ACPI_HANDLE(&pdev->dev);
> -	struct acpi_device *adev;
> +	struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
>  	struct amd_mp2_dev *mp2_dev;
>  	const char *uid;
>  
> -	if (acpi_bus_get_device(handle, &adev))
> +	if (!adev)
>  		return -ENODEV;
>  
>  	/* The ACPI namespace doesn't contain information about which MP2 PCI
> 
> 
>