Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Borislav Petkov <bp@alien8.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [patch 13/31] x86/fpu: Move KVMs FPU swapping to FPU core
In-Reply-To: <87czoaaymr.ffs@tglx>
References: <20211011215813.558681373@linutronix.de>
 <20211011223611.069324121@linutronix.de> <YWW9ksxtp4hpT0GI@zn.tnic>
 <87czoaaymr.ffs@tglx>
Date:   Tue, 12 Oct 2021 20:26:56 +0200
Message-ID: <87a6jeaykv.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Oct 12 2021 at 20:25, Thomas Gleixner wrote:

> On Tue, Oct 12 2021 at 18:53, Borislav Petkov wrote:
>> On Tue, Oct 12, 2021 at 02:00:17AM +0200, Thomas Gleixner wrote:
>>>  	/*
>>> -	 * Guests with protected state can't have it set by the hypervisor,
>>> -	 * so skip trying to set it.
>>> +	 * Guest with protected state have guest_fpu == NULL which makes
>>
>> "Guests ... "
>>
>>> +	 * the swap only safe the host state. Exclude PKRU from restore as
>>
>> "save"
>
> No I meant safe, but let me rephrase it, Swap does both save and
> restore. But it's not safe to dereference a NULL pointer :)
>
>  .... makes the swap only handle the host state. Exclude PKRU from restore as

Gah. I should have looked at the context first. "save" is correct
here. Oh well...