Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Oct 2021 17:15:02 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     James Clark <james.clark@arm.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        kajoljain <kjain@linux.ibm.com>
CC:     john.garry@huawei.com, ak@linux.intel.com,
        linux-perf-users@vger.kernel.org, Nick.Forrington@arm.com,
        Andrew.Kilroy@arm.com, Will Deacon <will@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] perf tools: Enable strict JSON parsing
User-Agent: K-9 Mail for Android
In-Reply-To: <0d73d04f-925c-4c97-9a07-18cc64a9c68b@arm.com>
References: <20211007110543.564963-1-james.clark@arm.com> <c15fd2bf-104e-6ab0-6496-7e5cf77a218f@linux.ibm.com> <e8752b2d-65a7-1ed8-3c68-30d9006261ba@arm.com> <5947c093-cff9-f70e-af20-75bc053edf5f@linux.ibm.com> <YWCVTnOUM2P4FRPi@kernel.org> <0d73d04f-925c-4c97-9a07-18cc64a9c68b@arm.com>
Message-ID: <5DAE78A9-A1A8-48B9-B5A6-35172C3A2BC8@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On October 12, 2021 10:30:51 AM GMT-03:00, James Clark <james=2Eclark@arm=
=2Ecom> wrote:
>
>
>On 08/10/2021 20:00, Arnaldo Carvalho de Melo wrote:
>> Em Fri, Oct 08, 2021 at 04:56:55PM +0530, kajoljain escreveu:
>>>
>>>
>>> On 10/8/21 3:32 PM, James Clark wrote:
>>>>
>>>>
>>>> On 08/10/2021 08:43, kajoljain wrote:
>>>>>
>>>>>
>>>>> On 10/7/21 4:35 PM, James Clark wrote:
>>>>>> After a discussion on "[PATCH 1/4] perf vendor events: Syntax corre=
ctions in Neoverse N1 json",
>>>>>> John Garry suggested that we can just modify the parser to make it =
more strict=2E Hopefully this will
>>>>>> remove the need to apply any future JSON comma fixup commits=2E
>>>>>>
>>>>>> Applies on top of "[PATCH v2 1/3] perf vendor events: Syntax correc=
tions in Neoverse N1 json" on
>>>>>> perf/core=2E
>>>>>>
>>>>>> Also available at:
>>>>>>   git clone --branch james-json-parse-fix git@git=2Egitlab=2Earm=2E=
com:linux-arm/linux-jc=2Egit
>>>>>
>>>>> Hi James,
>>>>>    Do we have any dependency patches on top of this patch series=2E =
I am
>>>>> reviewing and testing it, but in both powerpc and x86 system I am
>>>>> getting build issue=2E Not sure if I am missing something>=20
>>>>> I am trying your changes on top of upstream perf=2E
>>>>>
>>>>> pmu-events/arch/test/test_soc/sys/uncore=2Ejson: json error Invalid
>>>>> character inside JSON string
>>>>
>>>> Hi Kajol,
>>>>
>>>> A trailing comma was fixed in this file 3 weeks ago at b8b350a=2E Can=
 you
>>>> confirm if you have updated to get this commit on perf core?
>>>>
>>>> Alternately you could pull from my branch above which is up to date e=
nough
>>>> to include it=2E
>>>
>>> Hi James,
>>>    Thanks for pointing it=2E Not getting build issue now=2E
>>>>
>>>> The file is in pmu-events/arch/test/ so I would expect it to fail on =
all platforms=2E
>>>>
>>>>> make[3]: *** [pmu-events/Build:18: pmu-events/pmu-events=2Ec] Error =
1
>>>>> make[3]: *** Deleting file 'pmu-events/pmu-events=2Ec'
>>>>> make[2]: *** [Makefile=2Eperf:667: pmu-events/pmu-events-in=2Eo] Err=
or 2
>>>>> make[2]: *** Waiting for unfinished jobs=2E=2E=2E=2E
>>>>> make[1]: *** [Makefile=2Eperf:238: sub-make] Error 2
>>>>> make: *** [Makefile:70: all] Error 2
>>>>>
>>>>> Also, Is it possible to add line number along with file name while
>>>>> showing this error `json error Invalid character inside JSON string`=
=2E
>>>>> It might make it easy to fix=2E
>>>>
>>>> I can add a character number with the following fix if you think that=
 would
>>>> be good enough? A line number might be a bigger change and involve ke=
eping
>>>> track of newline characters=2E
>>>
>>> Sure=2E I think then we can skip this change=2E Not sure if character
>>> number will be helpful=2E
>>>
>>> Patch-set looks good to me=2E
>>>
>>> Reviewed-by Kajol Jain<kjain@linux=2Eibm=2Ecom>
>>=20
>> Applied ok as-is to my perf/core branch, applied and added your
>> Reviewed-by, thanks=2E
>>=20
>
>Thanks Arnaldo=2E This does mean that the arm64 build will fail until
>"[PATCH v2 1/3] perf vendor events: Syntax corrections in Neoverse N1 jso=
n" is
>applied=2E I think there is also an arm64 build issue with "[PATCH 02/21]=
 perf
>pmu: Add const to pmu_events_map=2E" which Andrew Kilroy has replied to=
=2E
>

Ok, this will hopefully change tomorrow after today's Brazilian holiday wh=
en I get to process that series,

Thanks,

- Arnaldo