Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Bodo Stroesser <bostroesser@gmail.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] scsi: target: tcmu: Use struct_size() helper in kmalloc()
Date:   Tue, 12 Oct 2021 16:35:10 -0400
Message-Id: <163407081304.28503.15090852418195618906.b4-ty@oracle.com>
In-Reply-To: <20210927224344.GA190701@embeddedor>
References: <20210927224344.GA190701@embeddedor>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXBRUUZvY1hkSy9lZEptak80SXJPNTlmb2pNdndKTVhlZmkzQ2Q1Smc2Y3Bt?=
 =?utf-8?B?Y1RteGFadlZEdURaSC9WMnpDK3JUM2dzMTM0RmtQbzk0U0tKN1dDUEdKTTdz?=
 =?utf-8?B?Y1c2bFRkMHBCOTJZeGpNcGNzVVlxcVJLME5nRXQ2aTl3elBnSEIrYzRLZXhz?=
 =?utf-8?B?cnI5MWRsb2J4Wnh0dks5KzFFNkZ5aDR3bFRDTjNldVpOU3NrSnNkNHRVWjlv?=
 =?utf-8?B?QmZPNWJnTk44MzJQNy9tYXVSdUFvZ1ZwcisyZkNya0I1Tk4wcFRFNENvZWVD?=
 =?utf-8?B?MEtKYnU2dG45ZU9zMDNpeVlhNTVpZGRkdjN0bTBRS1dDYkxPV21jYWpwY08y?=
 =?utf-8?B?MmJ6VlRmeCtQUGxZa1hGbG95b2krb1Z2dXV5Z016eWVnaEplNTlCaXh5VlNh?=
 =?utf-8?B?czdSRldzUzJlOFU5ZWZMOCtjUnIvVkNwM0FiYm5ncmNNOUJrK0NhZzZyVWJ1?=
 =?utf-8?B?RWdZL2M1WlorT1kwamtJMGtjUUllVW5jdUZQWjI1U0FoNFFMYVV1bzJPemll?=
 =?utf-8?B?NUkwU0ZzN3ZxdXQ3b2Z1WjdVZjc1VmZYbGUwNTZoVlA1N0NMM056cS9tVGx5?=
 =?utf-8?B?azVvZ0thYWpTVVRNVlA2WDJmWTlSRElodTh1eDJiK0hCSExraHE1cEhaTnY5?=
 =?utf-8?B?R253U0g2KzJaSE9yaTdOTnRXQnM0S0JSaXM5UnJpUUZOU1NYRTBCSlRzdHBD?=
 =?utf-8?B?YytJQXZDSStsUHFEY1g1eWVva3Bvd0J4YmhreXNvN3RuSHRRRU1tVC9HeUhB?=
 =?utf-8?B?NjNQV0dxUVA2bk1NenNrbURsNUdPR3ZrTElnRWhuWTlKTXRGRjNKMWdxekJF?=
 =?utf-8?B?aVZJdE54UU5MeXBMZWt1U1N3a3VIUkRLTlRZTllTbWtsekdHSnIzdDFySXhv?=
 =?utf-8?B?NTZybUxPUWlJNm1jeXJmSkdXS2liV0M5eG0wYXovQ01mb0ZOV3FxeUYvTFIz?=
 =?utf-8?B?SzhPRG81ekMzdXVhY2lrek16aklVVllNTEQ4c3hPOU1jaHFjVDI2YnpES244?=
 =?utf-8?B?ODZyL2ZKTzBKbkRIVkx2RjBpWmIvWnlaczM2aFEwMWU1ZFBVYkZEUFphTUVq?=
 =?utf-8?B?UWtoUVVPV0xrVGFvVFowMDZ2dmVFWlBuWjhKRkp5cnpQSlJENjFiYmZrd2hx?=
 =?utf-8?B?TEhiWFVTN0J3Y1VBL2NabjhheG5YNXFRNTJqb0lwWm9hTmluV202SXN6ZjV6?=
 =?utf-8?B?S0ZLcUNhbURrV0pvTXorL0tvNndnNkN6NDZvcEhxejJGT29GWnJJWVlFNGQx?=
 =?utf-8?B?NnNIQklnSGhsRFdEUmZoMzlHdEltZlZtVHcxalgrYmV3UlB2N3BlMDh3Znp0?=
 =?utf-8?B?K05xWW1JeEVCTU4yeEhCNlgzV3U4NytqcG5ucHo1cStsNGJ4VS9TcUZqUERD?=
 =?utf-8?B?b2FNRUFxLzR0SzVHREgvUkMvRzMyRFJwZnNtenhha00wbXYwdzJZMnBYYlRt?=
 =?utf-8?B?aUVWaUxxMGd2b0pBbGRmdVg1U3hRWkJPZ2FpZGlkMnpTUGowNUhPeGxxSjJC?=
 =?utf-8?B?eUFtVm1CNWVtYnVBVE83WFVVZjN1N1JoRXdlemllcjRjblNCZG5zT2lCTW1U?=
 =?utf-8?B?UjFSS0gvTmJwdDMvRnpGUm1tYWR1K3BaYTJzeXFJWG93S0loU05SbmV2THUr?=
 =?utf-8?B?V00zazZvWitsWWRZOTlSTE1HeHRkc21WUGd3QXFHVkhBM2lEMWRZVjg1TWto?=
 =?utf-8?B?NFUwK2RBcWxsUEgyL1ZyOGozYVdUdWhGOTU5d1ZjRkxXNDhuZWYwNUtwdUdE?=
 =?utf-8?Q?IyOmxkpLNiaJooa4RhIikitEuhOcmSTLFEQeonv?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac278099-7470-4852-7bf0-08d98dbfd3ac
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 20:35:28.0974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Rxu7QZMPpS85i36Zior/t+bSsBIOgcKv+6NlcOojKHNIpVt9nXu9cDNhgafhM3sWFNh6CcfNcSBbvrebCInmvjklvfOum/biio132bL8+o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5514
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=825
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120109
X-Proofpoint-GUID: 7EWBxQIPWSzovIgItMUGkuXD4TZmePON
X-Proofpoint-ORIG-GUID: 7EWBxQIPWSzovIgItMUGkuXD4TZmePON
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Sep 2021 17:43:44 -0500, Gustavo A. R. Silva wrote:

> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows
> that, in the worst scenario, could lead to heap overflows.
> 
> 

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: target: tcmu: Use struct_size() helper in kmalloc()
      https://git.kernel.org/mkp/scsi/c/c20bda341946

-- 
Martin K. Petersen	Oracle Linux Engineering