Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211012133334.1737918-1-kherbst@redhat.com>
In-Reply-To: <20211012133334.1737918-1-kherbst@redhat.com>
From:   Ben Skeggs <skeggsb@gmail.com>
Date:   Wed, 13 Oct 2021 08:02:58 +1000
Message-ID: <CACAvsv47Xn07zM8pSqAAbTktjySaBeW_swrZAGjrfAVUnzdHzw@mail.gmail.com>
Subject: Re: [Nouveau] [PATCH] drm/nouveau/mmu/gp100: remove unused variable
To:     Karol Herbst <kherbst@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        DRI <dri-devel@lists.freedesktop.org>,
        ML nouveau <nouveau@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 12 Oct 2021 at 23:33, Karol Herbst <kherbst@redhat.com> wrote:
>
> Fixes a compilation issue introduced because I forgot to test with WERROR
> enabled.
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: DRI <dri-devel@lists.freedesktop.org>
> Cc: nouveau@lists.freedesktop.org
> Fixes: 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.")
> Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>

> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> index 2b21f43069aa..17899fc95b2d 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> @@ -488,7 +488,7 @@ gp100_vmm_fault_cancel(struct nvkm_vmm *vmm, void *argv, u32 argc)
>                 struct gp100_vmm_fault_cancel_v0 v0;
>         } *args = argv;
>         int ret = -ENOSYS;
> -       u32 inst, aper;
> +       u32 aper;
>
>         if ((ret = nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false)))
>                 return ret;
> --
> 2.31.1
>