Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Oct 2021 20:01:06 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Andrew Halaney <ahalaney@redhat.com>
Cc:     akpm@linux-foundation.org, bp@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: Make unknown command line param message clearer
Message-ID: <20211012200106.1afdbb0b@gandalf.local.home>
In-Reply-To: <20211012213523.39801-1-ahalaney@redhat.com>
References: <20211012213523.39801-1-ahalaney@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 12 Oct 2021 16:35:23 -0500
Andrew Halaney <ahalaney@redhat.com> wrote:

> --- a/init/main.c
> +++ b/init/main.c
> @@ -925,6 +925,10 @@ static void __init print_unknown_bootoptions(void)
>  	for (p = &envp_init[2]; *p; p++)
>  		end += sprintf(end, " %s", *p);
>  
> +	pr_notice("The kernel command line has unknown parameters. They are either\n");
> +	pr_notice("misspelled, not valid for the current kernel configuration,\n");
> +	pr_notice("or are meant for init but are not after the '--' delineator. They will\n");
> +	pr_notice("be passed to init along with those after '--' on the command line.\n");
>  	pr_notice("Unknown command line parameters:%s\n", unknown_options);
>  	memblock_free(unknown_options, len);

What about just changing it to simply say:

	pr_notice("Unknown kernel command line parameters "%s", will be	passed to user space.\n",
		  unknown_options);

-- Steve