Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] init: Make unknown command line param message clearer
To:     Steven Rostedt <rostedt@goodmis.org>,
        Andrew Halaney <ahalaney@redhat.com>
Cc:     akpm@linux-foundation.org, bp@suse.de, linux-kernel@vger.kernel.org
References: <20211012213523.39801-1-ahalaney@redhat.com>
 <20211012200106.1afdbb0b@gandalf.local.home>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <87853d4f-d6f8-1d58-1a07-c8232dae87fd@infradead.org>
Date:   Tue, 12 Oct 2021 17:18:32 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211012200106.1afdbb0b@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/12/21 5:01 PM, Steven Rostedt wrote:
> On Tue, 12 Oct 2021 16:35:23 -0500
> Andrew Halaney <ahalaney@redhat.com> wrote:
> 
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -925,6 +925,10 @@ static void __init print_unknown_bootoptions(void)
>>   	for (p = &envp_init[2]; *p; p++)
>>   		end += sprintf(end, " %s", *p);
>>   
>> +	pr_notice("The kernel command line has unknown parameters. They are either\n");
>> +	pr_notice("misspelled, not valid for the current kernel configuration,\n");
>> +	pr_notice("or are meant for init but are not after the '--' delineator. They will\n");
>> +	pr_notice("be passed to init along with those after '--' on the command line.\n");
>>   	pr_notice("Unknown command line parameters:%s\n", unknown_options);
>>   	memblock_free(unknown_options, len);
> 
> What about just changing it to simply say:
> 
> 	pr_notice("Unknown kernel command line parameters "%s", will be	passed to user space.\n",
> 		  unknown_options);
> 

Yes, that's much more palatable.

thanks.
-- 
~Randy