Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC 04/16] KVM: selftests: set CPUID before setting sregs in
 vcpu creation
To:     Michael Roth <michael.roth@amd.com>,
        linux-kselftest@vger.kernel.org
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org,
        Nathan Tempelman <natet@google.com>,
        Marc Orr <marcorr@google.com>,
        Steve Rutherford <srutherford@google.com>,
        Sean Christopherson <seanjc@google.com>,
        Mingwei Zhang <mizhang@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Varad Gautam <varad.gautam@suse.com>,
        Shuah Khan <shuah@kernel.org>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Ricardo Koller <ricarkol@google.com>,
        Jim Mattson <jmattson@google.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>
References: <20211005234459.430873-1-michael.roth@amd.com>
 <20211006203617.13045-1-michael.roth@amd.com>
From:   Krish Sadhukhan <krish.sadhukhan@oracle.com>
Message-ID: <29aa85d5-fcc7-bf25-dd04-2476dc7b6241@oracle.com>
Date:   Tue, 12 Oct 2021 18:45:09 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
In-Reply-To: <20211006203617.13045-1-michael.roth@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkFxaW5PWmtHWnIzcXRic0t5QW5yOU1rcCt0RDdaMDZvNkorWnQzMXJDaldz?=
 =?utf-8?B?dys1dHNqSkhCMjdrOGU5ZFBiZnZRTkFqemZqMzBDSVNRSFM4dWJtd2ZoU1hp?=
 =?utf-8?B?UDFhci9FdGIxZm5CZHNhOW0vOTdoaDRKOWo3VzdoeFBEWThmVEt3MXlVVWRS?=
 =?utf-8?B?aEJHY0dTTWhZM2RVeFptZUQ4WXArY2l3dktrM2R4NVRxdHM5NjNGSGQrUVhm?=
 =?utf-8?B?VG1aWHh2Q290blk5SjlCSW1kOHVZOWpuTW0vU0JiR0c3QU5XL2piUzFvaVQ1?=
 =?utf-8?B?SHNjck5FU1NvWCtyU2Zxb1lVSUUrYXc4eGd0YnNnWXdtUnUrRUxIK0FxZVFF?=
 =?utf-8?B?L1dYV2swRHl0S0diUTQyU2FTTXhRckpFQ0Frd2FTYVVweFMvYjZKMTZpNlBm?=
 =?utf-8?B?UURYTU9YQmEvMklEa0tEMXUrVXdUWnlwS2pPVis0U0I0dDNWWFNzbG02Ym4v?=
 =?utf-8?B?S2JOQnVGVDhVbk0ySkxDRWVtS3R3c3VtU3ZCMEtkRzdkN0szcEdGQWlXS2FW?=
 =?utf-8?B?Q0EvNTcrem1YVFM3YkZOWmtMY3lzeWc3Y2hqTTRLMDVnYnZ5a3BLZ2hmQVFF?=
 =?utf-8?B?ZWo3R1ppa25VeHdldXNJaU9qeWorTC92cDcwVTFCZXppOUdKbitEQ3ZDYzFX?=
 =?utf-8?B?UE1udTEycHRJL0ZnanAzbWRNMFhwZzNzcVUva1dsNTJJeTJXTzkyNlQybGZp?=
 =?utf-8?B?Z2daL0tpUVRseEh5TkJSWCtxNUVTdDIzWUV5S2xSMlpTditnd1JhMm1rbHFW?=
 =?utf-8?B?Z0p3ZFg2cVdaYkY0VG96Q0xoUFdnVXpBOWVDWE1uc01ad3RjUUM0YjdlaTMw?=
 =?utf-8?B?ZGhjeS9uL1lJaHd0T2VTTDluV1pQZkU1YU9DSDhJdzhQS1VWRmFodk5XQkpZ?=
 =?utf-8?B?WnprN2crczU3QVZyNE1pT2ZrV1NUV2J2TnBxYzVodkgxcHJhYklpQXV6b2p2?=
 =?utf-8?B?MnBNU05JSkZhOWcyR0JMV2xVaW1qUHJGQmNadHNSYldHaDRYdzlQNFRKWm9D?=
 =?utf-8?B?RGlRR2VtQ1hqbVlGaGZrWEJtakdqTDNDenRJdHM1UjF6a3JDUVg4TFhXYU1q?=
 =?utf-8?B?bWFIZ0VaTVNUYVZWNEEwWmxrNDlJOGFFRXNBSC9wUkFDOGZUY0hPZkRzQWl1?=
 =?utf-8?B?bDNzVisvK3BkS1piS0hmc1BrTnZ0MDdWeEt0YnRnTHN5K1MzTHc2VStDMnZT?=
 =?utf-8?B?eEV0NDdieWc1TEVxNVRTbWFibC8wZlZuZVY0dDRmSjYvcTJ2VS9RK1pqM0dp?=
 =?utf-8?B?OEgreWp2QURsVWZiZTJya2lWMVEzQ2o5ZElRZGJLQW9Ba3orMEE3VXhCaUVM?=
 =?utf-8?B?NURSNUNJd3FWMjNjNC9YVllXTG13M3BPTysvY1hBemIwbkVBS0w1ak9tNW9s?=
 =?utf-8?B?U2hYYU00cStpQm5XUWdSbG95d3hxWVFWTVF4cHN2aVhER0ZCUzQ1Y2plaHJI?=
 =?utf-8?B?RU1NMnBHamwzVUEzUUMrQTN0VVI3bnc0b1E0YUxnVGFxN2dCaTZXYTh0M2t6?=
 =?utf-8?B?SVdxNXVSaHFnVytHWmFic3J6RjcxeUNwTzN3aWJBQVNWQU52aEVlbVpTbFd4?=
 =?utf-8?B?WDZ0TzZQRFJNMkF1cWNOSzdMMWhpeXBIUEUwOUxmTnN2UHkzM0U2djlncU8x?=
 =?utf-8?B?OUJ4cCtKT2pKSzJjVVJyMHVPWVNscDhaSG16T1pEeEtKcnNzajlCSFZob0w4?=
 =?utf-8?B?bmpxbHNCK3FnY2JjRHBtWmc4czFBdGhRVDZmV3BFdHJmT09PWURWMW5aMkw0?=
 =?utf-8?B?WHFQWEwyV2duUEZteFJhdHdIVHdkVVFlWmlqNm52TzRNTTBQYjk1Z0hvVThP?=
 =?utf-8?B?RUwrSmFOdlYweExHbzBMdz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73d1d21f-5576-4308-5268-08d98deb19a6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3021.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 01:45:13.8416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2A8TeKK1Bz+i8zWFQm7dIVCwvax2iztPGxOeKj1dXSkJRhp92vnOQQx4dGGJA9ws/s+Q38kyR/D8Xbe0YY504+56XodJHArS6ZcmtNDzczM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2910
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=787
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110130008
X-Proofpoint-ORIG-GUID: uTf5vghR-yLHGzL-fJGQiCONy-bxlNc3
X-Proofpoint-GUID: uTf5vghR-yLHGzL-fJGQiCONy-bxlNc3
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/6/21 1:36 PM, Michael Roth wrote:
> KVM_SET_CPUID*, but kselftests currently call KVM_SET_SREGS as part of
> vm_vcpu_add_default(),*prior*  to vCPU creation, so there's no
> opportunity to call KVM_SET_CPUID* in advance. As a result,
In the current code, I see that KVM_SET_SREGS is called by vcpu_setup() 
which is called after vm_vcpu_add() that calls KVM_CREATE_VCPU. Since 
you mentioned "prior", I wanted to check if the wording was wrong or if 
I missed something.