Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Oct 2021 19:34:25 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Input: ep93xx_keypad - switch to using managed
 resources
Message-ID: <YWZFsZmPBp6Hj2Yf@google.com>
References: <20211012013735.3523140-1-dmitry.torokhov@gmail.com>
 <20211012013735.3523140-4-dmitry.torokhov@gmail.com>
 <d1d1a1028c5db26d0b0eed2a5a9626124451fcf9.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d1d1a1028c5db26d0b0eed2a5a9626124451fcf9.camel@gmail.com>
Precedence: bulk

On Tue, Oct 12, 2021 at 09:54:32AM +0200, Alexander Sverdlin wrote:
> Hello Dmitry,
> 
> just one question below:
> 
> On Mon, 2021-10-11 at 18:37 -0700, Dmitry Torokhov wrote:
> > +???????????????return err;
> > +
> > +???????err = devm_add_action_or_reset(&pdev->dev,
> > +????????????????????????????????????? ep93xx_keypad_release_gpio_action, pdev);
> > +???????if (err)
> > +???????????????return err;
> > ?
> > ????????keypad->clk = clk_get(&pdev->dev, NULL);
> 
> Isn't the conversion to devm_clk_get() missing here?

Indeed it is. I'll post an updated patch in a sec.

> 
> > -???????if (IS_ERR(keypad->clk)) {
> > -???????????????err = PTR_ERR(keypad->clk);
> > -???????????????goto failed_free_gpio;
> > -???????}
> > +???????if (IS_ERR(keypad->clk))
> > +???????????????return PTR_ERR(keypad->clk);

Thanks.

-- 
Dmitry