Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3052524pxb; Tue, 12 Oct 2021 20:12:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXfcccxtHxup8hIQomofKkjDEd1+YclOH+abtTR4PY5eNf2ZeykOT2NSMTR+TYypBMBoxQ X-Received: by 2002:a05:6402:348d:: with SMTP id v13mr5603574edc.102.1634094774469; Tue, 12 Oct 2021 20:12:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634094774; cv=none; d=google.com; s=arc-20160816; b=UwD5482WBpd2C3a32spehdRXicV977X7+Q0TufkfpofFFrY17qC9jzCD/y764ZMQXM g07xm7YdblTrcWKIOrUjB2R/L7CiLg6vX4P73HoFU5Dein/XcMiwhM7ML668jDq4Lup9 zUnHcixcVAGgww+hnQSawD2RXtlEt6usuMsLL55E4HjQqtmrQqm7iiUseortDYszymto ZuzP7zn7viELme1p6srQ7+22KmsLIKygphu3DBChnuJufUUKRUsZiBNTtxhKKa/sQw4U elcOsXeWF5Y3oVJHirwK/EmTJrq1N6teIZkA40g5P6d97XwrX3G+xda79W5gGJ67pftS L7JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hF50jopThZcpb/r5CrV+DzJwIbUB5o6C3T/+nzD13DY=; b=r+DcTABY8uew+Di+Yny6CpvrkD+C3CnpZ21K10wuRCiG9pS4lGfoxZlg0jIaJE6iH4 5EowDZ5fR4O5N6jMzgvAQzsrJ5pA4WrnqTTNqW1qoEZ8vRKMmnXnx0kvbRZ/qT2f+dMa h0jQQKVOfEsXz2QVtomBcXSvTsX2oW8OSQz6IIK81V8w6w+7VROk3KQN8nzwhpcJmrQ7 oXoYw6zFsm+dgG/pqbBcFXPv+SpJb5YuXXLnzU+qWZdt9yl6AByZZPf+H347n0I8/Kk1 Ch5yZBF2+1BuMo6IV6sIoYsKoofyPK3nxZBga+gl2OFw8uJIA/J9yPCAfCQtYGj/BgMr rwag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JOc3Vzh7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si20604923eje.551.2021.10.12.20.12.31; Tue, 12 Oct 2021 20:12:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JOc3Vzh7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237207AbhJMDMs (ORCPT + 99 others); Tue, 12 Oct 2021 23:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237084AbhJMDMr (ORCPT ); Tue, 12 Oct 2021 23:12:47 -0400 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3872C061570 for ; Tue, 12 Oct 2021 20:10:44 -0700 (PDT) Received: by mail-qv1-xf2a.google.com with SMTP id z15so886858qvj.7 for ; Tue, 12 Oct 2021 20:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hF50jopThZcpb/r5CrV+DzJwIbUB5o6C3T/+nzD13DY=; b=JOc3Vzh7ZX1SboeRVjFtkEYohl4iZaI9Du8OEaD7eLsyeDWkakksUsYD2pY3gDE8rF vgoZQQDPYbe+acZsBZWgUDgX38DIQipV20UhBW+rvR8JWBocjTKY/WE4DI18jnLNH44D W4/ocbVJ//IM6nQ2H6MoRG0e/meXVS+FXfbKfgO22rTwVpbs+PbyUIuR8GoKU78T+m1H X9FjNCaevr/+tKl4oqJagKL2fwqJE1XHv6fI3gAKL84rEBazL8fcxS492aST5ksqY6mf m+y5tXGRL1EpdusgQbcWqaZN4cZ8QgHZaL02Lf1JaJ5+T0oQe7srpeW753zy4Se1/n/6 jgWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hF50jopThZcpb/r5CrV+DzJwIbUB5o6C3T/+nzD13DY=; b=AtI0ogj35bX/j7+gWMTJ+as/9N6hBmUU3NnzNIjFJUm83EWbFo0zzBWafdnRWfHrUS uRsHuX4LuvuBPDGYoS/wbiXYX1vHljqidZNwkMdN/jeLzgVj5bsK1Sdw4cVHF478yVwD TxIAhElRGV3MXPiq6PWLfpPBbX/AYe7Fu3chWUiKjKRdepSm5DQtVODMs37g2qOxO52d yWRp8bwrb7NRmrCu8sBYSAyH3XiTL9W2BvGZwOdLFEOp1o02thInLN0SkjDxHGXIf8Ys zDHWNX1ll0cmWjQ/8sl3ZFLMHgHVZxNwgnKb80k8FJDmY0ql24Lsv/bu+JWVVwF/d5pH JrcQ== X-Gm-Message-State: AOAM532XZcEy6MAVFG3GlbjpgugVJCwm2eTx381iSY9JyH2841yR+9l+ pNE4CEsKM0g/X3aXKC+AknzgK4u3cvzoS/q5fTY= X-Received: by 2002:a05:6214:154d:: with SMTP id t13mr29391720qvw.40.1634094643983; Tue, 12 Oct 2021 20:10:43 -0700 (PDT) MIME-Version: 1.0 References: <1634036070-2671-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Wed, 13 Oct 2021 11:10:33 +0800 Message-ID: Subject: Re: [RESEND PATCH] ASoC: wm8960: Fix clock configuration on slave mode To: Mark Brown Cc: Shengjiu Wang , alsa-devel@alsa-project.org, Charles Keepax , Kuninori Morimoto , patches@opensource.cirrus.com, Takashi Iwai , Liam Girdwood , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 12, 2021 at 7:26 PM Mark Brown wrote: > > On Tue, Oct 12, 2021 at 06:54:30PM +0800, Shengjiu Wang wrote: > > There is a noise issue for 8kHz sample rate on slave mode. > > Compared with master mode, the difference is the DACDIV > > setting, after correcting the DACDIV, the noise is gone. > > Charles suggested some updates to the patch to improve the error > reporting here which you don't seem to have addressed. Sorry, it seems his mail is missing from gmail. I find it in my outlook now. Let me check his comments. Best regards Wang Shengjiu