Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq
To:     Stephen Boyd <sboyd@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
        Abhijeet Dharmapurikar <adharmap@codeaurora.org>
References: <1631860384-26608-1-git-send-email-quic_fenglinw@quicinc.com>
 <1631860384-26608-2-git-send-email-quic_fenglinw@quicinc.com>
 <163406078422.936959.12726677103787301939@swboyd.mtv.corp.google.com>
From:   Fenglin Wu <quic_fenglinw@quicinc.com>
Message-ID: <6c91a6ad-0ff2-a431-138a-2ec83f2bfa74@quicinc.com>
Date:   Wed, 13 Oct 2021 12:15:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <163406078422.936959.12726677103787301939@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 10/13/2021 1:46 AM, Stephen Boyd wrote:
> Quoting Fenglin Wu (2021-09-16 23:32:56)
>> From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
>>
>> The cleanup_irq() was meant to clear and mask interrupts that were
>> left enabled in the hardware but there was no interrupt handler
>> registered for it. Add an error print when it gets invoked.
> Why? Don't we get the genirq spurious irq message in this scenario?

Thanks for reviewing the change.

No, there is no existing message printed out in this special case ( IRQ 
fired for not registered interrupt).

>> Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
>> Signed-off-by: David Collins <collinsd@codeaurora.org>
>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>