Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iio: imx8qxp-adc: Fix the error - defined but not used
 for runtime pm API
To:     Cai Huoqing <caihuoqing@baidu.com>, jic23@kernel.org,
        lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com
Cc:     linux-imx@nxp.com, linux-iio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20211013014658.2798-1-caihuoqing@baidu.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <41381e8c-78f2-67ee-5ed0-dcf176f65da1@infradead.org>
Date:   Tue, 12 Oct 2021 21:31:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211013014658.2798-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/12/21 6:46 PM, Cai Huoqing wrote:
> Add the prefix '__maybe_unused' to imx8qxp_adc_runtime_suspend/resume()
> to avoid the compiler complain without setting CONFIG_SUSPEND,
> CONFIG_HIBERNATION and CONFIG_PM.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>   drivers/iio/adc/imx8qxp-adc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
> index 5030e0d8318d..011bef4b5dda 100644
> --- a/drivers/iio/adc/imx8qxp-adc.c
> +++ b/drivers/iio/adc/imx8qxp-adc.c
> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
> +static int __maybe_unused imx8qxp_adc_runtime_suspend(struct device *dev)
>   {
>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>   	struct imx8qxp_adc *adc = iio_priv(indio_dev);
> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int imx8qxp_adc_runtime_resume(struct device *dev)
> +static int __maybe_unused imx8qxp_adc_runtime_resume(struct device *dev)
>   {
>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>   	struct imx8qxp_adc *adc = iio_priv(indio_dev);
> 


-- 
~Randy