Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Oct 2021 09:15:47 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Joe Perches <joe@perches.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: Use of '%#02x' is almost always wrong
Message-ID: <20211013061547.GG8429@kadam>
References: <b04a10ea9682c51764053c1be73d4b3be59d1e7f.camel@perches.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b04a10ea9682c51764053c1be73d4b3be59d1e7f.camel@perches.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nbHXOJ+wro2ZPURFIWQb6hp57N26Kl6RftEV++vTwAo3JF/vSm+KJzNLXWlL?=
 =?us-ascii?Q?kY359xsUD8BpOQzrmvWq1yjnad5QCdm8hFCZWVuokS+VXH7m/C+T4Zk+QyBu?=
 =?us-ascii?Q?nl9btvl1a4B1MGDiGqH2cbwga+J0jOWkvvDdLkybdnTPPvXK3/SKt9bwDLFs?=
 =?us-ascii?Q?SrqZ7hRKrgPm0spEwlDnQHi6JhsNJYwfbzqd6niL+7MnroeAhd3x10GhjuuZ?=
 =?us-ascii?Q?+0zBTNnazrSADqWuk9/Jyc/8B+oH4kiwevzPpa80/yPZU2KxspbYuUBfpsmC?=
 =?us-ascii?Q?0CFjceqGh6Cp/MXb7ZraDnw9CBIUNmCttMM4n143qd+wfQVqjYlKaGrXYQ3h?=
 =?us-ascii?Q?By9hsbuupp7awEykdbp5zAGWiRlV6DCJovV8qxfuCmLOeNheH1a0/5C4xOj9?=
 =?us-ascii?Q?UB4bJG2ez79+DOjSoaSKpoPeBqYgJIT8eK31TGAYpxCh6Rwf2lPuO6Xc1jeS?=
 =?us-ascii?Q?14/W4oT2CQkGD0MLksqJprHx9LMr/f/pRAZq8gJegpgR6Etsg0pym9S7pIH+?=
 =?us-ascii?Q?vDKAvAw4CKW7NqZpuLSXoJ+3QJVKEtPtzHeL1zjMUDDGa6ULZYNJePmUoO2G?=
 =?us-ascii?Q?zbVSmTix4l01LE9EQMQNrLZE3RKC4hVNPXDsMvDhuovyQ5zZTmaolySyAgIW?=
 =?us-ascii?Q?EUxgAjob/Q8WYniFjQ0oj7b/LJ8MPxNM9t29uzC+SHx2v/k+6hjTHsT/6PQ1?=
 =?us-ascii?Q?EFBoxTloJusuOCRissv3Qs9KjWmV+qGY7aSfV007tvFUE088a71HNNaMbWqW?=
 =?us-ascii?Q?IjoLvbiDvPNhyS6CNzaOWzt2unOFoEw1w2UaHBABgvPY4TUUtu+8IGcsQ5AP?=
 =?us-ascii?Q?ow4kw/XMGVdw+0Z92DXgLm9Ru0xbHRNfF7oR+w4xAjm0s9lb0oaoy8J5/ag9?=
 =?us-ascii?Q?gUbFh0gAndv1vJuOYxxW1b6GXvMMTQEqd76vnWbfVIFMsu0e/yikAib3vrg3?=
 =?us-ascii?Q?mlnO5JUr/zPjnKY4BlwQOftcSNwqN1iIcWKvs13tGiNpPud05mfmn0Ezay1r?=
 =?us-ascii?Q?P4LFAzBKtn7KSeBb0m4tNT9C/XFAeA8lXlmy6S1JG58WblR90nUQFRFYc5hN?=
 =?us-ascii?Q?v35zjg0Bi+2qfg5sMQOLNfCC+nr3Pjm9MjvQc0wBMeRmD227aUEy6vBohUZu?=
 =?us-ascii?Q?yaGqmNFyic1d5FDEAvmbPAa9pO2t9KZBOnJCreSTVkHl3y3ETnIGroCs8fpQ?=
 =?us-ascii?Q?jxro0SW6VoVGw2YFvbQ9szoE3f6RLmr6Uiw5udXOSLVs8qGUZNngM3N47mDT?=
 =?us-ascii?Q?NI++My0JonPlZLPKL/sSLIrZibMSLkIAoX/ccWo2VLxrU0fEHRYJAj86n6OV?=
 =?us-ascii?Q?K6AyzVzaeKKBb0FusumHoDX5?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 522b0972-1f3d-446f-0755-08d98e10ef00
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 06:16:03.3601
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: csG9ibNITAKQkrgF7yFpK6eR1K6PLjlzgYYZh7S8rl6pWc8rTeirwtQKNV6BUDLvyBY465bMQ1vVM0PAg7IT1GjuYYTn9chPc0Aometmulo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2253
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=663
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110130042
X-Proofpoint-ORIG-GUID: FUWAIN3or_sfRkpBRw6qR_3a_D5psJTP
X-Proofpoint-GUID: FUWAIN3or_sfRkpBRw6qR_3a_D5psJTP
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 10, 2021 at 09:45:30AM -0700, Joe Perches wrote:
> Perhaps too many developers do not know that using '%#<width>x'
> in printf output _includes_ the 0x prefix in the output width.
> 

This is a good point.  Presumably you're going to add it to checkpatch.pl?

I looked at '%#04x' and you would think those would all be printing char
types but some are printing shorts.  :/  It's harder to deal with that
because 50% are correct from the tiny sample I looked at.

regards,
dan carpenter