Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy
Date:   Wed, 13 Oct 2021 02:34:41 -0400
Message-Id: <20211013063441.29888-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OryUusFxuAWee4WwT/tC54SipZcjyQ8UQPa8MGkeek7xtRzZKMyvGtGLtvNt?=
 =?us-ascii?Q?eFSXOHCSl4aBgGDo0QWNYxoCPvr46BI+IgMMEK0SMm1+H6Mkbpb4UAZ2XPIl?=
 =?us-ascii?Q?GGsKXI1TJmkuQ6EHDcOBGGSZiaKVrsn80CsT/+3ZPjOZtUwp1VJTHLRlz1eB?=
 =?us-ascii?Q?CHjtqfJKSeNceRpOOTnUSqodPCswGxPB8iqpwvCb8Lh54A8yu8fF6HqxhTTN?=
 =?us-ascii?Q?lUQAU76N8M7kQXvWuVgvkoXbhlZQVRp+v3vyTk0ekH3OIRRaMqU8913x/NAf?=
 =?us-ascii?Q?Ne0YctfXs3jsne/BWlmOvZt5Eqmpd2lF9KcfAls9RqnOXDHquAltjzUnYMkM?=
 =?us-ascii?Q?osOgkcX0T7a3VymWALNdzjAaSyeOkZhyLjDLysqvD+Ihu+xZE+vB0+IFtzQR?=
 =?us-ascii?Q?g8/irlheWjRJ0U7WzKbwhijVZZ7H+4uKryXXyTREZX5QJHe6uaU1giQL6cQS?=
 =?us-ascii?Q?xzNjEB7rxo/f2S3H+3C8aGsQy4bFWYh5LYZOHrqW12KrACUVlfDfPh2HnbY5?=
 =?us-ascii?Q?K0pHwKVmfXiPQmNPD9l0COOsvTgybM+CChu+oUkXcCIQasQ6BHXdrABG7JbT?=
 =?us-ascii?Q?o5rA7Z8OWcaBZsFkgWfLQAgomvnw/rRqjHhhcvJkKDtCE9vSOuVOnWvQXpYB?=
 =?us-ascii?Q?w/aXRboosCml9mT/XPsQiZhAeFiXQ00RVFRfff3KcXh8oI+DmmvhG9mb0jS+?=
 =?us-ascii?Q?M6GfQ/XRLJ/pAriR4pHb0gI96aryr5LTF3nI5XyXoNiYdp9zBtErCZgDvloo?=
 =?us-ascii?Q?3iWOHS+K+R3EZoUnEu3odaWGhoruqpA5grbp4CEfhAU4eDlME4c7GOUDBQMn?=
 =?us-ascii?Q?cPpjPEJVeEFmiLQTzRKVfejIM7KMf0CDjWQSj9SpfL0Xkh/tor8E6QH0NtZd?=
 =?us-ascii?Q?iFZUPfNi2xnX/tjoAcFhYxmI+uKsnBjn4lb5ZEP5HC+8eXFmMc6NCBfBwAOh?=
 =?us-ascii?Q?O4c06OzHz39N2Vr1+HyTZ1eTmkiDcmuG3XqHlzB5/ogOesFO5+Sa1uTSh9Es?=
 =?us-ascii?Q?gRf3T6njS4jyIrOALQe9C8S8phNxf2b6mlTG56OXS+I+t729eyqRUmDEenmK?=
 =?us-ascii?Q?Cf6Nl11UxKvypdA0v1Vg2mxG4+TDvNPOva70vRNZSYY/7euM+EdFnw4n5CoZ?=
 =?us-ascii?Q?uLZd2tN/i8GdqInRpe2n6bewNOMTTcQLg8FQ6CQO5FaMiWzxGzm2Cx+66RYz?=
 =?us-ascii?Q?qt9CSi+WRbYvyUt5qb+P5OYp33r09KAb+LKL7XJm3EHAchudcRnP1bi/py9v?=
 =?us-ascii?Q?R8V1TfKuR181fI9jcwgGia/BoriXgRmXrCma0YhR5ZNHWHE5uJEaJma31VOn?=
 =?us-ascii?Q?WSxJH415x0LFrF44t3Sf4frW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65a98f0c-e9a0-45fa-3f81-08d98e13afb3
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 06:35:45.7196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nADN7oVvR6ve+weI23ksglTfQzaRLdVvAWIqXfvmHTvlKdEJK/+RvUhcnxTKaIo7A904LLzOT1QGZwT6Nm0p9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3047
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/iommu/apple-dart.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 280ff8df728d..5eeb8d6b72e2 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -701,13 +701,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev)
 	if (!group)
 		goto out;
 
-	group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);
+	group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL);
 	if (!group_master_cfg) {
 		iommu_group_put(group);
 		goto out;
 	}
 
-	memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));
 	iommu_group_set_iommudata(group, group_master_cfg,
 		apple_dart_release_group);
 
-- 
2.20.1