Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Oct 2021 09:23:42 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Drew Fustini <dfustini@baylibre.com>
Cc:     Benoit Cousson <bcousson@baylibre.com>,
        Dave Gerlach <d-gerlach@ti.com>, Keerthy <j-keerthy@ti.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>, linux-omap@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x: Add rtc node as system-power-controller
Message-ID: <YWaJfofs8QAtBnVu@hovoldconsulting.com>
References: <20211012191311.879838-1-dfustini@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211012191311.879838-1-dfustini@baylibre.com>
Precedence: bulk

On Tue, Oct 12, 2021 at 12:13:12PM -0700, Drew Fustini wrote:
> From: Keerthy <j-keerthy@ti.com>
> 
> PMIC_PWR_EN pin of RTC on am335x-evm, bone, and boneblack is connected to
> PMIC on board, so flag rtc node as system-power-controller to allow
> software to poweroff boards.

The "system-power-controller" property is already set in
bone-common.dtsi since

	2876cc4a773c ("ARM: dts: Move most of am335x-boneblack.dts to am335x-boneblack-common.dtsi")

so this probably only affects am335x-evm and that should be reflected in
the commit message.

Also, should you now remove the property from boneblack-common? Or just
add it to am335x-evm instead?

> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
>  arch/arm/boot/dts/am335x-bone-common.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 0ccdc7cd463b..56ae5095a5b8 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -399,6 +399,7 @@ &sham {
>  &rtc {
>  	clocks = <&clk_32768_ck>, <&clk_24mhz_clkctrl AM3_CLK_24MHZ_CLKDIV32K_CLKCTRL 0>;
>  	clock-names = "ext-clk", "int-clk";
> +	system-power-controller;
>  };
>  
>  &pruss_tm {

Johan