Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e0a2e8ae07d71eb86499ed37c8acf57f557987fe.camel@linux.ibm.com>
Subject: Re: [RFC PATCH 1/1]  s390/cio: make ccw_device_dma_* more robust
From:   Vineeth Vijayan <vneethv@linux.ibm.com>
To:     Halil Pasic <pasic@linux.ibm.com>
Cc:     Peter Oberparleiter <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Michael Mueller <mimu@linux.ibm.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, bfu@redhat.com
Date:   Wed, 13 Oct 2021 09:29:37 +0200
In-Reply-To: <20211012233247.63b7a22c.pasic@linux.ibm.com>
References: <20211011115955.2504529-1-pasic@linux.ibm.com>
         <13162b9e48402f306b3f50e6686d76a051138a75.camel@linux.ibm.com>
         <20211012233247.63b7a22c.pasic@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-10-12 at 23:32 +0200, Halil Pasic wrote:
> On Tue, 12 Oct 2021 15:36:36 +0200
> Vineeth Vijayan <vneethv@linux.ibm.com> wrote:
> 
> > Looks good. Thanks.
> > Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>
> 
> Can I convince you to upgrade to Reviewed-by?
You got it.

Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
> 
> > Some minor questions below.
> > 
> > On Mon, 2021-10-11 at 13:59 +0200, Halil Pasic wrote:
> > > Since commit 48720ba56891 ("virtio/s390: use DMA memory for ccw
> > > I/O
> > > and
> > > classic notifiers") we were supposed to make sure that
> > > virtio_ccw_release_dev() completes before the ccw device and the
> > > attached dma pool are torn down, but unfortunately we did
> > > not.  Before
> > > that commit it used to be OK to delay cleaning up the memory
> > > allocated
> > > by virtio-ccw indefinitely (which isn't really intuitive for guys
> > > used
> > > to destruction happens in reverse construction order), but now we
> > > trigger a BUG_ON if the genpool is destroyed before all memory
> > > allocated
> > > form it.  
> > allocated from it ?
> 
> Yes. And I think I should add "is deallocated." to the end as well,
> because we don't destroy memory, we deallocate it ;)