Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] btrfs: replace snprintf in show functions with sysfs_emit
To:     Qing Wang <wangqing@vivo.com>, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1634095717-4480-1-git-send-email-wangqing@vivo.com>
From:   Anand Jain <anand.jain@oracle.com>
Message-ID: <6f03e790-6f21-703f-c761-a034575f465e@oracle.com>
Date:   Wed, 13 Oct 2021 15:51:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <1634095717-4480-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUdOc0lXWWVueDE5dlhhSkQrelFMNkJheHB2bWR1czVCVGdOdU1oc3ZzMjFB?=
 =?utf-8?B?V0tEK1Jtd3NjcC9WOGc3VlFkRkNmQ2JiWTFORFpuT3cyaUN4b0ZxTVdDUWxZ?=
 =?utf-8?B?RExOczc3cW5hZWRBYjRrNUptNzdVQkEzcTlnVldiUkFCdnNCUzRQMG1BVGEx?=
 =?utf-8?B?and4c1ZoeDJQazc3YkEvNjIrWjByY1VJc1UzVXVLM2FBd2dXalFXRjZhaGRW?=
 =?utf-8?B?V3VhdUtLRHVyZHNFMnhXZCsvWUhvN0ltWk01cDB0NVUzWmNSSS9tdWtRN1ln?=
 =?utf-8?B?Vm1QMXFLL1hHano1RDNMb01hTklYY05oR080K1EvQitZSm94L016bkRKU3lx?=
 =?utf-8?B?N1RjbGRLeVU2ay8yWVcyckpFNXRQUXFBSWhXRkhMNEQ5MndLQXNjNXNUV3BS?=
 =?utf-8?B?NEFvV3dUVUJZN3VWTWxFOXFCRVBBbTNBOEZtbjlWUmFWM3pUOVdsOVVLY1Zq?=
 =?utf-8?B?Y3ArRTMvcEEyVkJKSFBnZHBGQ1dwOS9GMmFYdmszcXRlRGNlMHNGcDlwOHBI?=
 =?utf-8?B?R0NaeHVTVHpDZEhlWWFJMUhVdlE4RE8xOGZLZmMzYXVTYXRHcjVRS3VkZk5x?=
 =?utf-8?B?SWdCR1hHVVJKWmxidGVkN0hiSUpSb0JlTk92aGRUVGFFU3Q0YWJlYUFuZk9G?=
 =?utf-8?B?aDJRenlVSFRTVXNUS2xFc1pUVXBCSUJ0Y0hldUZaeFJPMkN2U2RGR3pQNFVK?=
 =?utf-8?B?Sm1BdlpkVEVubFpDUU1XN0s3cFZTRFBEYmw5cWFMM2wzaU8rYkp1N3Z3d2hx?=
 =?utf-8?B?bW1kM051aEZ5d3A2bnNkalBmb3kyMG53Mm5lb1F4c0tYNVRNa3RBbUFlaVdY?=
 =?utf-8?B?dmFCQmF1VStGOFRQK3JCVjkrbGExaWJXVCtod251Q2kyU0NLQTYyOUcyQWth?=
 =?utf-8?B?TzZuc09JenhsV25iY2RTWTZrSnRNVFBxQlJqengzd3hMeUdhZ1lRdmJsMVdF?=
 =?utf-8?B?dmthZDRnMEFSYy9uZG8vb0FSRms0eFdzTjh0b0xaNjFBb2JRMCtGd3Z5eDZU?=
 =?utf-8?B?cDFPZWZXUkZsY2l4czVBL1dHUWJvMUNlMHgyT0x1MEI5SXRpZnJMdjdJYXVB?=
 =?utf-8?B?TUE1aFhFVmdWdzFycmdtSEgyRjY2QTFVRXIrTnBidGZRNGlNK1pOVjdzenJZ?=
 =?utf-8?B?ZUxwZld3Slo1bExWd0JqaDgvbHZ0bnIzNTdqSHJDQnN1ZXhIZzlNdlp3N3hV?=
 =?utf-8?B?Nmg0K21MQjBaVkR6WmJEUWx2WG5sM09BMHY0WEhGVzhTdUZ2Ny8rT0NybDRZ?=
 =?utf-8?B?ZVljVVJSRmZxd1F2ZENVVXQ3UXJyS083N1ZFZVcvdWs4RHJFbW5nMDY5N2ZW?=
 =?utf-8?B?dHJxcjkvUXQ0RHVwY3lSOW4vdUttK08zTmg2dTVsS2hGL2dTaEVKUDFERzR0?=
 =?utf-8?B?VVVxNC96QldyRUY1L3Eza2hZM0l1NUJpbnNkaXdnTUdLdk1yblRlck1RZFVq?=
 =?utf-8?B?cUNkVjZvcytiakQxck1MRzM3ZE00NXJBcGpYTWl4Uk1mYW1OT2VISmhsY2hn?=
 =?utf-8?B?ZldDWGdCOXhSUm9STVl5SUVacW0vcVBIR0FTeGQ3b0RTUnQ3UFdqT2ZzTWt0?=
 =?utf-8?B?MVBObSszdVV2UG5iNnM5cTg4b1ZlMGZwR3I2ZmNEd1loaHZrN1NLSFlVcDhC?=
 =?utf-8?B?RTB6eVM4b1ROelp4dHcxcFVBOEV5bTNJbnZCRWNVQTk0elB0WVNZbGx6Wnd6?=
 =?utf-8?B?UG1iZUR4c0oxUjd0Vjh2MUVlWHBJRjdxR1o0VmgrWll0bE9XM25PMHZ1UHNQ?=
 =?utf-8?Q?44Ezt6ZRuV9jEGakqVc6nQmSXBCkPC5ew2BcCnv?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79488dfb-fc90-43d4-2ed5-08d98e1e4b7c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 07:51:41.6905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2wmZ7B/X0y1CwO6Y1ZwpMpKaZ+KJAMI0fVKP1hjnMDcewejv7+fgIMhWw8Q0BbzgeabjX8hfXdr0VDMG2LbQmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4095
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110130052
X-Proofpoint-GUID: VyXizssHNXxfxGlzH229aFrGY8uBUK84
X-Proofpoint-ORIG-GUID: VyXizssHNXxfxGlzH229aFrGY8uBUK84
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/10/2021 11:28, Qing Wang wrote:
> coccicheck complains about the use of snprintf() in sysfs show functions.

It looks like the reason is snprintf() unaware of the PAGE_SIZE 
max_limit of the buf.

> Fix the following coccicheck warning:
> fs/btrfs/sysfs.c:335:8-16: WARNING: use scnprintf or sprintf.

Hm. We use snprintf() at quite a lot more places in sysfs.c and, I don't 
see them getting this fix. Why?

> Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Below commit has added it. Nice.

commit 2efc459d06f1630001e3984854848a5647086232
Date:   Wed Sep 16 13:40:38 2020 -0700

     sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs out

Thanks, Anand

> 
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
>   fs/btrfs/sysfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index 9d1d140..fda094a 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -332,7 +332,7 @@ BTRFS_ATTR(static_feature, supported_checksums, supported_checksums_show);
>   static ssize_t send_stream_version_show(struct kobject *kobj,
>   					struct kobj_attribute *ka, char *buf)
>   {
> -	return snprintf(buf, PAGE_SIZE, "%d\n", BTRFS_SEND_STREAM_VERSION);
> +	return sysfs_emit(buf, "%d\n", BTRFS_SEND_STREAM_VERSION);
>   }
>   BTRFS_ATTR(static_feature, send_stream_version, send_stream_version_show);
>   
>