Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] locking/mutex: remove rcu_read_lock/unlock as we
 already disabled preemption
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@redhat.com, will@kernel.org, longman@redhat.com,
        boqun.feng@gmail.com, linux-kernel@vger.kernel.org
References: <20211008032518.1298372-1-yanfei.xu@windriver.com>
 <YWWKhoRzUWoMsJbk@hirez.programming.kicks-ass.net>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <1aab91a4-07fc-c7f3-d04b-93ccf05ae425@windriver.com>
Date:   Wed, 13 Oct 2021 15:54:02 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YWWKhoRzUWoMsJbk@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDIySGcvdThqb1ljRjQ4K2tzalR2cERyQ250Wk1yZGd2bGhxY085UGViQnJv?=
 =?utf-8?B?TXVHajh0NzFUSlZrNldLWXhURUpscW5TMlVmc1JCWWlheGhBd3MyT3p1ZzBY?=
 =?utf-8?B?N2ZQR2xmNVJudngyZlg3K2tsQU1zYU1YOU53b3NOcUNqQ2VhZEdzNnpTNEJy?=
 =?utf-8?B?dHYxeUR1Y1AwY01VbXlWZ2F2WXdNSEo0bnlSc3cwN2tzekdPeFBEK293NlRo?=
 =?utf-8?B?N2N4YVJSRk1TMjhaakllYm5yOFFoUGpYY2RoUHhmOG0veC8wQm1IYmxSZmFB?=
 =?utf-8?B?ZjRGaEtWc1QzZGsvS0M3SXZZdW9LeGoxcjBkT05xajEwb1puUkhhUW8wbEpp?=
 =?utf-8?B?Qy96WGE5OXh4YWdRU1NnY2t3NHdUUXJBQXYxUkFpVjZra2NNUlhOZUNVOUgr?=
 =?utf-8?B?dUhSM21KZmp1bWxDMGlCVjRJbFVTbDNtRFczWVBlWHFWbkFhMWxyVXVrNm1F?=
 =?utf-8?B?QUUreVFYVVhpajg4Yk1KM1BQQWlVWmpqTytORHhxQWx5Q1I1YjVwSm5razNy?=
 =?utf-8?B?dEc3cHRxd3AwbGR3VTZrQ0luL0dPdXZFUCtwa2dLRS9jZC8vUTFMa2FjSUlK?=
 =?utf-8?B?b2s1QkJYUnpiVmNRTjRsQlFmMWEveDgzRFpQdG9nbG5mZFlxeit4WXFvdWJi?=
 =?utf-8?B?NEk3VUtUYVdIdTFPb2xEMWFMTkovcXBSR1NmRnNQWXFNMG5DRXZwaDJYNDNv?=
 =?utf-8?B?WnpGRXBUYjBjdXN2bkJxUEJuNms0QjBjK1BGdzZ1RURjT2ttRTVVSDFHa3Zx?=
 =?utf-8?B?Vk5kU1U5L0VrRStPaG5kWUFFK0w2K3NqUTg4VW10aU9MNjFwMm9LYzA2WVM4?=
 =?utf-8?B?N0ROMjlMSFAybU45WXMyRE80eVQ0SUVzaG0rODNLSGZYa1hXVFZCWDdsNGhZ?=
 =?utf-8?B?QWtRTERhMU43T3BtV1RtZjJJS2VPTHE1K1RnTEFRZ2xjWDJBdzJhRGdBUk5i?=
 =?utf-8?B?MXdyQWd1TytUREkvcUlUT1VSS1ROa1VNY1ZVT3FVZEVhOXZnanMvSzlUeTJX?=
 =?utf-8?B?d05zMG41RWtDZjhTRXZWSTVCT0EyOXRjV2UweCt4Q0ZncStqS1BPc05lcnFz?=
 =?utf-8?B?NG94VTkxeEpFWXRtU2dGakVrdTVKcSs0MUFwV2VqdGozWTYvVWdlU3U3OEsr?=
 =?utf-8?B?b3Nob3d0aVl1Z3lidWtpdVVJYTRPa1Q1S3lpTFFLdnRxOGZMYzRSWWphZmY3?=
 =?utf-8?B?Q2dnaTZUNnBPYk90U3hIN3JsT0FsU0QyejhGOEJHTTJ0MWNnWSt5L1hTMHZy?=
 =?utf-8?B?UlVjZXY5MnhZZnNaMTd6QlZKOWtjam5tN05WUGY5SHd3V2dOeE43SHQraWJp?=
 =?utf-8?B?dmJ4eEVhOXJKamFjdVpkNDJ1TmJPb0l3Umo3dHRLQUx5MEh3dzRadFcrZ0I1?=
 =?utf-8?B?d2lwRU9OVmVhSko3RjVmTmJnOVhtQ2NaMjIxRzVTSXBqdW50T3AzaWtlVExi?=
 =?utf-8?B?aWRsTE5VTkRPYmVJeEtoMmlkZGRDSDlRU3Q4cDEwakVreVhJSlpESUQ0SXZO?=
 =?utf-8?B?WExKQlorZEMxVVRIdlhRWE1TRDIrWGxDRUlUVzA4Mk1zamo5MTdZbCtCeWtk?=
 =?utf-8?B?STVYTERUN3I3S1oyZFhKMU8zUUNvckJyUHhoMWMvdGVsSmxORUxPM2pCbGYr?=
 =?utf-8?B?bHQzdU8yYU9GdTJrVEJJbGhQUGhCMFFSZUk2NWpQUFQ1MGhJMGl5K2FPNHlQ?=
 =?utf-8?B?a2ZoemhSMjJBMFAxUGU0K20xbFFoNG92TzNMbDIwcW9NeDFteTlyS3ArbFR4?=
 =?utf-8?Q?rIMRwqjcdsu3SgBt8dL6EHtIbwsZ9rvpQ9HV+Xd?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 449b5031-eeee-4341-ce63-08d98e1ea353
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5739.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 07:54:09.2566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R0pQmCrw7dbme5y3Q+Qc7uZ0ESpX2uuF3G+nIbstYyt67/eIWeJVeqxe9t+tPjc6GmRvXKrbH8MR0N+eCjyDxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5219
X-Proofpoint-GUID: Dgs9viuEPDgFW9CHmPKUlpq1bgaDxwnX
X-Proofpoint-ORIG-GUID: Dgs9viuEPDgFW9CHmPKUlpq1bgaDxwnX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-13_02,2021-10-13_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0
 bulkscore=0 clxscore=1011 suspectscore=0 adultscore=0 mlxlogscore=983
 spamscore=0 malwarescore=0 priorityscore=1501 mlxscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110130052
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/12/21 9:15 PM, Peter Zijlstra wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On Fri, Oct 08, 2021 at 11:25:18AM +0800, Yanfei Xu wrote:
>> preempt_disable/enable() is equal to RCU read-side crital section,
>> and the mutex lock slowpath disabled the preemption for the optimistic
>> spinning code. Let's remove the rcu_read_lock/unlock for saving some
>> cycles in hot codes.
>>
>> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
>> ---
>> v1->v2: fix the incorrect comment in code and commit message.
>>          thanks for WaiMan's suggestion.
>>
>> BTW, sorry for this late v2 due to a long vocation.
>>
>>   kernel/locking/mutex.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
>> index 2fede72b6af5..2f654cfb10d9 100644
>> --- a/kernel/locking/mutex.c
>> +++ b/kernel/locking/mutex.c
>> @@ -351,13 +351,14 @@ bool mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner,
>>   {
>>        bool ret = true;
> 
>          lockdep_assert_preemption_disabled();

Agree.

> 
>> -     rcu_read_lock();
>>        while (__mutex_owner(lock) == owner) {
>>                /*
>>                 * Ensure we emit the owner->on_cpu, dereference _after_
> 
> And did you check the other code in locking/ for similar things?
> 

I did a check, rwsem also has the similar things. Will do it for rwsem 
in v3.


Thanks,
Yanfei