Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: AW: (EXT) Re: [PATCH v2 1/2] dt-bindings: mtd: spi-nor: Add
 output-driver-strength property
From:   "Alexander Stein" <Alexander.Stein@ew.tq-group.com>
To:     "Michael Walle" <michael@walle.cc>
Cc:     "Miquel Raynal" <miquel.raynal@bootlin.com>,
        "Richard Weinberger" <richard@nod.at>,
        "Vignesh Raghavendra" <vigneshr@ti.com>,
        "Rob Herring" <robh@kernel.org>, "Pratyush Yadav" <p.yadav@ti.com>,
        "Tudor Ambarus" <tudor.ambarus@microchip.com>,
        =?us-ascii?Q?linux-mtd=40lists=2Einfrad?= =?us-ascii?Q?ead=2Eorg?= 
        <linux-mtd@lists.infradead.org>,
        =?us-ascii?Q?devicetree=40vger=2Ekernel=2Eorg?= 
        <devicetree@vger.kernel.org>,
        =?us-ascii?Q?linux-kernel=40vger=2Ekernel=2Eorg?= 
        <linux-kernel@vger.kernel.org>
Date:   Wed, 13 Oct 2021 08:47:04 +0000
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-Id: <kcEE.9geNR42QRKGTSoedF1sEfQ.ALRP5Q7A1wE@vtuxmail01.tq-net.de>
Precedence: bulk

Hello Michael,


Am 2021-10-12 09:48, schrieb Michael Walle:
> Am 2021-10-12 08:17, schrieb Alexander Stein:
> > This property is for optimizing output voltage impedance and is
> > specific to each board. It overwrites the default set by the flash
> > device. Various flash devices support different impedances.
> >=20
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Changes in v2:
> > * Updated the property description and the commit message accordingly
> >=20
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > index ed590d7c6e37..4c3c506a8853 100644
> > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > @@ -72,6 +72,14 @@ properties:
> >        be used on such systems, to denote the absence of a reliable=20
> > reset
> >        mechanism.
> >=20
> > +  output-driver-strength:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      Output driver strength in ohms which optimizes the impedance at=20
> > Vcc/2
> > +      output voltage. This property overwrites the default set by the=20
> > flash
> > +      device. This is board specific and should be determined by the
> > +      manufacturer. Various flash devices support different=20
> > impedances.
>=20
> Mh, this seems to be very tailored to this flash chip. Eg. the "Vcc/2",=20
> is
> this something specific to this flash or is this some kind of common=20
> usage=3F

"Vcc/2" is taken from the datasheet description.

> For example, Winbond flashes specifies the output driver strength in=20
> percent.
> Settings are 25%, 50%, 75%, 100% there.
>=20
> I'd have to ask a hardware guy, if one could convert between these two
> representations of the driver strength.

Well, 100% must map to some actual value. Which then can be used to create
a discrete value table, which are then supported by the flash driver.
E.g. for Micron not every flash supports the same set of settings for
driver strength.
Macronix uses similar settings (values and bitmask), but in a different
register. But if some vendors have pretty much incompatible settings, it
might be feasible to provide vendor specific settings, e.g.
"micron,drive-strength =3D <45>" (for 45 Ohm) or "winbond,drive-strength =3D <100>"
(for 100%).

Best regards,
Alexander