Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v6 40/42] virt: Add SEV-SNP guest driver
To:     Dov Murik <dovmurik@linux.ibm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org
References: <20211008180453.462291-1-brijesh.singh@amd.com>
 <20211008180453.462291-41-brijesh.singh@amd.com>
 <b79cfdfa-6482-70ab-3520-f76387fe4c27@linux.ibm.com>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <ecf55de1-94c7-4f86-2578-141d6dfbe348@amd.com>
Date:   Wed, 13 Oct 2021 06:37:12 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <b79cfdfa-6482-70ab-3520-f76387fe4c27@linux.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEZKbUlnU2xIdFRRRG96VGtTbExlbFl6TC9abVE3a3lCM3dtVnhHS3pxSms1?=
 =?utf-8?B?N0JBczVudlJ0bys3aWFqaGVieVM4QncyTlBRWjRUT24yNnMwVEdUc3k1MWZy?=
 =?utf-8?B?RUxmejl6VmtmWURZS0R0dFY0ZTNxTEdDa21ra2dMSVJBNTlUMGF4YXRDcnlw?=
 =?utf-8?B?cFN4dzFOeVRSUTkvS1g3U1hpQ2VNZ29OblVzckdkMTlkelNHOHZoNzM4WEtR?=
 =?utf-8?B?ZC92bGIrcmJyaUU2OWxjZ1ptZWFCSk5peG4xQjc2VFRqUWJqNFVoMXNXdTdT?=
 =?utf-8?B?YnJCL3FqMkExL2VDNWk5ZG1wVVlSUmJIeFdhTzdwTU0yT0dyQVlLM0V1T1Ri?=
 =?utf-8?B?MG5BeklDTEovTzhpdEpoU2E3dE5zM0JTT2R1NUFvbkVneldnWDFZQzRoUW9R?=
 =?utf-8?B?Rmlld2xYUnZGRHFnNkVHWUZhVGpzWEU1NUlpRWYxT0swNlNQczcrdjhrTGNL?=
 =?utf-8?B?R1NmTCtHd3RIT2tzTTNzSGk3dERKZmFJRVhKNTlwSDBDVHNoaUQ5dXowbXQ1?=
 =?utf-8?B?a1hjeEtBRFJ4bXM3SVVtTmxqYnlsaEZHMWJ6dkhVZjIrUmhFMGM2WE1FbEpj?=
 =?utf-8?B?MGxpcHl6MmhydWoyUm1KR09obUo2anZzeHRWM29NcCtGVk4yL01nRmRLbHZv?=
 =?utf-8?B?dTdKSkhFQTlsODhadkJnM2FLWWx4dk03TU1QK3RGL1VPeklSU2ZJd0IvTFlW?=
 =?utf-8?B?a0lBd0M3R2RxMXk3aTBMdExkcURwQTEvbzhqSFlpNW9IUm5jRUVvRlVOK1Rs?=
 =?utf-8?B?SnB4dFZpcXlxUWExWlhJS2c5Vk5tK2drOUdOTkhHd3RqYzV6VzZ1amdLdnFW?=
 =?utf-8?B?aDNOOWt4L3RTNUQ1S1UyQm9XZ28yMHVaekFOU3NibmhBZ25EZVVHNitVWlFQ?=
 =?utf-8?B?a0E1N3BKN2cvNzRwVmt2TW9YQmtWQzJxajNMdjkwRVF6OEhqTWQxaFU3UEMz?=
 =?utf-8?B?cDRoK3EwaGFkdENmbEF1ODZIMXQwd3pJY3hzSTRXRTh1OUdKZ1hzUTR6QWhm?=
 =?utf-8?B?QUZheTZlVXc1bk95WGV0bWcya0k4eFpzcnQvdmZqT0I0N2g2Q1ZzeWtVaTh6?=
 =?utf-8?B?MHFSbjFkTzFIdTIxM2g1SThZTEtEYTNVYmRubm53K3J5d0tjMG1WY3VzMWQ2?=
 =?utf-8?B?b1ZibGY1NXJWTHpqdzRrUG1PMm01M3E4T1VNckhhTmVvWFFnZFhRWERhNERT?=
 =?utf-8?B?dDlESklJVFJhVGUyd1g1TG5sdHRORVdLdjVxcURTdmxaTUM4RDV3eXFFcnlk?=
 =?utf-8?B?VEJkVWg4VEZqY2Nsc3A3RGw1ZkxOdVJLajdwTmVzUlpqNm5iVEdkTTBuM2VF?=
 =?utf-8?B?NDNYVFhEbzV2aU9MOEFhL2g2WHppRWhMaVNZd1dWSGZZdXhNQ0JaMGJzMnpo?=
 =?utf-8?B?bXlaS0lWRWNDa2xxa0dVYWYzWXRaUWI5ZjRBR0pKRXBIMTVuc2pxUy93WWZR?=
 =?utf-8?B?dzBHSUJxVmRscjhSSzArTVRQOVBJYVFYaDVUcGkybStyRnM3R3RvUUZkcmFE?=
 =?utf-8?B?M0JUS2hyRWdUWjNwNlZvenZmVjVhMW0wd2lRL0JuOGwyamlCRkdERDNlYkwr?=
 =?utf-8?B?MmVIa2s1ZjAzMERHeDZnaHhVK1lNVFZJTnhKNUR3aDdPRE9ic1JReWxXNSt4?=
 =?utf-8?B?VlJiUjZnK3dEU0xDbjl2Y1VhY1NyRUVEZ04zcDR6bmNqYXU5SWNGRk1TYnkx?=
 =?utf-8?B?bUxZZmpHS2RSTVIxYU5kbXVYaFJETEhUQmlKY3N6d0FMWFdCRFBobm5JQUpN?=
 =?utf-8?Q?QeKx4+c63bjbBIo6PybfREWA2nC7KXUOdi5S4Ov?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0205290e-619f-41cd-bcc9-08d98e3dcf0b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 11:37:16.9926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tMsVDuUPOlElvKn8Yf+Y4P8bNgKFV+sobDAmunNfeWPqmnR/DiPQEGCjzNI5GDeI4Ws0AMO3/7yLV3v+u17TBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4559
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dov,

On 10/10/21 10:51 AM, Dov Murik wrote:
> Hi Brijesh,
>
> On 08/10/2021 21:04, Brijesh Singh wrote:
>> SEV-SNP specification provides the guest a mechanisum to communicate with
>> the PSP without risk from a malicious hypervisor who wishes to read, alter,
>> drop or replay the messages sent. The driver uses snp_issue_guest_request()
>> to issue GHCB SNP_GUEST_REQUEST or SNP_EXT_GUEST_REQUEST NAE events to
>> submit the request to PSP.
>>
>> The PSP requires that all communication should be encrypted using key
>> specified through the platform_data.
>>
>> The userspace can use SNP_GET_REPORT ioctl() to query the guest
>> attestation report.
>>
>> See SEV-SNP spec section Guest Messages for more details.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> ---
>>  Documentation/virt/coco/sevguest.rst  |  77 ++++
>>  drivers/virt/Kconfig                  |   3 +
>>  drivers/virt/Makefile                 |   1 +
>>  drivers/virt/coco/sevguest/Kconfig    |   9 +
>>  drivers/virt/coco/sevguest/Makefile   |   2 +
>>  drivers/virt/coco/sevguest/sevguest.c | 561 ++++++++++++++++++++++++++
>>  drivers/virt/coco/sevguest/sevguest.h |  98 +++++
>>  include/uapi/linux/sev-guest.h        |  44 ++
>>  8 files changed, 795 insertions(+)
>>  create mode 100644 Documentation/virt/coco/sevguest.rst
>>  create mode 100644 drivers/virt/coco/sevguest/Kconfig
>>  create mode 100644 drivers/virt/coco/sevguest/Makefile
>>  create mode 100644 drivers/virt/coco/sevguest/sevguest.c
>>  create mode 100644 drivers/virt/coco/sevguest/sevguest.h
>>  create mode 100644 include/uapi/linux/sev-guest.h
>>
> [...]
>
>
>> +
>> +static u8 *get_vmpck(int id, struct snp_secrets_page_layout *layout, u32 **seqno)
>> +{
>> +	u8 *key = NULL;
>> +
>> +	switch (id) {
>> +	case 0:
>> +		*seqno = &layout->os_area.msg_seqno_0;
>> +		key = layout->vmpck0;
>> +		break;
>> +	case 1:
>> +		*seqno = &layout->os_area.msg_seqno_1;
>> +		key = layout->vmpck1;
>> +		break;
>> +	case 2:
>> +		*seqno = &layout->os_area.msg_seqno_2;
>> +		key = layout->vmpck2;
>> +		break;
>> +	case 3:
>> +		*seqno = &layout->os_area.msg_seqno_3;
>> +		key = layout->vmpck3;
>> +		break;
>> +	default:
>> +		break;
>> +	}
>> +
>> +	return NULL;
> This should be 'return key', right?


Yes, I did caught that during my testing and the hunk to fix it is in
42/42. I missed merging the hunk in this patch and will take care in
next rev. thanks