Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: gVgmCvWJ9ecNKu3wuehcCZQzhMW/7yJY52kQ+bFrZme95ab1USK5qJuZn7/b65LJ6L0Fzhc0Vq
 1d6yQc9q6JSUYGa006jwIKW1GmUHauZMppditai1biTGLHXexH4SgrIlT7mEPqawnwtDlUHYj4
 rEawZM7bZXO2Jv4wa+ysS6Bg4M5aAUumwptP30+8Ihp+V4M52mXZmE9em70hS8jGUfpP4oxRMo
 9qGNRfyy2Q2zNRjm1oElLR7KNUynY+jhJHYndB9orr7yfCsveZ42trXMmVfZZc59yOJ8dkphQV
 //LQIUhwz8GplLmfQJ9zfq5M
Date:   Wed, 13 Oct 2021 13:41:44 +0200
From:   Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To:     Codrin Ciubotariu - M19940 <Codrin.Ciubotariu@microchip.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        Ludovic Desroches - M43218 <Ludovic.Desroches@microchip.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] i2c: at91: Add support for programmable clock source
Message-ID: <20211013114144.7j4scdaq2rjfmiwn@soft-dev3-1.localhost>
References: <20211012140718.2138278-1-horatiu.vultur@microchip.com>
 <8a775c67-00a3-1dbe-daa3-09a537f482d8@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <8a775c67-00a3-1dbe-daa3-09a537f482d8@microchip.com>
Precedence: bulk

The 10/13/2021 08:49, Codrin Ciubotariu - M19940 wrote:
> On 12.10.2021 17:07, Horatiu Vultur wrote:
> > Add support to be able to set BRSRCCLK. This feature is support on lan966x
> > 
> > Horatiu Vultur (2):
> >    dt-bindings: i2c: at91: Extend compatible list for lan966x
> >    i2c: at91: add support for brsrcclk
> > 
> >   .../devicetree/bindings/i2c/i2c-at91.txt      |  6 +++--
> >   drivers/i2c/busses/i2c-at91-core.c            | 16 +++++++++++++
> >   drivers/i2c/busses/i2c-at91-master.c          | 23 +++++++++++++++++--
> >   drivers/i2c/busses/i2c-at91.h                 |  1 +
> >   4 files changed, 42 insertions(+), 4 deletions(-)
> > 
> 
> Hi Horatiu,

Hi Codrin,

> 
>  From what I understand, on your DTS, you replaced the peripheral clock 
> with the GCLK in the I2C node. This means that you are forcing all the 
> variants that support clk_brsrcclk to treat the current clock as GCLK. 
> This is not necessarily correct, since this newer variants can also work 
> fine with only the peripheral clock and we should keep these option 
> available.
> 
> I would add an optional GCLK clock binding in the I2C node. This way 
> GCLK will be used only if it is present in DT and clk_brsrcclk set.

Thanks for the explanation.

I think actually I will drop this patch series because apparently
lan966x works fine also with the peripheral clock. So then no changes
are required.

If you think is worth it, I can do another version with the proposed
changes.

> 
> Best regards,
> Codrin

-- 
/Horatiu