Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Oct 2021 13:42:59 +0200
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     DENG Qingfang <dqfext@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        John Crispin <john@phrozen.org>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [net-next PATCH v6 05/16] net: dsa: qca8k: add support for cpu
 port 6
Message-ID: <YWbGQ4omD537ZBh1@Ansuel-xps.localdomain>
References: <20211013011622.10537-1-ansuelsmth@gmail.com>
 <20211013011622.10537-6-ansuelsmth@gmail.com>
 <20211013041004.29805-1-dqfext@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211013041004.29805-1-dqfext@gmail.com>
Precedence: bulk

On Wed, Oct 13, 2021 at 12:10:04PM +0800, DENG Qingfang wrote:
> On Wed, Oct 13, 2021 at 03:16:11AM +0200, Ansuel Smith wrote:
> > @@ -1017,13 +1033,14 @@ static int
> >  qca8k_setup(struct dsa_switch *ds)
> >  {
> >  	struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
> > +	u8 cpu_port;
> >  	int ret, i;
> >  	u32 mask;
> >  
> > -	/* Make sure that port 0 is the cpu port */
> > -	if (!dsa_is_cpu_port(ds, 0)) {
> > -		dev_err(priv->dev, "port 0 is not the CPU port");
> > -		return -EINVAL;
> > +	cpu_port = qca8k_find_cpu_port(ds);
> > +	if (cpu_port < 0) {
> 
> cpu_port should be of type int, otherwise this is always false.
>

Sorry for ignoring the prev review. Now I see what you mean and you are
totally right!

> > +		dev_err(priv->dev, "No cpu port configured in both cpu port0 and port6");
> > +		return cpu_port;
> >  	}

-- 
	Ansuel