Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Oct 2021 07:56:38 -0500
From:   Andrew Halaney <ahalaney@redhat.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>, akpm@linux-foundation.org,
        bp@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: Make unknown command line param message clearer
Message-ID: <20211013125638.4nc4bnbzbeixfrii@halaneylaptop>
References: <20211012213523.39801-1-ahalaney@redhat.com>
 <20211012200106.1afdbb0b@gandalf.local.home>
 <87853d4f-d6f8-1d58-1a07-c8232dae87fd@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87853d4f-d6f8-1d58-1a07-c8232dae87fd@infradead.org>
Precedence: bulk

On Tue, Oct 12, 2021 at 05:18:32PM -0700, Randy Dunlap wrote:
> On 10/12/21 5:01 PM, Steven Rostedt wrote:
> > On Tue, 12 Oct 2021 16:35:23 -0500
> > Andrew Halaney <ahalaney@redhat.com> wrote:
> > 
> > > --- a/init/main.c
> > > +++ b/init/main.c
> > > @@ -925,6 +925,10 @@ static void __init print_unknown_bootoptions(void)
> > >   	for (p = &envp_init[2]; *p; p++)
> > >   		end += sprintf(end, " %s", *p);
> > > +	pr_notice("The kernel command line has unknown parameters. They are either\n");
> > > +	pr_notice("misspelled, not valid for the current kernel configuration,\n");
> > > +	pr_notice("or are meant for init but are not after the '--' delineator. They will\n");
> > > +	pr_notice("be passed to init along with those after '--' on the command line.\n");
> > >   	pr_notice("Unknown command line parameters:%s\n", unknown_options);
> > >   	memblock_free(unknown_options, len);
> > 
> > What about just changing it to simply say:
> > 
> > 	pr_notice("Unknown kernel command line parameters "%s", will be	passed to user space.\n",
> > 		  unknown_options);
> > 
> 
> Yes, that's much more palatable.
> 
> thanks.
> -- 
> ~Randy
> 

Heh, that's basically what the users suggested too but I wasn't the
biggest fan since I didn't think it highlighted the points I tried to
make. I guess I'm just too verbose :P

I'll spin a v2 with that considering everyone likes that form more.

Thanks,
Andrew