Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7fb08233-efc9-b0bd-b234-084e52878036@canonical.com>
Date:   Wed, 13 Oct 2021 15:22:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH][next] PCI: apple: Remove redundant initialization of
 pointer port_pdev
Content-Language: en-US
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc:     Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Marc Zyngier <maz@kernel.org>, Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211012133235.260534-1-colin.king@canonical.com>
 <20211013134114.GC11036@lpieralisi>
From:   Colin Ian King <colin.king@canonical.com>
In-Reply-To: <20211013134114.GC11036@lpieralisi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/10/2021 14:41, Lorenzo Pieralisi wrote:
> On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer port_pdev is being initialized with a value that is never
>> read, it is being updated later on. The assignment is redundant and
>> can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   drivers/pci/controller/pcie-apple.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Squashed into the commit it is fixing.
> 

Thanks. Much appreciated.

> Thanks !
> Lorenzo
> 
>> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
>> index b4db7a065553..19fd2d38aaab 100644
>> --- a/drivers/pci/controller/pcie-apple.c
>> +++ b/drivers/pci/controller/pcie-apple.c
>> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>>   {
>>   	struct pci_config_window *cfg = pdev->sysdata;
>>   	struct apple_pcie *pcie = cfg->priv;
>> -	struct pci_dev *port_pdev = pdev;
>> +	struct pci_dev *port_pdev;
>>   	struct apple_pcie_port *port;
>>   
>>   	/* Find the root port this device is on */
>> -- 
>> 2.32.0
>>